From: Conor Dooley <conor@kernel.org>
To: Andrew Jones <ajones@ventanamicro.com>
Cc: linux-riscv@lists.infradead.org,
'Jisheng Zhang ' <jszhang@kernel.org>,
'Heiko Stuebner ' <heiko@sntech.de>,
'Paul Walmsley ' <paul.walmsley@sifive.com>,
'Palmer Dabbelt ' <palmer@dabbelt.com>,
'Conor Dooley ' <conor.dooley@microchip.com>,
'Albert Ou ' <aou@eecs.berkeley.edu>
Subject: Re: [PATCH 5/5] riscv: cpufeature: Drop unused includes
Date: Thu, 23 Feb 2023 23:29:43 +0000 [thread overview]
Message-ID: <Y/f25zqMFNDWD2ix@spud> (raw)
In-Reply-To: <20230221185603.570882-6-ajones@ventanamicro.com>
[-- Attachment #1.1: Type: text/plain, Size: 1585 bytes --]
On Tue, Feb 21, 2023 at 07:56:03PM +0100, Andrew Jones wrote:
> Do some additional include pruning while dropping errata_list.h,
> which is getting dropped, since cpufeature.c includes hwcap.h
> directly to get cpufeature IDs.
This commit message is a wee bit confusingly written. Not advocating
for a respin by any means, but putting the thing that motivated the
change before the opportunistic cleanups would have made more sense to
me. /shrug
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> Signed-off-by: Andrew Jones <ajones@ventanamicro.com>
> ---
> arch/riscv/kernel/cpufeature.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeature.c
> index 85c99ae64017..151e1a715db9 100644
> --- a/arch/riscv/kernel/cpufeature.c
> +++ b/arch/riscv/kernel/cpufeature.c
> @@ -8,19 +8,14 @@
>
> #include <linux/bitmap.h>
> #include <linux/ctype.h>
> -#include <linux/libfdt.h>
> #include <linux/log2.h>
> #include <linux/module.h>
> #include <linux/of.h>
> #include <asm/alternative.h>
> #include <asm/cacheflush.h>
> -#include <asm/errata_list.h>
> #include <asm/hwcap.h>
> #include <asm/patch.h>
> -#include <asm/pgtable.h>
> #include <asm/processor.h>
> -#include <asm/smp.h>
> -#include <asm/switch_to.h>
>
> #define NUM_ALPHA_EXTS ('z' - 'a' + 1)
>
> --
> 2.39.1
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-02-23 23:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 18:55 [PATCH 0/5] riscv: alternative/cpufeature related cleanups Andrew Jones
2023-02-21 18:55 ` [PATCH 1/5] riscv: Rename Kconfig.erratas to Kconfig.errata Andrew Jones
2023-02-23 23:11 ` Conor Dooley
2023-02-24 12:37 ` Heiko Stübner
2023-02-21 18:56 ` [PATCH 2/5] riscv: alternatives: Remove unnecessary define and unused struct Andrew Jones
2023-02-23 23:14 ` Conor Dooley
2023-02-24 12:44 ` Heiko Stübner
2023-02-21 18:56 ` [PATCH 3/5] riscv: alternatives: Rename errata_id to patch_id Andrew Jones
2023-02-23 23:24 ` Conor Dooley
2023-02-24 8:06 ` Andrew Jones
2023-02-24 12:46 ` Heiko Stübner
2023-02-21 18:56 ` [PATCH 4/5] riscv: lib: Include hwcap.h directly Andrew Jones
2023-02-23 23:25 ` Conor Dooley
2023-02-24 12:46 ` Heiko Stübner
2023-02-21 18:56 ` [PATCH 5/5] riscv: cpufeature: Drop unused includes Andrew Jones
2023-02-23 23:29 ` Conor Dooley [this message]
2023-02-24 8:06 ` Andrew Jones
2023-02-24 12:48 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/f25zqMFNDWD2ix@spud \
--to=conor@kernel.org \
--cc=ajones@ventanamicro.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor.dooley@microchip.com \
--cc=heiko@sntech.de \
--cc=jszhang@kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.