From: Lee Jones <lee@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "Pali Rohár" <pali@kernel.org>, "Arnd Bergmann" <arnd@arndb.de>,
"Linus Walleij" <linus.walleij@linaro.org>,
soc@kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH RESEND 4/8] dt-bindings: leds: Add cznic,turris1x-leds.yaml binding
Date: Fri, 24 Feb 2023 09:38:37 +0000 [thread overview]
Message-ID: <Y/iFnUAMl6YS1pSV@google.com> (raw)
In-Reply-To: <98867251-1f59-fdc6-9535-49db7b24140a@kernel.org>
On Fri, 24 Feb 2023, Krzysztof Kozlowski wrote:
> On 27/01/2023 12:16, Lee Jones wrote:
> > On Mon, 26 Dec 2022, Pali Rohár wrote:
> >
> >> Add device-tree bindings documentation for Turris 1.x RGB LEDs.
> >>
> >> Signed-off-by: Pali Rohár <pali@kernel.org>
> >> ---
> >> .../bindings/leds/cznic,turris1x-leds.yaml | 118 ++++++++++++++++++
> >> 1 file changed, 118 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/leds/cznic,turris1x-leds.yaml
> >
> > Needs a DT Ack (now Cc:ed)
>
> Within the same day of posting v2 of this - just after 4 hours, Pali
> received review and I pointed issue to address.
>
> The issue was not addressed, just ignored.
>
> Therefore this patch shall not be taken, until the issues are resolved
> or discussion is finished if there is disagreement about my comments..
Understood. Thanks for the clarification.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-02-24 9:38 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-26 12:36 [PATCH RESEND 0/8] Resend LED patches Pali Rohár
2022-12-26 12:36 ` [PATCH RESEND 1/8] dt-bindings: leds: register-bit-led: Add active-low property Pali Rohár
2023-01-27 11:16 ` Lee Jones
2023-02-23 14:22 ` Lee Jones
2023-02-23 16:48 ` Pali Rohár
2023-02-23 20:59 ` Linus Walleij
2023-02-24 8:42 ` Krzysztof Kozlowski
2022-12-26 12:36 ` [PATCH RESEND 2/8] leds: syscon: Implement support for " Pali Rohár
2023-02-23 14:25 ` Lee Jones
2022-12-26 12:36 ` [PATCH RESEND 3/8] powerpc/85xx: DTS: Add CPLD definitions for P1021RDB Combo Board CPL Design Pali Rohár
2022-12-26 12:36 ` [PATCH RESEND 4/8] dt-bindings: leds: Add cznic,turris1x-leds.yaml binding Pali Rohár
2023-01-27 11:16 ` Lee Jones
2023-02-24 9:15 ` Krzysztof Kozlowski
2023-02-24 9:38 ` Lee Jones [this message]
2023-03-09 20:42 ` Pali Rohár
2023-03-11 11:47 ` Krzysztof Kozlowski
2023-02-24 9:13 ` Krzysztof Kozlowski
2022-12-26 12:36 ` [PATCH RESEND 5/8] leds: Add support for Turris 1.x LEDs Pali Rohár
2023-01-27 11:20 ` Lee Jones
2023-02-02 23:46 ` Pali Rohár
2023-02-24 9:25 ` Krzysztof Kozlowski
2023-02-24 9:37 ` Lee Jones
2023-02-24 9:22 ` Krzysztof Kozlowski
2023-02-24 9:28 ` Lee Jones
2023-03-09 20:35 ` Pali Rohár
2022-12-26 12:36 ` [PATCH RESEND 6/8] leds: turris-omnia: support HW controlled mode via private trigger Pali Rohár
2023-02-24 9:32 ` Lee Jones
2022-12-26 12:36 ` [PATCH RESEND 7/8] leds: turris-omnia: initialize multi-intensity to full Pali Rohár
2023-02-24 9:33 ` Lee Jones
2022-12-26 12:36 ` [PATCH RESEND 8/8] leds: turris-omnia: change max brightness from 255 to 1 Pali Rohár
2023-02-24 9:34 ` Lee Jones
2023-03-09 20:07 ` Pali Rohár
2023-01-20 16:41 ` [PATCH RESEND 0/8] Resend LED patches Arnd Bergmann
2023-01-20 16:41 ` Arnd Bergmann
2023-01-20 17:15 ` Lee Jones
2023-01-20 17:15 ` Lee Jones
2023-01-20 17:47 ` Arnd Bergmann
2023-01-20 17:47 ` Arnd Bergmann
2023-01-20 20:02 ` Lee Jones
2023-01-20 20:02 ` Lee Jones
2023-01-26 20:07 ` Linus Walleij
2023-01-26 20:07 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/iFnUAMl6YS1pSV@google.com \
--to=lee@kernel.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pali@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.