From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16C656105 for ; Fri, 24 Feb 2023 15:25:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6020FC433EF; Fri, 24 Feb 2023 15:25:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1677252313; bh=q8uFT+Zib9fXB7CLOrkzVCuFOpx6Cw/p3OvF/WF7BaQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L5nG+aDW3T9iMesh3e6yXeWiV6pfifQvf88GoylAyIsHui9+N5PffPeKLNPxBw91I P/rdj4Qq0lC71zrgDEyV8qIPBlvjzzlnlVVOPo5jwTupno6ZG3eMX2bkCK9V/RswlN /PJjEacyrfzIqeTSIF+78+7PWBhCJxRc47MrW49Y= Date: Fri, 24 Feb 2023 16:25:11 +0100 From: Greg Kroah-Hartman To: Asahi Lina Cc: Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Will Deacon , Robin Murphy , Joerg Roedel , Hector Martin , Sven Peter , Arnd Bergmann , "Rafael J. Wysocki" , Alyssa Rosenzweig , Neal Gompa , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev Subject: Re: [PATCH 2/5] rust: device: Add a minimal RawDevice trait Message-ID: References: <20230224-rust-iopt-rtkit-v1-0-49ced3391295@asahilina.net> <20230224-rust-iopt-rtkit-v1-2-49ced3391295@asahilina.net> Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Feb 24, 2023 at 11:44:59PM +0900, Asahi Lina wrote: > On 2023/02/24 23:19, Greg Kroah-Hartman wrote:>> Can we see some users > of this code posted so I can see how struct device > >> is going to work in a rust driver? That's the thing I worry most about > >> the rust/C interaction here as we have two different ways of thinking > >> about reference counts from the two worlds and putting them together is > >> going to be "interesting", as can be seen here already. > > > > Also, where are you getting your 'struct device' from in the first > > place? What bus is createing it and giving it to your rust driver? > > That would be platform for my GPU driver, matched via OF compatible. Ick, a platform device? The GPU isn't on the PCI bus? Wow, that's horrid...