All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Colton Lewis <coltonlewis@google.com>
Cc: Oliver Upton <oliver.upton@linux.dev>,
	pbonzini@redhat.com, vipinsh@google.com, dmatlack@google.com,
	andrew.jones@linux.dev, ricarkol@google.com, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: selftests: Provide generic way to read system counter
Date: Fri, 24 Feb 2023 12:13:48 -0800	[thread overview]
Message-ID: <Y/kafBuwgobKqacd@google.com> (raw)
In-Reply-To: <gsnth6va967x.fsf@coltonlewis-kvm.c.googlers.com>

On Fri, Feb 24, 2023, Colton Lewis wrote:
> Oliver Upton <oliver.upton@linux.dev> writes:
> 
> > > These functions were originally part of my patch to introduce latency
> > > measurements into dirty_log_perf_test. [1] Sean Christopherson
> > > suggested lifting these functions into their own patch in generic code
> > > so they can be used by any test. [2] Ricardo Koller suggested the
> > > addition of the MEASURE macro to more easily time individual
> > > statements. [3]
> 
> > > [1] https://lore.kernel.org/kvm/20221115173258.2530923-1-coltonlewis@google.com/
> > > [2] https://lore.kernel.org/kvm/Y8gfOP5CMXK60AtH@google.com/
> > > [3] https://lore.kernel.org/kvm/Y8cIdxp5k8HivVAe@google.com/
> 
> > This patch doesn't make a great deal of sense outside of [1]. Can you
> > send this as part of your larger series next time around?
> 
> I copied the wrong email link where Sean suggested this should be
> generic code in a separate patch. I may have been mistaken in thinking
> he meant to upstream it separately.
> 
> https://lore.kernel.org/kvm/Y8gjG6gG5UR6T3Yg@google.com/
> 
> But yes, I would prefer to keep this as part of the larger series.

Yeah, I just meant put it into a separate patch, but keep it in the series.

      reply	other threads:[~2023-02-24 20:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-21 23:27 [PATCH] KVM: selftests: Provide generic way to read system counter Colton Lewis
2023-02-22  7:50 ` Oliver Upton
2023-02-24 20:08   ` Colton Lewis
2023-02-24 20:13     ` Sean Christopherson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y/kafBuwgobKqacd@google.com \
    --to=seanjc@google.com \
    --cc=andrew.jones@linux.dev \
    --cc=coltonlewis@google.com \
    --cc=dmatlack@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=oliver.upton@linux.dev \
    --cc=pbonzini@redhat.com \
    --cc=ricarkol@google.com \
    --cc=vipinsh@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.