From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Minchan Kim <minchan@kernel.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Jens Axboe <axboe@kernel.dk>,
Andrew Morton <akpm@linux-foundation.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] zram: Use atomic_long_read() to read atomic_long_t
Date: Sun, 26 Feb 2023 12:38:08 +0900 [thread overview]
Message-ID: <Y/rUIF9Tc97GC6Ue@google.com> (raw)
In-Reply-To: <20230225121523.3288544-1-geert+renesas@glider.be>
On (23/02/25 13:15), Geert Uytterhoeven wrote:
> On 32-bit:
>
> drivers/block/zram/zram_drv.c: In function ‘mm_stat_show’:
> drivers/block/zram/zram_drv.c:1234:23: error: passing argument 1 of ‘atomic64_read’ from incompatible pointer type [-Werror=incompatible-pointer-types]
> 1234 | (u64)atomic64_read(&pool_stats.objs_moved));
> | ^~~~~~~~~~~~~~~~~~~~~~
> | |
> | atomic_long_t * {aka struct <anonymous> *}
> In file included from ./include/linux/atomic.h:82,
> from ./include/linux/mm_types_task.h:13,
> from ./include/linux/mm_types.h:5,
> from ./include/linux/buildid.h:5,
> from ./include/linux/module.h:14,
> from drivers/block/zram/zram_drv.c:18:
> ./include/linux/atomic/atomic-instrumented.h:644:33: note: expected ‘const atomic64_t *’ {aka ‘const struct <anonymous> *’} but argument is of type ‘atomic_long_t *’ {aka ‘struct <anonymous> *’}
> 644 | atomic64_read(const atomic64_t *v)
> | ~~~~~~~~~~~~~~~~~~^
>
> Fix this by using atomic_long_read() instead.
Hi Geert,
The patch that cause the warning probably will be droppped from
the series in v3.
next prev parent reply other threads:[~2023-02-26 3:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-25 12:15 [PATCH] zram: Use atomic_long_read() to read atomic_long_t Geert Uytterhoeven
2023-02-26 3:38 ` Sergey Senozhatsky [this message]
2023-02-26 4:30 ` Andrew Morton
2023-02-26 4:57 ` Andrew Morton
2023-02-26 9:45 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/rUIF9Tc97GC6Ue@google.com \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=geert+renesas@glider.be \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.