From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA3C2C05027 for ; Fri, 17 Feb 2023 14:15:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229887AbjBQOPj (ORCPT ); Fri, 17 Feb 2023 09:15:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229496AbjBQOPi (ORCPT ); Fri, 17 Feb 2023 09:15:38 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B3846C00F for ; Fri, 17 Feb 2023 06:15:21 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9854AB82C06 for ; Fri, 17 Feb 2023 14:14:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0963FC4339B; Fri, 17 Feb 2023 14:14:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1676643267; bh=83Da/xcz+aAIbqnU3rPf5qEH62XdhyC4xQohCmPtOHk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fdEgXn6UoJzXDH9rxXMSff6PNaSj+K2IDb1jsY2bIsyznRlNP/OlT3v/mA+4Fv3iF WUR9kfCj0Lm23E/DbwJEy8MyjuduaN61u8OWaCvlroy3EPPN6jD2aBoPSxWI6bAudF 0RR+5ZOSkruBZsIjxQDsJKDb/kDb7LXFC6M3JkN8= Date: Fri, 17 Feb 2023 15:14:24 +0100 From: Greg KH To: Qingfang DENG Cc: stable@vger.kernel.org, Florian Westphal , Shell Chen Subject: Re: [PATCH 5.15,5.10,5.4,4.19] netfilter: nft_tproxy: restrict to prerouting hook Message-ID: References: <20230216124755.51762-1-dqfext@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230216124755.51762-1-dqfext@gmail.com> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Feb 16, 2023 at 08:47:55PM +0800, Qingfang DENG wrote: > From: Florian Westphal > > commit 18bbc3213383a82b05383827f4b1b882e3f0a5a5 upstream. > > TPROXY is only allowed from prerouting, but nft_tproxy doesn't check this. > This fixes a crash (null dereference) when using tproxy from e.g. output. > > Fixes: 4ed8eb6570a4 ("netfilter: nf_tables: Add native tproxy support") > Reported-by: Shell Chen > Signed-off-by: Florian Westphal > Signed-off-by: Qingfang DENG > --- > net/netfilter/nft_tproxy.c | 8 ++++++++ > 1 file changed, 8 insertions(+) Now queued up, thanks. greg k-h