From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B9EEC6379F for ; Fri, 17 Feb 2023 15:15:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229635AbjBQPPH (ORCPT ); Fri, 17 Feb 2023 10:15:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229630AbjBQPPG (ORCPT ); Fri, 17 Feb 2023 10:15:06 -0500 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B51A65698; Fri, 17 Feb 2023 07:15:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676646905; x=1708182905; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=E3qSxYIBCl2wrHaPqs5aU1oaRCoayWAxvUunCUm7Ilc=; b=O84uQf5cmxRKo2DZLVQ00uodqMseDmhdiGSZ5NthNRWdS4jt/s6qnfsI hocT1/twLiNZLAx1uNxx58uFbnTuhq/fEpEiIRfUqHdVMhQqXHbHGaFUU 07qp9FcLj/6sq0evevCeEJfjJEjzTA0JJTpXrejWvrPHO9XBB5/G4uZt4 0a78A/CMO7GsWhzueEv17riXMxvsWK0ht9IodWwYOAgCKtvEUqP5ELuOY mOHpz/XXtH70o7RTcNLCwTwD3onPeCeSv8YNg3NvaZKyIfS5R8EUD6+oz Z8+xvLzs/t/IeoLjOWWRZ1KRJWpnz3pySfxsJoiNBsVylFpDs1+YZxfXw A==; X-IronPort-AV: E=McAfee;i="6500,9779,10624"; a="332009732" X-IronPort-AV: E=Sophos;i="5.97,306,1669104000"; d="scan'208";a="332009732" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2023 07:15:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10624"; a="999475987" X-IronPort-AV: E=Sophos;i="5.97,306,1669104000"; d="scan'208";a="999475987" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga005.fm.intel.com with ESMTP; 17 Feb 2023 07:15:03 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pT2Rx-008GSM-0V; Fri, 17 Feb 2023 17:15:01 +0200 Date: Fri, 17 Feb 2023 17:15:00 +0200 From: Andy Shevchenko To: Biju Das Cc: Greg Kroah-Hartman , Jiri Slaby , "linux-serial@vger.kernel.org" , Geert Uytterhoeven , Niklas =?iso-8859-1?Q?S=F6derlund?= , Fabrizio Castro , "linux-renesas-soc@vger.kernel.org" Subject: Re: [PATCH v4 6/6] serial: 8250_em: Add serial8250_em_{reg_update(),out_helper()} Message-ID: References: <20230217114255.226517-1-biju.das.jz@bp.renesas.com> <20230217114255.226517-7-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Fri, Feb 17, 2023 at 02:35:16PM +0000, Biju Das wrote: > Hi Andy, > > Subject: Re: [PATCH v4 6/6] serial: 8250_em: Add > > serial8250_em_{reg_update(),out_helper()} > > On Fri, Feb 17, 2023 at 11:42:55AM +0000, Biju Das wrote: ... > > > + switch (off) { > > > + case UART_FCR_EM: > > > + fcr = value; > > > + break; > > > + case UART_LCR: > > > + lcr = value; > > > + break; > > > + case UART_MCR: > > > + mcr = value; > > > > Missing break; statement. > > OK, will fix this in next version. > > The original driver has some missing breaks[1]. > So for consistency I dropped this. same for below. I see. Perhaps you can add another patch that adds them there first? > [1] https://elixir.bootlin.com/linux/v6.2-rc8/source/drivers/tty/serial/8250/8250_em.c#L45 > > > + } -- With Best Regards, Andy Shevchenko