From: Tom Rini <trini@konsulko.com>
To: Francesco Dolcini <francesco@dolcini.it>
Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>,
"u-boot@lists.denx.de" <u-boot@lists.denx.de>,
"marex@denx.de" <marex@denx.de>,
Francesco Dolcini <francesco.dolcini@toradex.com>
Subject: Re: [PATCH 10/13] verdin-imx8mm: Remove unused SPL_BOARD_INIT
Date: Fri, 17 Feb 2023 12:03:40 -0500 [thread overview]
Message-ID: <Y++zbFfpfgJMlwb7@bill-the-cat> (raw)
In-Reply-To: <Y++n09GNdPG+FsoY@francesco-nb.int.toradex.com>
[-- Attachment #1: Type: text/plain, Size: 1995 bytes --]
On Fri, Feb 17, 2023 at 05:14:11PM +0100, Francesco Dolcini wrote:
> On Fri, Feb 17, 2023 at 09:03:07AM -0500, Tom Rini wrote:
> > On Fri, Feb 17, 2023 at 01:18:34PM +0000, Marcel Ziswiler wrote:
> > > Hi Tom
> > >
> > > On Thu, 2023-02-16 at 13:37 +0100, Marcel Ziswiler wrote:
> > > > On Wed, 2023-02-15 at 22:36 -0500, Tom Rini wrote:
> > > > > On this platform SPL_BOARD_INIT is used to call arch_misc_init which is
> > > > > in turn empty, drop the call.
> > > > >
> > > > > Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > > > > Signed-off-by: Tom Rini <trini@konsulko.com>
> > > >
> > > > Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > >
> > > Sorry, I have to take my ack back. Marek (and Francesco) are, of course, right and this is indeed needed for
> > > CAAM. Please see also [1] where it got changed/introduced in/to the current form.
> > >
> > > [1] https://lore.kernel.org/all/20220919194118.105820-1-marex@denx.de/
> >
> > Alright, yeah. I've posted v2 which preserves the existing behavior, but
> > it could be improved further still by someone with the hardware to
> > confirm behavior on.
>
> [PATCHv2 12/13] global: Add a select for ARCH_MISC_INIT where used -- ?
>
> I would say that even with that patch in, this specific one should be
> dropped.
Yes, with v2 of 12/13, patches 10 and 11 from v1 of the series are
dropped, to be clear.
> At least this is what I understand from your comment here:
> > Yes, it's still on the board to call arch_misc_init() inside spl_board_init().
>
> We can test your changes on the Verdin iMX8MM, even Marek should have
> one to my understanding, in case we are somehow late.
What I mean is that Marek has suggested a more specific fix to this
problem (it should not be per-board to get the CAAM working for HAB
here, it should be in the SoC code and hooks), and I would quite welcome
the general clean-up but can't test it, so won't write it, right now.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2023-02-17 17:03 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 3:36 [PATCH 01/13] common/Kconfig: Reword text for BOARD_TYPES Tom Rini
2023-02-16 3:36 ` [PATCH 02/13] arm: mvebu: Add select on ARCH_EARLY_INIT_R if ARM64 Tom Rini
2023-02-16 6:31 ` Stefan Roese
2023-03-03 23:40 ` Tom Rini
2023-02-16 3:36 ` [PATCH 03/13] arm: zynq: Move to select'ing ARCH_EARLY_INIT_R if we have FPGA Tom Rini
2023-02-16 9:53 ` Michal Simek
2023-02-16 20:17 ` Simon Glass
2023-03-03 23:40 ` Tom Rini
2023-02-16 3:36 ` [PATCH 04/13] arm: rk3368: Select ARCH_EARLY_INIT_R when used Tom Rini
2023-02-16 20:17 ` Simon Glass
2023-02-17 12:42 ` Quentin Schulz
2023-03-03 23:40 ` Tom Rini
2023-02-16 3:36 ` [PATCH 05/13] common: Make ARCH_EARLY_INIT_R be selected only Tom Rini
2023-02-16 20:17 ` Simon Glass
2023-03-03 23:40 ` Tom Rini
2023-02-16 3:36 ` [PATCH 06/13] imx9: Remove ARCH_MISC_INIT Tom Rini
2023-02-16 20:17 ` Simon Glass
2023-02-20 8:50 ` Peng Fan
2023-03-03 23:41 ` Tom Rini
2023-02-16 3:36 ` [PATCH 07/13] mvebe: Drop ARCH_MISC_INIT from alleycat 5 Tom Rini
2023-02-16 20:17 ` Simon Glass
2023-02-16 20:23 ` Chris Packham
2023-03-03 23:41 ` Tom Rini
2023-02-16 3:36 ` [PATCH 08/13] mvebu: Drop empty arch_misc_init Tom Rini
2023-02-16 6:31 ` Stefan Roese
2023-03-03 23:41 ` Tom Rini
2023-02-16 3:36 ` [PATCH 09/13] s5p: Remove " Tom Rini
2023-02-16 20:17 ` Simon Glass
2023-02-24 9:07 ` Minkyu Kang
2023-03-03 23:41 ` Tom Rini
2023-02-16 3:36 ` [PATCH 10/13] verdin-imx8mm: Remove unused SPL_BOARD_INIT Tom Rini
2023-02-16 12:37 ` Marcel Ziswiler
2023-02-17 13:18 ` Marcel Ziswiler
2023-02-17 14:03 ` Tom Rini
2023-02-17 16:14 ` Francesco Dolcini
2023-02-17 17:03 ` Tom Rini [this message]
2023-02-16 3:36 ` [PATCH 11/13] imx8mm-mx8menlo: Drop SPL_BOARD_INIT Tom Rini
2023-02-16 14:04 ` Marek Vasut
2023-02-16 14:13 ` Tom Rini
2023-02-16 14:21 ` Marek Vasut
2023-02-16 14:41 ` Tom Rini
2023-02-17 2:42 ` Marek Vasut
2023-02-16 3:36 ` [PATCH 12/13] global: Add a select for ARCH_MISC_INIT where used Tom Rini
2023-02-17 12:50 ` [PATCHv2 " Tom Rini
2023-02-17 13:33 ` Marek Vasut
2023-02-17 14:00 ` Tom Rini
2023-02-17 14:40 ` Marek Vasut
2023-02-17 14:42 ` Tom Rini
2023-02-16 3:36 ` [PATCH 13/13] common: Make ARCH_MISC_INIT be selected only Tom Rini
2023-02-17 23:49 ` Simon Glass
2023-02-17 23:49 ` [PATCH 01/13] common/Kconfig: Reword text for BOARD_TYPES Simon Glass
2023-03-03 23:40 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y++zbFfpfgJMlwb7@bill-the-cat \
--to=trini@konsulko.com \
--cc=francesco.dolcini@toradex.com \
--cc=francesco@dolcini.it \
--cc=marcel.ziswiler@toradex.com \
--cc=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.