From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 15 Feb 2023 15:03:14 -0500 From: Stefan Hajnoczi Message-ID: References: <20230215184310.161283-1-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="go+pgMJNfGgD2z5M" Content-Disposition: inline In-Reply-To: <20230215184310.161283-1-dgilbert@redhat.com> Subject: Re: [Virtio-fs] [PATCH v2 0/4] Remove C virtiofsd List-Id: Development discussions about virtio-fs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: qemu-devel@nongnu.org, vgoyal@redhat.com, hczenczek@redhat.com, gmaglione@redhat.com, virtio-fs@redhat.com, pbonzini@redhat.com, alex.bennee@linaro.org --go+pgMJNfGgD2z5M Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 15, 2023 at 06:43:06PM +0000, Dr. David Alan Gilbert (git) wrot= e: > From: "Dr. David Alan Gilbert" >=20 > We deprecated the C virtiofsd in commit 34deee7b6a1418f3d62a > in v7.0 in favour of the Rust implementation at > =20 > https://gitlab.com/virtio-fs/virtiofsd > =20 > since then, the Rust version has had more development and > has held up well. It's time to say goodbye to the C version > that got us going. >=20 > v2: > After comments on the v1 series, I've removed the Avocado > test. >=20 > Dr. David Alan Gilbert (4): > virtiofsd: Remove test > virtiofsd: Remove build and docs glue > virtiofsd: Remove source > virtiofsd: Swing deprecated message to removed-features >=20 > MAINTAINERS | 2 - > docs/about/deprecated.rst | 18 - > docs/about/removed-features.rst | 13 + > docs/conf.py | 4 - > docs/meson.build | 1 - > docs/tools/index.rst | 1 - > docs/tools/virtiofsd.rst | 403 -- > meson.build | 1 - > meson_options.txt | 2 - > .../ci/org.centos/stream/8/x86_64/configure | 2 - > .../org.centos/stream/8/x86_64/test-avocado | 7 - > scripts/coverity-scan/COMPONENTS.md | 3 - > scripts/meson-buildoptions.sh | 3 - > tests/avocado/virtiofs_submounts.py | 217 - > tools/meson.build | 13 - > tools/virtiofsd/50-qemu-virtiofsd.json.in | 5 - > tools/virtiofsd/buffer.c | 350 -- > tools/virtiofsd/fuse_common.h | 837 --- > tools/virtiofsd/fuse_i.h | 107 - > tools/virtiofsd/fuse_log.c | 40 - > tools/virtiofsd/fuse_log.h | 75 - > tools/virtiofsd/fuse_lowlevel.c | 2732 ---------- > tools/virtiofsd/fuse_lowlevel.h | 1988 -------- > tools/virtiofsd/fuse_misc.h | 59 - > tools/virtiofsd/fuse_opt.c | 446 -- > tools/virtiofsd/fuse_opt.h | 272 - > tools/virtiofsd/fuse_signals.c | 93 - > tools/virtiofsd/fuse_virtio.c | 1081 ---- > tools/virtiofsd/fuse_virtio.h | 33 - > tools/virtiofsd/helper.c | 409 -- > tools/virtiofsd/meson.build | 18 - > tools/virtiofsd/passthrough_helpers.h | 51 - > tools/virtiofsd/passthrough_ll.c | 4521 ----------------- > tools/virtiofsd/passthrough_seccomp.c | 182 - > tools/virtiofsd/passthrough_seccomp.h | 14 - > 35 files changed, 13 insertions(+), 13990 deletions(-) > delete mode 100644 docs/tools/virtiofsd.rst > delete mode 100644 tests/avocado/virtiofs_submounts.py > delete mode 100644 tools/virtiofsd/50-qemu-virtiofsd.json.in > delete mode 100644 tools/virtiofsd/buffer.c > delete mode 100644 tools/virtiofsd/fuse_common.h > delete mode 100644 tools/virtiofsd/fuse_i.h > delete mode 100644 tools/virtiofsd/fuse_log.c > delete mode 100644 tools/virtiofsd/fuse_log.h > delete mode 100644 tools/virtiofsd/fuse_lowlevel.c > delete mode 100644 tools/virtiofsd/fuse_lowlevel.h > delete mode 100644 tools/virtiofsd/fuse_misc.h > delete mode 100644 tools/virtiofsd/fuse_opt.c > delete mode 100644 tools/virtiofsd/fuse_opt.h > delete mode 100644 tools/virtiofsd/fuse_signals.c > delete mode 100644 tools/virtiofsd/fuse_virtio.c > delete mode 100644 tools/virtiofsd/fuse_virtio.h > delete mode 100644 tools/virtiofsd/helper.c > delete mode 100644 tools/virtiofsd/meson.build > delete mode 100644 tools/virtiofsd/passthrough_helpers.h > delete mode 100644 tools/virtiofsd/passthrough_ll.c > delete mode 100644 tools/virtiofsd/passthrough_seccomp.c > delete mode 100644 tools/virtiofsd/passthrough_seccomp.h >=20 > --=20 > 2.39.1 >=20 Acked-by: Stefan Hajnoczi --go+pgMJNfGgD2z5M Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmPtOoIACgkQnKSrs4Gr c8jeOQf7Biys2/BZNcoXT80IJu1CtgtYF3z3krJ2VlkoXghwLbTmt70NQmg/QRA1 BJXgbYvBFsLVINRM1FYliMEVU0KxxOrox2VV4pZnJhQr9N87dmYKiBDkxRLNNeGK CtqJQu+XBRKsOh8NXYNzUDekqXDOhG9v85VZ3AwIUX4lIYS6Mv8C0iO+8tDamXBB o/UfB4VJljvHD5hKDnAZs+PgcRZJJnnoofkQSaLPt/FSY19ZXzMIg406WTHO18bd o+eUIo2B0ck0YCGGZmxCRS0VpqynetmKKYGhRFUiAgdvYyiJ9QaftmNCnsJVwFp+ 0r0DAJuuq9Zly6CL2Ti1QCM9W5z0kA== =DW2p -----END PGP SIGNATURE----- --go+pgMJNfGgD2z5M-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87167C636D4 for ; Wed, 15 Feb 2023 20:04:12 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSNzz-0000Im-6W; Wed, 15 Feb 2023 15:03:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSNzw-0000IV-P7 for qemu-devel@nongnu.org; Wed, 15 Feb 2023 15:03:24 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSNzu-00060R-Mw for qemu-devel@nongnu.org; Wed, 15 Feb 2023 15:03:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676491401; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vBWfOIjgACMr6Uscz53keI/jN4h3C8Zc2tmiHKxtUo4=; b=QuC6Y0QjXNFgxieU15YVcnEhrVE5fKY+nS62ryPNYvy/oL3NwIQN7L/pxV1JBkrZ+9ZvDe Uwv3pyAMazscGc3LPiolKgwYQ/iGJIBsxbY86cx6l5IsBpRQWXVfi2j98bhNZHzakKqzcL K09+syCvDZc+mbElo2RKZs8j8qFAyLA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-347-CT8dHO5fMXKBTkWc_AksVA-1; Wed, 15 Feb 2023 15:03:19 -0500 X-MC-Unique: CT8dHO5fMXKBTkWc_AksVA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5107A80D0E9; Wed, 15 Feb 2023 20:03:17 +0000 (UTC) Received: from localhost (unknown [10.39.192.35]) by smtp.corp.redhat.com (Postfix) with ESMTP id C1DC9492B15; Wed, 15 Feb 2023 20:03:16 +0000 (UTC) Date: Wed, 15 Feb 2023 15:03:14 -0500 From: Stefan Hajnoczi To: "Dr. David Alan Gilbert (git)" Cc: qemu-devel@nongnu.org, vgoyal@redhat.com, hczenczek@redhat.com, gmaglione@redhat.com, virtio-fs@redhat.com, pbonzini@redhat.com, alex.bennee@linaro.org Subject: Re: [PATCH v2 0/4] Remove C virtiofsd Message-ID: References: <20230215184310.161283-1-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="go+pgMJNfGgD2z5M" Content-Disposition: inline In-Reply-To: <20230215184310.161283-1-dgilbert@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 Received-SPF: pass client-ip=170.10.129.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org --go+pgMJNfGgD2z5M Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 15, 2023 at 06:43:06PM +0000, Dr. David Alan Gilbert (git) wrot= e: > From: "Dr. David Alan Gilbert" >=20 > We deprecated the C virtiofsd in commit 34deee7b6a1418f3d62a > in v7.0 in favour of the Rust implementation at > =20 > https://gitlab.com/virtio-fs/virtiofsd > =20 > since then, the Rust version has had more development and > has held up well. It's time to say goodbye to the C version > that got us going. >=20 > v2: > After comments on the v1 series, I've removed the Avocado > test. >=20 > Dr. David Alan Gilbert (4): > virtiofsd: Remove test > virtiofsd: Remove build and docs glue > virtiofsd: Remove source > virtiofsd: Swing deprecated message to removed-features >=20 > MAINTAINERS | 2 - > docs/about/deprecated.rst | 18 - > docs/about/removed-features.rst | 13 + > docs/conf.py | 4 - > docs/meson.build | 1 - > docs/tools/index.rst | 1 - > docs/tools/virtiofsd.rst | 403 -- > meson.build | 1 - > meson_options.txt | 2 - > .../ci/org.centos/stream/8/x86_64/configure | 2 - > .../org.centos/stream/8/x86_64/test-avocado | 7 - > scripts/coverity-scan/COMPONENTS.md | 3 - > scripts/meson-buildoptions.sh | 3 - > tests/avocado/virtiofs_submounts.py | 217 - > tools/meson.build | 13 - > tools/virtiofsd/50-qemu-virtiofsd.json.in | 5 - > tools/virtiofsd/buffer.c | 350 -- > tools/virtiofsd/fuse_common.h | 837 --- > tools/virtiofsd/fuse_i.h | 107 - > tools/virtiofsd/fuse_log.c | 40 - > tools/virtiofsd/fuse_log.h | 75 - > tools/virtiofsd/fuse_lowlevel.c | 2732 ---------- > tools/virtiofsd/fuse_lowlevel.h | 1988 -------- > tools/virtiofsd/fuse_misc.h | 59 - > tools/virtiofsd/fuse_opt.c | 446 -- > tools/virtiofsd/fuse_opt.h | 272 - > tools/virtiofsd/fuse_signals.c | 93 - > tools/virtiofsd/fuse_virtio.c | 1081 ---- > tools/virtiofsd/fuse_virtio.h | 33 - > tools/virtiofsd/helper.c | 409 -- > tools/virtiofsd/meson.build | 18 - > tools/virtiofsd/passthrough_helpers.h | 51 - > tools/virtiofsd/passthrough_ll.c | 4521 ----------------- > tools/virtiofsd/passthrough_seccomp.c | 182 - > tools/virtiofsd/passthrough_seccomp.h | 14 - > 35 files changed, 13 insertions(+), 13990 deletions(-) > delete mode 100644 docs/tools/virtiofsd.rst > delete mode 100644 tests/avocado/virtiofs_submounts.py > delete mode 100644 tools/virtiofsd/50-qemu-virtiofsd.json.in > delete mode 100644 tools/virtiofsd/buffer.c > delete mode 100644 tools/virtiofsd/fuse_common.h > delete mode 100644 tools/virtiofsd/fuse_i.h > delete mode 100644 tools/virtiofsd/fuse_log.c > delete mode 100644 tools/virtiofsd/fuse_log.h > delete mode 100644 tools/virtiofsd/fuse_lowlevel.c > delete mode 100644 tools/virtiofsd/fuse_lowlevel.h > delete mode 100644 tools/virtiofsd/fuse_misc.h > delete mode 100644 tools/virtiofsd/fuse_opt.c > delete mode 100644 tools/virtiofsd/fuse_opt.h > delete mode 100644 tools/virtiofsd/fuse_signals.c > delete mode 100644 tools/virtiofsd/fuse_virtio.c > delete mode 100644 tools/virtiofsd/fuse_virtio.h > delete mode 100644 tools/virtiofsd/helper.c > delete mode 100644 tools/virtiofsd/meson.build > delete mode 100644 tools/virtiofsd/passthrough_helpers.h > delete mode 100644 tools/virtiofsd/passthrough_ll.c > delete mode 100644 tools/virtiofsd/passthrough_seccomp.c > delete mode 100644 tools/virtiofsd/passthrough_seccomp.h >=20 > --=20 > 2.39.1 >=20 Acked-by: Stefan Hajnoczi --go+pgMJNfGgD2z5M Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmPtOoIACgkQnKSrs4Gr c8jeOQf7Biys2/BZNcoXT80IJu1CtgtYF3z3krJ2VlkoXghwLbTmt70NQmg/QRA1 BJXgbYvBFsLVINRM1FYliMEVU0KxxOrox2VV4pZnJhQr9N87dmYKiBDkxRLNNeGK CtqJQu+XBRKsOh8NXYNzUDekqXDOhG9v85VZ3AwIUX4lIYS6Mv8C0iO+8tDamXBB o/UfB4VJljvHD5hKDnAZs+PgcRZJJnnoofkQSaLPt/FSY19ZXzMIg406WTHO18bd o+eUIo2B0ck0YCGGZmxCRS0VpqynetmKKYGhRFUiAgdvYyiJ9QaftmNCnsJVwFp+ 0r0DAJuuq9Zly6CL2Ti1QCM9W5z0kA== =DW2p -----END PGP SIGNATURE----- --go+pgMJNfGgD2z5M--