From: Chris Down <chris@chrisdown.name>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
mcgrof@kernel.org, ndesaulniers@google.com, trix@redhat.com,
linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org, llvm@lists.linux.dev,
Abaci Robot <abaci@linux.alibaba.com>, Song Liu <song@kernel.org>
Subject: Re: [PATCH] module: Remove the unused function within
Date: Wed, 15 Feb 2023 17:23:14 +0000 [thread overview]
Message-ID: <Y+0VAr21hlIdrxyp@chrisdown.name> (raw)
In-Reply-To: <Y+0PzlA0LijhfD8R@dev-arch.thelio-3990X>
+Cc: Song
Nathan Chancellor writes:
>On Wed, Feb 15, 2023 at 04:47:44PM +0000, Chris Down wrote:
>> Jiapeng Chong writes:
>> > The function within is defined in the main.c file, but not called
>> > elsewhere, so remove this unused function.
>>
>> Huh? It's used by __module_text_address(), no?
>
>Not after commit 2ece476a2346 ("module: replace module_layout with
>module_memory") in -next. This patch should have a fixes tag, even if
>the warning is currently hidden behind W=1.
Huh, I thought I had checked out latest -next, but must have not done so
somehow :-) Mea culpa.
If it's only in -next then no Fixes needed, since there's no stable rev yet.
Jiapeng, in future, please make sure to cc the author of related commits when
reporting stuff like this :-) It helps people to update their patches.
Song, you probably want to update your patch.
next prev parent reply other threads:[~2023-02-15 17:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 6:42 [PATCH] module: Remove the unused function within Jiapeng Chong
2023-02-15 16:47 ` Chris Down
2023-02-15 17:01 ` Nathan Chancellor
2023-02-15 17:23 ` Chris Down [this message]
2023-02-15 18:57 ` Song Liu
2023-02-21 21:21 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+0VAr21hlIdrxyp@chrisdown.name \
--to=chris@chrisdown.name \
--cc=abaci@linux.alibaba.com \
--cc=bpf@vger.kernel.org \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mcgrof@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=song@kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.