From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:906:da85:b0:8b1:202f:4753 with SMTP id xh5csp513094ejb; Thu, 16 Feb 2023 05:54:09 -0800 (PST) X-Google-Smtp-Source: AK7set/kkzEEV9CMhaHgAx/8aElPuGWjTvKoFS7gSv5lzfuU/oMaKXydnM+IW/m1ZYugIAC/uXSz X-Received: by 2002:a05:622a:174d:b0:3ab:a047:58ee with SMTP id l13-20020a05622a174d00b003aba04758eemr10370698qtk.25.1676555649413; Thu, 16 Feb 2023 05:54:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676555649; cv=none; d=google.com; s=arc-20160816; b=wG1TzUMVxukr+QdMS9NX0LKFpTzdPXz6JD9r0MbN6HPuIww6dPdplP38uNmE4gZc8U X1l8MdKZNQ6XmpX/1HiYa/qzFZRe0jRzlO5M/kXphMVzFhgwuNy+B8IipB1mnIj3EkPW wFcYZd7WP47d1u9lp0j6otSApqW3aSKurZJ7uY7rivx+AIPH/XuqKbz9WO1IVL9t2KRd IZcswXcwy3DpNjKh5tk0S24aDEqJn8DzePkHQbWOBmkp9eJJmtsmbLMbhsyg1xlFhXC1 9tx4NOW2d1LIdovRm0XwQZIQKyuyzAlZtkb1DfLXo2Efr9NTyoekliSxJ29EIVhvKDO3 3PTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=TQ442iw9QPbRaJ8g3n9S9lRb53UDu2jxW7R63YiAGYk=; b=med3dkL3r+MNWuBQvvBvekD3gq7dQ4KXFBXorwGBYWuEToXnoCpsGOVtJTUrqLG+Qg XCtIz4MuvvSfi7snbpic2Vnuk5rwrWo9I84o+IYmVViAY+Iuw1rjhf8eYiccm5RtJAOD Qw62Zn2YrBnEyoQNAOPoMunuZQjkAIkU/CZG/vJYvoolA3H90LZBQPNxwpGwDavL0Ymd 7H1UKjB1bGIAXu5i3cO6fH0BeDTN0VMACtyutL/JkIheGoKa6IatrM7ZeDY+iZTe4bDu CyhYdwfpl/2vXq1k6A/Kv7zsVqDmRgdFjSbPT3BMj5SLbmvMRvNQZNGx8aT7c3ssmfr4 rW6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b="WrUD/Qdp"; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id l25-20020ac84cd9000000b003b9bd677231si1414054qtv.208.2023.02.16.05.54.09 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 16 Feb 2023 05:54:09 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b="WrUD/Qdp"; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSei4-0001Fh-4x; Thu, 16 Feb 2023 08:54:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSei3-0001FQ-BZ for qemu-devel@nongnu.org; Thu, 16 Feb 2023 08:54:03 -0500 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pSei1-0006ko-SX for qemu-devel@nongnu.org; Thu, 16 Feb 2023 08:54:03 -0500 Received: by mail-wm1-x333.google.com with SMTP id p5so1613952wmg.4 for ; Thu, 16 Feb 2023 05:54:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=TQ442iw9QPbRaJ8g3n9S9lRb53UDu2jxW7R63YiAGYk=; b=WrUD/Qdp1S/ZipXGy6+4d9Jk1D4twlJdj8Gzn5s3mY8rKL3POqS7VDNCHxQ0hKOky4 FcCq9I9dnn/cHaLXaJIQDao7yBaSpi+J8YlwLuh8gcwcAAIcZNMFJFLo/DLCneQ+pRHr kxktPprbENeGpZGjFxxKG130hlTw/CGKmUmExufhiAzQ7ah5RQ2dzCZnP3xjwxilD24b xvC6+JvH0/GKSuXm+7p7ekvMW5wfvnnlnMPEgMjk2eZ1vL6TM7hANj5Axuly1KfGmb7+ UuTkj6X8tw90bm9vuA++Erehv4yDdqKRnddbGR8GTTwDGcUoX20JL4CWU9AOqtDUN0r8 w5kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TQ442iw9QPbRaJ8g3n9S9lRb53UDu2jxW7R63YiAGYk=; b=18dH8nrf27nozffIZpRydBTii8Sk+nFA3W6hSXqxPcyNPDRQi+lrP1PiGAAYwNwKE6 1sQ3wM3HSSJC5SfVc0WXmHGrQhDNCeIi57ZKP5tLs+CD1o4FxFI0uMEZ4l3EXIGdvg8p L3T027PlAc5kpiAV4VpLC5DLZIVhbE/T7swW81lWTlpOqKuB8r5hy2JQ+ehDDzNUvhlB 9UeY8yDAhSSFtQhZPot9jCVWZ8HD0KfZpbEAu3QCXpCjHJDrfKJA0x6Q/noVscR/utPX z265Se4His6KJwfM0pgKEdcmr9OtCBeUhBGTW+yl8jyv3pAhqQ4hIj+JpC+JUWU2KTGZ uXWA== X-Gm-Message-State: AO0yUKW2uRHqPRDH4Bkk7NzKOso4CdziR9OEWkMHqW/24ahKbR6X64sU 4Ujvnni8tCKFBFEvEoxUrVcHWQ== X-Received: by 2002:a05:600c:1d25:b0:3dd:c896:d2b1 with SMTP id l37-20020a05600c1d2500b003ddc896d2b1mr230677wms.0.1676555640342; Thu, 16 Feb 2023 05:54:00 -0800 (PST) Received: from google.com (44.232.78.34.bc.googleusercontent.com. [34.78.232.44]) by smtp.gmail.com with ESMTPSA id d8-20020adfe2c8000000b002c3ea5ebc73sm1559925wrj.101.2023.02.16.05.53.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 05:53:59 -0800 (PST) Date: Thu, 16 Feb 2023 13:53:55 +0000 From: Mostafa Saleh To: Eric Auger Cc: qemu-devel@nongnu.org, jean-philippe@linaro.org, peter.maydell@linaro.org, qemu-arm@nongnu.org Subject: Re: [RFC PATCH 12/16] hw/arm/smmuv3: Add VMID to tlb tagging Message-ID: References: <20230205094411.793816-1-smostafa@google.com> <20230205094411.793816-13-smostafa@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=smostafa@google.com; helo=mail-wm1-x333.google.com X-Spam_score_int: -175 X-Spam_score: -17.6 X-Spam_bar: ----------------- X-Spam_report: (-17.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: oOqZNel9WMAN Hi Eric, On Thu, Feb 16, 2023 at 11:17:34AM +0100, Eric Auger wrote: > > } > > > > - *key = smmu_get_iotlb_key(cfg->asid, new->entry.iova, tg, new->level); > > + *key = smmu_get_iotlb_key(cfg->asid, cfg->s2cfg.vmid, new->entry.iova, > > + tg, new->level); > > trace_smmu_iotlb_insert(cfg->asid, new->entry.iova, tg, new->level); > you may update the trace point as well I can add a stage argument here, however I don’t think it is necessary now as TLBs are either used for stage-1 or stage-2, not both. Thanks, Mostafa