From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9340CC61DA4 for ; Thu, 16 Feb 2023 14:41:53 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 58BED85AFB; Thu, 16 Feb 2023 15:41:50 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="QKJPCjD0"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D09D785AFB; Thu, 16 Feb 2023 15:41:47 +0100 (CET) Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4C74A85A6A for ; Thu, 16 Feb 2023 15:41:44 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x830.google.com with SMTP id h24so2369561qtr.0 for ; Thu, 16 Feb 2023 06:41:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Lijwx5EwfanfmCoS6+qX25WHv67vy6c1yxG5QllD9d4=; b=QKJPCjD06GVWkmygwZ5VS9FUulOca8E/sD/kJgQ4l5RQVBO/MKdUq/e//N7lrN9Jp4 PSSBcWO1ojP08J2hZFlw6A6sSsti65Hb6uggrZrnLGNeB9f000mPsQI0UKSQUinGk0/J bG2h/62HLwys05zkrbCUdeCNEKKSlLlCPMhqc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Lijwx5EwfanfmCoS6+qX25WHv67vy6c1yxG5QllD9d4=; b=VobOmr0Au++ZPlqa299sUDdw0N2A5VVUNLn/VOW2vraqxZ1qD2zFv21AnKg0a5yOWQ HBAvGHXzpyfnZJ49OILYSHUBatEKhkxtN/m1zD2g9G+fAS9no8iCYJz2ZaQ0gUpQLkCm LxoxU84NGgey8wN74rR2Rn+AKOGbBj3VhIltbi2C56bf5yJ6VYl4uKh4J+SQFtEYzDYc f3OEq/Y47md1CeZh809xU2OTcMyGRJZN1WsKg+Xz8Jk2FIwC3yxE8FKtM9pieZxYR97K Pez/oR5qM4F1UL4TBdeIKHlRkMDDpxgGkJjCK7MT8l/twYvg+ME8qjaIns3w0Rqr1Rra C/PA== X-Gm-Message-State: AO0yUKWhnQ/20+TBmhSDa/US8MulBPwzX23nBqQoaAgkzqro3RLIThZY iYeHHZGF9tSCK3cpaFQi9O2OmBAxd8SQYY4Fse0= X-Google-Smtp-Source: AK7set+nSHCDZzzRSuOj5mQoR8sEC3U48YsA4r/1B/2OBvP9/fnh5uUS2/XK1wbHdSiMLVY5mWJu+g== X-Received: by 2002:a05:622a:1747:b0:3b9:b9b4:cb8d with SMTP id l7-20020a05622a174700b003b9b9b4cb8dmr10704881qtk.11.1676558503065; Thu, 16 Feb 2023 06:41:43 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-2265-3a10-92ec-4b22.res6.spectrum.com. [2603:6081:7b00:6400:2265:3a10:92ec:4b22]) by smtp.gmail.com with ESMTPSA id z11-20020ac8430b000000b003b9a50c8fa1sm1311932qtm.87.2023.02.16.06.41.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 06:41:42 -0800 (PST) Date: Thu, 16 Feb 2023 09:41:40 -0500 From: Tom Rini To: Marek Vasut Cc: u-boot@lists.denx.de, Olaf Mandel Subject: Re: [PATCH 11/13] imx8mm-mx8menlo: Drop SPL_BOARD_INIT Message-ID: References: <20230216033659.3877684-1-trini@konsulko.com> <20230216033659.3877684-11-trini@konsulko.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="AqAsdByTtLVR16d6" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --AqAsdByTtLVR16d6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 16, 2023 at 03:21:43PM +0100, Marek Vasut wrote: > On 2/16/23 15:13, Tom Rini wrote: > > On Thu, Feb 16, 2023 at 03:04:35PM +0100, Marek Vasut wrote: > > > On 2/16/23 04:36, Tom Rini wrote: > > > > On this platform spl_board_init is a call to arch_misc_init which i= s a > > > > no-op, so drop the CONFIG options. > > > >=20 > > > > Cc: Marek Vasut > > > > Cc: Olaf Mandel > > >=20 > > > btw. put those under --- next time, that way they don't end up in com= mit > > > message. > >=20 > > Er, did the kernel change expected behavior here? >=20 > Er ... wasn't that the case for like a year now ? Is that a yes then? > > > > Signed-off-by: Tom Rini > > >=20 > > > If CAAM is enabled, ARCH_MISC_INIT brings up the CAAM , and this is n= eeded > > > in SPL for U-Boot authentication using HABv4 . I believe that is why = Verdin > > > spl.c calls it. > >=20 > > Then I'll put doing a follow-up on SPL_BOARD_INIT (which is another > > option that shouldn't be directly asked, but select'd when used) for > > that case. It fails to build in this series because CAAM isn't enabled > > so there's no arch_misc_init. >=20 > Just call the arch_board_init unconditionally, the CAAM inside of it is > already conditional, so the compiler should inline the result if CAAM is > disabled. It doesn't, and only maybe does with LTO. But we also shouldn't be enabling unused hooks. It sounds like imx8m should follow the other platforms that have an spl_board_init under arch/ ? --=20 Tom --AqAsdByTtLVR16d6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPuQKEACgkQFHw5/5Y0 tywLggv+PkiV5IKXFDqc+kW3osjlVk3q19A6Zvuta1+jjiWw/OwSV5t3E5uPFkvF y/LzI+8ToUqdZmswFR6hshsXgXX/jqD8cTiIjrQFPdWBME1Kn2gmi+wh+sxYFaF/ Z+Gl053vvgy9Gdyws0gKgxnd8Ixu6iQJdG2bVVP5+TN+B8tjTibWL9G5R+g+mdL6 qWbkmQTfiI1jJ43yOM9r6g6+xKqZtmyQjD6dfAsDoT6lx5Cyf6rU70QZyzLAkxzF eK8PCs+Q61Dm5jD/fQ5pB++xCaNuD6Y+h/Qo6ZNH6ikVHBn7XUINb91I1yvQeQWN mVYWKGZQBMGUg7WvBBufbBYOSeLKxx+fPWDCpSOI7Qooe18m0YRlhU2OaH46jrNV GSPabCuAiyZexzx666S9yJlhoFOd5yspNuar1Ese4l4iilZ2Bb1/ITc4T9gDjIW9 ARaUVcjEnEACYaEg5IOz0pOQoa4dFkjDVm90s6uVJAnzmjLcMXqeF+mqXEmlAwiR NMDEwv9a =Zlxb -----END PGP SIGNATURE----- --AqAsdByTtLVR16d6--