From: Sean Christopherson <seanjc@google.com>
To: David Matlack <dmatlack@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] KVM: x86/mmu: Make @tdp_mmu_allowed static
Date: Thu, 16 Feb 2023 07:35:12 -0800 [thread overview]
Message-ID: <Y+5MH5NPOWCV7+vQ@google.com> (raw)
In-Reply-To: <CALzav=c06gXZme+t5tE3eFgbeKNO+hjFox=sRyU8oiC3VMB3zw@mail.gmail.com>
On Wed, Feb 15, 2023, David Matlack wrote:
> On Wed, Feb 15, 2023 at 4:44 PM Sean Christopherson <seanjc@google.com> wrote:
> >
> > On Mon, Feb 13, 2023, David Matlack wrote:
> > > Make @tdp_mmu_allowed static since it is only ever used within
> >
> > Doesn't "@" usually refer to function parameters?
>
> Oh is that the convention? For some reason I assumed it was used when
> referring to any variable.
Yes? My experience with it is entirely in the context of kernel-doc syntax, where
it's used to document function params and struct field. Global symbols don't
need additional reference because they are the focus of the comment/documentation.
next prev parent reply other threads:[~2023-02-16 15:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 21:28 [PATCH] KVM: x86/mmu: Make @tdp_mmu_allowed static David Matlack
2023-02-16 0:44 ` Sean Christopherson
2023-02-16 1:06 ` David Matlack
2023-02-16 15:35 ` Sean Christopherson [this message]
2023-02-16 17:29 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+5MH5NPOWCV7+vQ@google.com \
--to=seanjc@google.com \
--cc=dmatlack@google.com \
--cc=kvm@vger.kernel.org \
--cc=lkp@intel.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.