From: Andrew Lunn <andrew@lunn.ch>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Cc: Lee Jones <lee@kernel.org>,
linux-kernel@vger.kernel.org, linux@ew.tq-group.com
Subject: Re: [PATCH 2/3] mfd: tqmx86: specify IO port register range more precisely
Date: Thu, 16 Feb 2023 18:20:47 +0100 [thread overview]
Message-ID: <Y+5l76f0z/NnPXxK@lunn.ch> (raw)
In-Reply-To: <ac7875ea1e3a650b223622457faab79fed5addbe.1676557968.git.matthias.schiffer@ew.tq-group.com>
On Thu, Feb 16, 2023 at 03:34:23PM +0100, Matthias Schiffer wrote:
> Registers 0x160..0x17f are unassigned. Use 0x180 as base register and
> update offets accordingly.
>
> Also change the size of the range to include 0x19f. While 0x19f is
> currently reserved for future extensions, so are several of the previous
> registers up to 0x19e, and it is weird to leave out just the last one.
>
> Fixes: 2f17dd34ffed ("mfd: tqmx86: IO controller with I2C, Wachdog and GPIO")
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2023-02-16 17:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 14:34 [PATCH 1/3] mfd: tqmx86: do not access I2C_DETECT register through io_base Matthias Schiffer
2023-02-16 14:34 ` [PATCH 2/3] mfd: tqmx86: specify IO port register range more precisely Matthias Schiffer
2023-02-16 17:20 ` Andrew Lunn [this message]
2023-02-16 14:34 ` [PATCH 3/3] mfd: tqmx86: correct board names for TQMxE39x Matthias Schiffer
2023-02-16 17:11 ` Andrew Lunn
2023-02-16 17:19 ` [PATCH 1/3] mfd: tqmx86: do not access I2C_DETECT register through io_base Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+5l76f0z/NnPXxK@lunn.ch \
--to=andrew@lunn.ch \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@ew.tq-group.com \
--cc=matthias.schiffer@ew.tq-group.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.