All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Xinghui Li <korantwork@gmail.com>
Cc: peterz@infradead.org, jpoimboe@redhat.com, tglx@linutronix.de,
	stable@vger.kernel.org, linux-kernel@vger.kernel.org,
	x86@kernel.org, alexs@kernel.org
Subject: Re: [bug report]warning about entry_64.S from objtool in v5.4 LTS
Date: Mon, 6 Feb 2023 06:40:17 +0100	[thread overview]
Message-ID: <Y+CSwTDESQjTzS8S@kroah.com> (raw)
In-Reply-To: <CAEm4hYXr28O8TOmZWEKfp-00Y9R7Ky7C6X3JTtfm-0AD42KbrA@mail.gmail.com>

On Mon, Feb 06, 2023 at 11:09:48AM +0800, Xinghui Li wrote:
> Hi all
> We found a warning from objtool:
> arch/x86/entry/entry_64.o: warning: objtool: .entry.text+0x1d1:
> unsupported intra-function call
> 
> and if we enable retpoline in config:
> arch/x86/entry/entry_64.o: warning: objtool: .entry.text+0x1c1:
> unsupported intra-function call
> arch/x86/entry/entry_64.o: warning: objtool: If this is a retpoline,
> please patch it in with alternatives and annotate it with
> ANNOTATE_NOSPEC_ALTERNATIVE.
> 
> I found this issue has been introduced since “x86/speculation: Change
> FILL_RETURN_BUFFER to work with objtool( commit 8afd1c7da2)”backported
> in v5.4.217.
> Comparing with the upstream version(commit 089dd8e53):
> There is no “ANNOTATE_INTRA_FUNCTION_CALL” in v5.4 for missing
> dependency patch. When the “ANNOTATE_NOSPEC_ALTERNATIVE” is removed,
> this issue just occurs.
> 
> I tried to backport “ANNOTATE_INTRA_FUNCTION_CALL”and its dependency
> patchs in v5.4, but I met the CFA miss match issue from objtool.
> So, please help check this issue in v5.4 LTS version.

If you rely on the 5.4.y kernel tree, and you need this speculation
fixes and feel this is a real problem, please provide some backported
patches to resolve the problem.

It's been reported many times in the past, but no one seems to actually
want to fix this bad enough to send in a patch :(

Usually people just move to a newer kernel, what is preventing you from
doing that right now?

thanks,

greg k-h

  reply	other threads:[~2023-02-06  5:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-06  3:09 [bug report]warning about entry_64.S from objtool in v5.4 LTS Xinghui Li
2023-02-06  5:40 ` Greg KH [this message]
2023-02-06  9:22   ` Xinghui Li
2023-02-06  9:39     ` Greg KH
2023-02-07  0:18       ` Kuniyuki Iwashima
2023-02-07  6:43       ` Xinghui Li
2023-02-07  6:52         ` Greg KH
2023-02-07  7:19           ` Xinghui Li
2023-02-07  7:30             ` Greg KH
2023-02-13 12:20               ` Xinghui Li
2023-02-13 12:31                 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y+CSwTDESQjTzS8S@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alexs@kernel.org \
    --cc=jpoimboe@redhat.com \
    --cc=korantwork@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=stable@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.