From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C17CAC05027 for ; Mon, 6 Feb 2023 09:57:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229863AbjBFJ5y (ORCPT ); Mon, 6 Feb 2023 04:57:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230020AbjBFJ5v (ORCPT ); Mon, 6 Feb 2023 04:57:51 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA3E9E048; Mon, 6 Feb 2023 01:57:47 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 92A7DB80E37; Mon, 6 Feb 2023 09:57:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 848D7C433EF; Mon, 6 Feb 2023 09:57:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1675677465; bh=yqpJFL7AqTytJlea5SSDhYKVEGfY5DgY2bMudgpP8Ys=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P6GwhHp12sZwtSR+/q0P+9Mb/EE88FirlweA+qfOlD5XlnkfHB6f6HurgsgVEzGxP mlKzvFu0bi3uVPjSzMGO+PTE7Lnn2wXWKzFtyOeBYu0yDev7RgKzkFMsuQ0M29yHGT wY9dhibI9gln78M2Et+AAk8kdZE5S/u2srMdY2w0= Date: Mon, 6 Feb 2023 10:57:42 +0100 From: Greg Kroah-Hartman To: Krzysztof Kozlowski Cc: linux-usb@vger.kernel.org, Alim Akhtar , Linus Walleij , Jakob Koschel , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann Subject: Re: [PATCH 13/13] USB: gadget: s3c2410_udc: fix memory leak with using debugfs_lookup() Message-ID: References: <20230202153235.2412790-1-gregkh@linuxfoundation.org> <20230202153235.2412790-13-gregkh@linuxfoundation.org> <241f919c-8190-00d6-f89b-6f7f54b29df9@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <241f919c-8190-00d6-f89b-6f7f54b29df9@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Fri, Feb 03, 2023 at 09:20:10AM +0100, Krzysztof Kozlowski wrote: > On 02/02/2023 16:32, Greg Kroah-Hartman wrote: > > When calling debugfs_lookup() the result must have dput() called on it, > > otherwise the memory will leak over time. To make things simpler, just > > call debugfs_lookup_and_remove() instead which handles all of the logic > > at once. > > > > Hi Greg, > > This driver will be removed in v6.3 via Arnd's tree: > https://lore.kernel.org/all/20221021203329.4143397-13-arnd@kernel.org/ > > I think we can skip any work on this. Ok, thanks, I'll drop it from my patch queue for now. If it sticks around, I'll apply it :) greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE790C61DA4 for ; Mon, 6 Feb 2023 09:58:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jKXE4gu1JFVtLLDdNnpjK3crNX1z30mjF53q4CD8edM=; b=XWlpAwjj6/5x+w 2loBQkJa0Wsnt4KHfKkP19WXfiS2qFHTGW3Zqgr5LtU85Us+GL96u5Dek1uB/W3IRrsk9/62u9AhP uyjcrXl7rieEm5C9zgRxnVBfkhwX0/rRZMT9jx9lJsEgTRNb9+Q9OM1WL89rWbloYi1sejFP/vVbr 8cp5K+Gf6KuAH8YNf4sKgbPwbflfSJz3/Fmvwr4hDKiXnN7YFVAWG3mnqE6Itxf3SWq0bbVF3OXJl oprCupITnPGb8mY+92AZgmtWoyBTHfSToFouXrUpaJBybBRNNqpebJw8wbZWX8iOrgDsjXKJEqQCe isgN8d7QFwg719nDVnxA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pOyG0-007yDf-7t; Mon, 06 Feb 2023 09:57:52 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pOyFw-007yBF-O7 for linux-arm-kernel@lists.infradead.org; Mon, 06 Feb 2023 09:57:50 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C7FA060DDE; Mon, 6 Feb 2023 09:57:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 848D7C433EF; Mon, 6 Feb 2023 09:57:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1675677465; bh=yqpJFL7AqTytJlea5SSDhYKVEGfY5DgY2bMudgpP8Ys=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P6GwhHp12sZwtSR+/q0P+9Mb/EE88FirlweA+qfOlD5XlnkfHB6f6HurgsgVEzGxP mlKzvFu0bi3uVPjSzMGO+PTE7Lnn2wXWKzFtyOeBYu0yDev7RgKzkFMsuQ0M29yHGT wY9dhibI9gln78M2Et+AAk8kdZE5S/u2srMdY2w0= Date: Mon, 6 Feb 2023 10:57:42 +0100 From: Greg Kroah-Hartman To: Krzysztof Kozlowski Cc: linux-usb@vger.kernel.org, Alim Akhtar , Linus Walleij , Jakob Koschel , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann Subject: Re: [PATCH 13/13] USB: gadget: s3c2410_udc: fix memory leak with using debugfs_lookup() Message-ID: References: <20230202153235.2412790-1-gregkh@linuxfoundation.org> <20230202153235.2412790-13-gregkh@linuxfoundation.org> <241f919c-8190-00d6-f89b-6f7f54b29df9@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <241f919c-8190-00d6-f89b-6f7f54b29df9@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230206_015748_840715_26E9E175 X-CRM114-Status: GOOD ( 13.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 03, 2023 at 09:20:10AM +0100, Krzysztof Kozlowski wrote: > On 02/02/2023 16:32, Greg Kroah-Hartman wrote: > > When calling debugfs_lookup() the result must have dput() called on it, > > otherwise the memory will leak over time. To make things simpler, just > > call debugfs_lookup_and_remove() instead which handles all of the logic > > at once. > > > > Hi Greg, > > This driver will be removed in v6.3 via Arnd's tree: > https://lore.kernel.org/all/20221021203329.4143397-13-arnd@kernel.org/ > > I think we can skip any work on this. Ok, thanks, I'll drop it from my patch queue for now. If it sticks around, I'll apply it :) greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel