From: Simon Horman <simon.horman@corigine.com>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net-next] net: lan966x: Add support for TC flower filter statistics
Date: Mon, 6 Feb 2023 11:42:03 +0100 [thread overview]
Message-ID: <Y+DZe7uglZqNWu+b@corigine.com> (raw)
In-Reply-To: <20230206103252.xxqd5zvhvfdium4a@soft-dev3-1>
On Mon, Feb 06, 2023 at 11:32:52AM +0100, Horatiu Vultur wrote:
> The 02/06/2023 10:59, Simon Horman wrote:
> >
> > > > Also, not strictly related, but could you consider, as a favour to
> > > > reviewers, fixing the driver so that the following doesn't fail:
> > > >
> > > > $ make drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.o
> > > > DESCEND objtool
> > > > CALL scripts/checksyscalls.sh
> > > > CC drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.o
> > > > In file included from drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c:3:
> > > > drivers/net/ethernet/microchip/lan966x/lan966x_main.h:18:10: fatal error: vcap_api.h: No such file or directory
> > > > 18 | #include <vcap_api.h>
> > > > | ^~~~~~~~~~~~
> > > > compilation terminated.
> > >
> > > I will try to have a look at this.
> >
> > Thanks, much appreciated.
>
> Sorry for coming back to this, but it seems that I can't reproduce the
> issue:
>
> $ make drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.o
> CALL scripts/checksyscalls.sh
> DESCEND objtool
> CC drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.o
>
> I have tried different configurations without any luck. Any suggestion
> on how to reproduce the issue?
Sorry, perhaps it is something on my side.
I tried running through the steps below, which is what I assume
I had done last time, but I don't see the problem any more.
I'll let you know if it shows up again.
But in the meantime sorry for the false reporting.
$ git checkout net-next/main
$ make allmodconfig
$ make prepare
$ make drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.o
prev parent reply other threads:[~2023-02-06 10:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 13:53 [PATCH net-next] net: lan966x: Add support for TC flower filter statistics Horatiu Vultur
2023-02-04 17:12 ` Simon Horman
2023-02-06 9:52 ` Horatiu Vultur
2023-02-06 9:59 ` Simon Horman
2023-02-06 10:32 ` Horatiu Vultur
2023-02-06 10:42 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+DZe7uglZqNWu+b@corigine.com \
--to=simon.horman@corigine.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.