From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 192B5C636CD for ; Tue, 7 Feb 2023 14:50:50 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 96D28858B6; Tue, 7 Feb 2023 15:50:47 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="rNbaZ9aS"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6C744858B6; Tue, 7 Feb 2023 15:50:45 +0100 (CET) Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 50B4E858B1 for ; Tue, 7 Feb 2023 15:50:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2b.google.com with SMTP id c5so3582759qvk.13 for ; Tue, 07 Feb 2023 06:50:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=C+rn0YOKuch5IdrPdAFP12D/Zlc6ah9Ug8NNbWGtZ28=; b=rNbaZ9aSF2yvfShB9DAD8fUx+yzojFECkx9jmrEFwfbwPrIpSq/GNvC7FtfHXj8F1i rtkHYdmWS3bIdDeFxVAc6u232iY+YGt6ViKpvEuNHF+WMPqpw8YyJXPh6ZldVdlkOjdm CTawlkqLwnZJczYKxUeNGugxRWtT65o9p29Sc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=C+rn0YOKuch5IdrPdAFP12D/Zlc6ah9Ug8NNbWGtZ28=; b=mcIh7Z8oqgHiN4IZijZygiou4aD5gP6rSWr3Zz+RKl55zb36H0ptF96nuy5DMW/INk vE10BU0ItlJY0NKbEjFyHKas2s66zRjc80BJzDCOqN+ra8oNZO4arfityvEzC1VNSVCr mb1nZTB2Wab5NKbbQkbDSE2UCBKkGPYYMgzNfm+MX5G0ozeMiEz8lGU4HbzfRYufSZeL aNApzu8+ojFB2lXqtt4Zdot6YHaQrgDVBvLrbhD8xTrtoZ7tmPo+LZQX9POCmY3E/PZr L6S/KJKckt86i2B/LXQfXKoi6qRZ8vBT2QaH9M7jUr22UCBzKKMZ1UxUhEL270lK+uoG v2zw== X-Gm-Message-State: AO0yUKUzPrzl3rNlGODZPv7zOkShYZ9jxBkVXl4GGTTzASNj02BRZDr4 amR6Wb/0FUjZI0bsdoBwFjzrIw== X-Google-Smtp-Source: AK7set//XzA/ENLZGPbclYXr4wZvZy4kWOHZ8vpQXa1JkuOFXYTGAkt/dWZ+62GMVFti5Fsn0U+M4Q== X-Received: by 2002:a05:6214:da8:b0:539:9bd8:681a with SMTP id h8-20020a0562140da800b005399bd8681amr6194125qvh.31.1675781440999; Tue, 07 Feb 2023 06:50:40 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-7494-fb31-9b5f-683c.res6.spectrum.com. [2603:6081:7b00:6400:7494:fb31:9b5f:683c]) by smtp.gmail.com with ESMTPSA id u186-20020a3760c3000000b0072c86374ddfsm9616926qkb.71.2023.02.07.06.50.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 06:50:40 -0800 (PST) Date: Tue, 7 Feb 2023 09:50:38 -0500 From: Tom Rini To: Heinrich Schuchardt Cc: Simon Glass , U-Boot Mailing List Subject: Re: [PATCH v2 036/169] Correct SPL uses of CMD_BOOTEFI_BOOTMGR Message-ID: References: <20230206005537.254541-27-sjg@chromium.org> <20230206005537.254541-37-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vf1DKLebLjoQ+t+b" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --vf1DKLebLjoQ+t+b Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 07, 2023 at 08:39:38AM +0100, Heinrich Schuchardt wrote: >=20 >=20 > On 2/7/23 01:00, Tom Rini wrote: > > On Tue, Feb 07, 2023 at 12:54:03AM +0100, Heinrich Schuchardt wrote: > > >=20 > > >=20 > > > On 2/6/23 01:53, Simon Glass wrote: > > > > This converts 3 usages of this option to the non-SPL form, since th= ere is > > > > no SPL_CMD_BOOTEFI_BOOTMGR defined in Kconfig > > > >=20 > > > > Signed-off-by: Simon Glass > > > > --- > > > >=20 > > > > (no changes since v1) > > > >=20 > > > > boot/Makefile | 2 +- > > > > cmd/bootmenu.c | 4 ++-- > > > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > >=20 > > > > diff --git a/boot/Makefile b/boot/Makefile > > > > index 69c31adb77d..73b5b19816b 100644 > > > > --- a/boot/Makefile > > > > +++ b/boot/Makefile > > > > @@ -29,7 +29,7 @@ obj-$(CONFIG_$(SPL_TPL_)BOOTMETH_EFILOADER) +=3D = bootmeth_efi.o > > > > obj-$(CONFIG_$(SPL_TPL_)BOOTMETH_SANDBOX) +=3D bootmeth_sandbox.o > > > > obj-$(CONFIG_$(SPL_TPL_)BOOTMETH_SCRIPT) +=3D bootmeth_script.o > > > > ifdef CONFIG_$(SPL_TPL_)BOOTSTD_FULL > > > > -obj-$(CONFIG_$(SPL_TPL_)CMD_BOOTEFI_BOOTMGR) +=3D bootmeth_efi_mgr= =2Eo > > > > +obj-$(CONFIG_CMD_BOOTEFI_BOOTMGR) +=3D bootmeth_efi_mgr.o > > > > obj-$(CONFIG_$(SPL_TPL_)BOOTSTD) +=3D bootflow_menu.o > > > > endif > > > > diff --git a/cmd/bootmenu.c b/cmd/bootmenu.c > > > > index 3236ca5d799..422ab411252 100644 > > > > --- a/cmd/bootmenu.c > > > > +++ b/cmd/bootmenu.c > > > > @@ -223,7 +223,7 @@ static int prepare_bootmenu_entry(struct bootme= nu_data *menu, > > > > return 1; > > > > } > > > > -#if (CONFIG_IS_ENABLED(CMD_BOOTEFI_BOOTMGR)) && (CONFIG_IS_ENABLED= (CMD_EFICONFIG)) > > > > +#if (IS_ENABLED(CONFIG_CMD_BOOTEFI_BOOTMGR)) && (CONFIG_IS_ENABLED= (CMD_EFICONFIG)) > > >=20 > > > There is no reason whatsoever for using different macros for the two > > > options. > >=20 > > Here and elsewhere, one CONFIG is being fixed at a time. If at the end > > of the series this is not fixed, then that's an issue to address. >=20 > This cannot be reviewed easily. I never received the complete series. This, and the related series, are among the most reviewed we've had in quite some time. Just FWIW. > CONFIG_IS_ENABLED() is more restrictive than IS_ENABLED(). No motivation = is > provided why the condition should be relaxed in the commit message. The idea of "restrictive" is not how either of those macros should be evaluated. > Cover-letters are not in the commit history. But anyway the cover-letter > does not provide any motivation for the change either. >=20 > NAK to this patch. It's incorrect to use CONFIG_IS_ENABLED() instead of IS_ENABLED() outside of: - CONFIG_FOO, CONFIG_SPL_FOO (etc) exist - The code in question is compiled in the SPL (etc) context and we do need to know if the code block in question is required here and the implicit value of SPL_FOO being false is useful. This case is why Simon insists that adding def_bool n for SPL_EFI_LOADER, etc, is correct, but I'm not convinced. I will be taking most of these patches in the next day or two, but I can avoid the EFI ones if you insist. They are however I believe correct. --=20 Tom --vf1DKLebLjoQ+t+b Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPiZT4ACgkQFHw5/5Y0 tywCaQwAuARu5ciFJJ/vg2gJwGwQIKw/wjxZYUBwoxxAPRbVr2wg7UtrBbU5UX6d zyvgJLjb+lNeFsuCGFMYP4OT1aivr1mhms1IeDQsFJb8pPg2Oa/6AnAYBHuAcjDq ulx40UhogewTy1+C0duQCaGRBeIl/Q82ZVC4Az1wNP6+m7USaHgbKu14K5xrst21 QerHA9Yhqd17Kb0/FZrN+4aXfqzcEdcA7wkW6t8PQ/0hmAZmJ2jfgKLpbTXglH0V 2LuViEEKp2/wGqdE7tdudv7g8I6O4fNhhKUgO9Px72P1xUjU+wHtMNZC/LwichqB KrL9Rt5TIEZJUNeIsfRfcPg34b666zBqvoHu+qhC7qnOVKy921WWdNXEsym689c3 B68Uu/mDcN3/SCKpvPqGhumU+0ZQS++5dMDoVHMH3bIE/XIdMN6WNRhFS0yvuR8/ Y7qXtbSPP0bGIDa33II+eGMUFbFjOlL6jAQQcFfJFD7nVogSUVO6Ba/79wQ3ZJEN JFGlv9yC =oCsq -----END PGP SIGNATURE----- --vf1DKLebLjoQ+t+b--