From: Peter Xu <peterx@redhat.com>
To: Steven Sistare <steven.sistare@oracle.com>
Cc: qemu-devel@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Juan Quintela" <quintela@redhat.com>
Subject: Re: [PATCH V2] migration: simplify blockers
Date: Tue, 7 Feb 2023 16:29:55 -0500 [thread overview]
Message-ID: <Y+LC082KQ3Gdaghp@x1n> (raw)
In-Reply-To: <0a757102-0378-db4e-d889-9872f3a2d529@oracle.com>
On Tue, Feb 07, 2023 at 04:17:34PM -0500, Steven Sistare wrote:
> >> + * *@reasonp is freed and set to NULL if failure is returned.
> >> + * On success, the caller no longer owns *@reasonp and must not free it.
> >
> > This statement reads weird. IMHO the caller still owns @reasonp, but if it
> > succeeded it should only free it with a migrate_del_blocker() later.
>
> How about:
> On success, the caller must not free @reasonp, except by calling migrate_del_blocker.
LGTM, thanks.
--
Peter Xu
next prev parent reply other threads:[~2023-02-07 21:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 19:03 [PATCH V2] migration: simplify blockers Steve Sistare
2023-02-07 20:05 ` Peter Xu
2023-02-07 21:17 ` Steven Sistare
2023-02-07 21:29 ` Peter Xu [this message]
2023-06-07 14:13 ` Steven Sistare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+LC082KQ3Gdaghp@x1n \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=steven.sistare@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.