From: Wolfram Sang <wsa@kernel.org>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
linux-pm@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 1/2] drivers/thermal/rcar_gen3_thermal: Create device local ops struct
Date: Wed, 8 Feb 2023 08:56:17 +0100 [thread overview]
Message-ID: <Y+NVoZeqiM7cDt5w@ninjato> (raw)
In-Reply-To: <20230207171011.1596127-3-niklas.soderlund+renesas@ragnatech.se> <20230207171011.1596127-2-niklas.soderlund+renesas@ragnatech.se>
[-- Attachment #1: Type: text/plain, Size: 572 bytes --]
On Tue, Feb 07, 2023 at 06:10:10PM +0100, Niklas Söderlund wrote:
> The callback operations are modified on a driver global level. If one
> device tree description do not define interrupts, the set_trips()
> operation was disabled globally for all users of the driver.
>
> Fix this by creating a device local copy of the operations structure and
> modify the copy depending on what the device can do.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
I like this!
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-02-08 7:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 17:10 [PATCH 0/2] drivers/thermal/rcar_gen3_thermal: Fix device initialization Niklas Söderlund
2023-02-07 17:10 ` [PATCH 1/2] drivers/thermal/rcar_gen3_thermal: Create device local ops struct Niklas Söderlund
2023-02-08 7:56 ` Wolfram Sang [this message]
2023-02-07 17:10 ` [PATCH 2/2] drivers/thermal/rcar_gen3_thermal: Fix device initialization Niklas Söderlund
2023-02-08 7:58 ` Wolfram Sang
2023-02-08 10:12 ` Niklas Söderlund
2023-02-08 14:14 ` Wolfram Sang
2023-02-08 11:06 ` Daniel Lezcano
2023-02-08 18:44 ` Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+NVoZeqiM7cDt5w@ninjato \
--to=wsa@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.