From: Simon Horman <simon.horman@corigine.com>
To: "mengyuanlou@net-swift.com" <mengyuanlou@net-swift.com>
Cc: netdev@vger.kernel.org, linux-pci@vger.kernel.org, helgaas@kernel.org
Subject: Re: [PATCH] PCI: Add ACS quirk for Wangxun NICs
Date: Wed, 8 Feb 2023 09:20:39 +0100 [thread overview]
Message-ID: <Y+NbV5rKVV3zBx7A@corigine.com> (raw)
In-Reply-To: <5E1719B4-C7B4-49F7-9883-AF92A6685C03@net-swift.com>
On Wed, Feb 08, 2023 at 10:16:13AM +0800, mengyuanlou@net-swift.com wrote:
>
>
> > 2023年2月8日 01:38,Simon Horman <simon.horman@corigine.com> 写道:
> >
> > On Tue, Feb 07, 2023 at 06:24:19PM +0800, Mengyuan Lou wrote:
> >> Wangxun has verified there is no peer-to-peer between functions for the
> >> below selection of SFxxx, RP1000 and RP2000 NICS.
> >> They may be multi-function device, but the hardware does not advertise
> >> ACS capability.
> >>
> >> Add an ACS quirk for these devices so the functions can be in
> >> independent IOMMU groups.
> >>
> >> Signed-off-by: Mengyuan Lou <mengyuanlou@net-swift.com>
> >
> > ...
> >
> >> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> >> index b362d90eb9b0..bc8f484cdcf3 100644
> >> --- a/include/linux/pci_ids.h
> >> +++ b/include/linux/pci_ids.h
> >> @@ -3012,6 +3012,8 @@
> >> #define PCI_DEVICE_ID_INTEL_VMD_9A0B 0x9a0b
> >> #define PCI_DEVICE_ID_INTEL_S21152BB 0xb152
> >>
> >> +#define PCI_VENDOR_ID_WANGXUN 0x8088
> >> +
> >
> > nit: this is already present in drivers/net/ethernet/wangxun/libwx/wx_type.h
> > perhaps it can be removed from there as a follow-up ?
> It will be removed in a later patch.
Perfect, thanks.
> >> #define PCI_VENDOR_ID_SCALEMP 0x8686
> >> #define PCI_DEVICE_ID_SCALEMP_VSMP_CTL 0x1010
next prev parent reply other threads:[~2023-02-08 8:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 10:24 [PATCH] PCI: Add ACS quirk for Wangxun NICs Mengyuan Lou
2023-02-07 17:38 ` Simon Horman
2023-02-08 2:16 ` mengyuanlou
2023-02-08 8:20 ` Simon Horman [this message]
2023-02-14 0:07 ` Bjorn Helgaas
-- strict thread matches above, loose matches on Subject: below --
2023-02-01 10:47 Mengyuan Lou
2023-02-01 15:37 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+NbV5rKVV3zBx7A@corigine.com \
--to=simon.horman@corigine.com \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.