From: Mike Rapoport <rppt@kernel.org>
To: David Hildenbrand <david@redhat.com>
Cc: "Matthew Wilcox" <willy@infradead.org>,
"Hyeonggon Yoo" <42.hyeyoo@gmail.com>,
"Vlastimil Babka" <vbabka@suse.cz>,
"Christoph Lameter" <cl@linux.com>,
"Pekka Enberg" <penberg@kernel.org>,
"David Rientjes" <rientjes@google.com>,
"Joonsoo Kim" <iamjoonsoo.kim@lge.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Roman Gushchin" <roman.gushchin@linux.dev>,
"HORIGUCHI NAOYA(堀口 直也)" <naoya.horiguchi@nec.com>,
"Joe Perches" <joe@perches.com>, "Petr Mladek" <pmladek@suse.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
"Alexander Potapenko" <glider@google.com>,
"Marco Elver" <elver@google.com>
Subject: Re: [RFC v3 2/4] mm: move PG_slab flag to page_type
Date: Wed, 8 Feb 2023 11:44:42 +0200 [thread overview]
Message-ID: <Y+NvCts0JPBmAifu@kernel.org> (raw)
In-Reply-To: <59630801-42b4-22e8-0ef6-5a5b8636dfbd@redhat.com>
On Fri, Feb 03, 2023 at 05:04:01PM +0100, David Hildenbrand wrote:
> On 30.01.23 06:11, Matthew Wilcox wrote:
> > On Mon, Jan 30, 2023 at 01:34:59PM +0900, Hyeonggon Yoo wrote:
> > > > Seems like quite some changes to page_type to accomodate SLAB, which is
> > > > hopefully going away soon(TM). Could we perhaps avoid that?
> > >
> > > If it could be done with less changes, I'll try to avoid that.
> >
> > Let me outline the idea I had for removing PG_slab:
> >
> > Observe that PG_reserved and PG_slab are mutually exclusive. Also,
>
> I recall that there are SetPageReserved() calls on pages allocated via slab.
I did a quick scan, and it seems that all allocated reserved pages come
from alloc_pages() or vmalloc().
BTW, looking at the current usage of SetPageReserved, it seems that some
are bogus/historical and some would justify a different page type if we are
to have 15 bits for PG_kernel.
> --
> Thanks,
>
> David / dhildenb
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2023-02-08 9:45 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-18 10:18 [RFC v3 0/4] move PG_slab flag to page_type Hyeonggon Yoo
2022-12-18 10:18 ` [RFC v3 1/4] mm/hwpoison: remove MF_MSG_SLAB from action_page_types Hyeonggon Yoo
2022-12-20 23:53 ` HORIGUCHI NAOYA(堀口 直也)
2022-12-21 17:00 ` Andy Shevchenko
2022-12-29 13:18 ` Hyeonggon Yoo
2022-12-29 13:17 ` Hyeonggon Yoo
2022-12-18 10:18 ` [RFC v3 2/4] mm: move PG_slab flag to page_type Hyeonggon Yoo
2023-01-12 16:27 ` Vlastimil Babka
2023-01-30 4:34 ` Hyeonggon Yoo
2023-01-30 5:11 ` Matthew Wilcox
2023-02-03 16:00 ` Hyeonggon Yoo
2023-02-03 16:19 ` Matthew Wilcox
2023-02-08 13:56 ` Hyeonggon Yoo
2023-02-03 16:04 ` David Hildenbrand
2023-02-08 9:44 ` Mike Rapoport [this message]
2023-02-08 10:13 ` David Hildenbrand
2022-12-18 10:19 ` [RFC v3 3/4] mm, printk: introduce new format %pGt for page_type Hyeonggon Yoo
2022-12-18 19:32 ` kernel test robot
2022-12-19 9:44 ` Andy Shevchenko
2022-12-19 19:35 ` Randy Dunlap
2022-12-20 10:58 ` Andy Shevchenko
2022-12-29 13:35 ` Hyeonggon Yoo
2022-12-20 15:20 ` Petr Mladek
2022-12-29 13:30 ` Hyeonggon Yoo
2022-12-18 10:19 ` [RFC v3 4/4] mm/debug: use %pGt to print page_type in dump_page() Hyeonggon Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+NvCts0JPBmAifu@kernel.org \
--to=rppt@kernel.org \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=cl@linux.com \
--cc=david@redhat.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
--cc=penberg@kernel.org \
--cc=pmladek@suse.com \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.