From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50A4DC05027 for ; Wed, 8 Feb 2023 14:40:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231515AbjBHOkz (ORCPT ); Wed, 8 Feb 2023 09:40:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231407AbjBHOky (ORCPT ); Wed, 8 Feb 2023 09:40:54 -0500 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46B4B24CAE for ; Wed, 8 Feb 2023 06:40:53 -0800 (PST) Received: by mail-pj1-x1034.google.com with SMTP id rm7-20020a17090b3ec700b0022c05558d22so2499675pjb.5 for ; Wed, 08 Feb 2023 06:40:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/bxiE2oJ3WnqWoU2J6SBw1NhqrXEZjoU30zxpvXlfoY=; b=PD+sjg31omWK6nugbu6srR6lhXG2hugxiw4POwIQV3HMr9rwwpd4Mh5TQTKVkQxQdN yYK1lC5mf5HnPQkGNXhZ+Bdt+Hz7GkE7nRennD5gJzqqrEHIIK82e45Ca23ippyhVnLv jHJTbx+JoDj/T+V6oJXaBwh06DBVov7TKwo+D6vOUkBXcnYoSxF1ioxWgiLiQeN1tW95 UPB9kVmw+OgOsL5xlot13IbwMgX+ox6FWO7L090uws91g7ySnJ6ZXzKGM05bUZWf+D+U HlRQ3GFI/szrIENIGlDVBbLSmbHA+LEXApxjXITtzX62+Z/3xiiOPoTrgZAofsDY5t3J MTVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/bxiE2oJ3WnqWoU2J6SBw1NhqrXEZjoU30zxpvXlfoY=; b=ppdEPPVjybyC6aFW4oLQ16MbjaKT2nUzkhjsxg8OpB/kzX1XmqRMQXJrOMAkYrzjvz xNOuxqI1H9bh40QPKtukFublPCQ56i3c23JbNhDaAzcoigQJATrfBRse6MzwGwFRmOgj t+KLeve6DQNcRvwMn9wiyhwSfBauo93BzpIrVkK+kZ1iRp7kLgNyoUouLNktm5uLgTvv dQAQYjt3Ba4M8ua/KH2JlzuDEYKxz56Ppbadq7xceHMY14ik/3KpbPrZ55JDFUjCSUOw ZFgPj8l2IrBjEIMcIQ4/e6t1gWVF78mVAR7NhRd9iEWiuuvZiJ9J1m1b4NFm4zrXOsoj TgEQ== X-Gm-Message-State: AO0yUKUaZhfPFOSDNguYxNt62eI4KtiMTkAYM58NVhOwNOhjdSgkSudV Fckn6qGWpXQTfi+r99lbzQmyKA== X-Google-Smtp-Source: AK7set9cnI7ijCR0Pe/LRnHhQyiJoqhpZaqODCYVMDTdmfraExS5wzHGiHkduxKKVSYx4BSModBUCg== X-Received: by 2002:a17:902:788b:b0:194:6d3c:38a5 with SMTP id q11-20020a170902788b00b001946d3c38a5mr204703pll.1.1675867252646; Wed, 08 Feb 2023 06:40:52 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id r9-20020a63a009000000b004db2b310f95sm9689139pge.16.2023.02.08.06.40.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Feb 2023 06:40:52 -0800 (PST) Date: Wed, 8 Feb 2023 14:40:48 +0000 From: Sean Christopherson To: Vipin Sharma Cc: pbonzini@redhat.com, bgardon@google.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Patch v2] KVM: selftests: Make reclaim_period_ms input always be positive Message-ID: References: <20230111183408.104491-1-vipinsh@google.com> <167582135970.455074.533102478332510041.b4-ty@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Feb 07, 2023, Vipin Sharma wrote: > On Tue, Feb 7, 2023 at 6:10 PM Sean Christopherson wrote: > > > > On Wed, 11 Jan 2023 10:34:08 -0800, Vipin Sharma wrote: > > > reclaim_period_ms use to be positive only but the commit 0001725d0f9b > > > ("KVM: selftests: Add atoi_positive() and atoi_non_negative() for input > > > validation") incorrectly changed it to non-negative validation. > > > > > > Change validation to allow only positive input. > > > > > > > > > [...] > > > > Applied to kvm-x86 selftests, thanks! > > Just FYI, this patch has already been applied to kvm/master branch. > https://git.kernel.org/pub/scm/virt/kvm/kvm.git/commit/?id=c2c46b10d52624376322b01654095a84611c7e09 Now I know why I was getting deja vu... Dropped, thanks Vipin!