From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFAD5C636CC for ; Wed, 8 Feb 2023 14:52:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231571AbjBHOv6 (ORCPT ); Wed, 8 Feb 2023 09:51:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231256AbjBHOvx (ORCPT ); Wed, 8 Feb 2023 09:51:53 -0500 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F345C15B; Wed, 8 Feb 2023 06:51:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675867913; x=1707403913; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=3P68b0TVOlpRiURRNLVvw64Yo8IjZVFB+vqzhU4qIC8=; b=N4m5Epe6+urLldVT+ALcBfv7cRHHaaacs8NI6i86a+/bMg7up1jRQul3 K2cXc9lMW+EVI7gkHMN61O28/BPPihQ+YbJgorsIhnSvftSYEVyRGkTfC ZCix5FuXDdTfOSIHY5zTGRSuFjnR2TX4Vs5YCran3+jezZ8FTp7t4rYKZ 6icmnw5U8T8SVX3MHd8g1iPkGC8Wj0VXJlpSy+Xa5KAOUw8qCEuswgy9k wrzatSM7BmFrjHXRGa784JlNOErghFYOjQ2SdnyyhN+QNMlBGc0NG1WgY cRm7XE/vO320D5kl4GsxEcmF06ICIIT+o0t2yeXOac4WWy+cbdT7IJDdY g==; X-IronPort-AV: E=McAfee;i="6500,9779,10615"; a="313454189" X-IronPort-AV: E=Sophos;i="5.97,281,1669104000"; d="scan'208";a="313454189" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2023 06:51:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10615"; a="841199018" X-IronPort-AV: E=Sophos;i="5.97,281,1669104000"; d="scan'208";a="841199018" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005.jf.intel.com with ESMTP; 08 Feb 2023 06:51:44 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pPlnR-004ANT-0z; Wed, 08 Feb 2023 16:51:41 +0200 Date: Wed, 8 Feb 2023 16:51:41 +0200 From: Andy Shevchenko To: Linus Walleij Cc: Arnd Bergmann , Bartosz Golaszewski , Geert Uytterhoeven , Christophe Leroy , Michael Ellerman , Dmitry Torokhov , Stefan Schmidt , Miquel Raynal , linux-gpio@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc-tw-discuss@lists.sourceforge.net, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-acpi@vger.kernel.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-wpan@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com, linux-arch@vger.kernel.org, devicetree@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH v3 06/12] gpiolib: split linux/gpio/driver.h out of linux/gpio.h Message-ID: References: <20230207142952.51844-1-andriy.shevchenko@linux.intel.com> <20230207142952.51844-7-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Wed, Feb 08, 2023 at 12:55:06AM +0200, Andy Shevchenko wrote: > On Tue, Feb 07, 2023 at 03:55:23PM +0100, Linus Walleij wrote: > > On Tue, Feb 7, 2023 at 3:29 PM Andy Shevchenko > > wrote: > > > > > From: Arnd Bergmann > > > > > > Almost all gpio drivers include linux/gpio/driver.h, and other > > > files should not rely on includes from this header. > > > > > > Remove the indirect include from here and include the correct > > > headers directly from where they are used. > > ... > > > Make sure you push this to the kernel.org build servers (zeroday builds), > > Of course, that is the purpose of publishing this before the release (so we > will have some TODO list that eventually this can be applied for v6.4-rc1). > > > I think this patch needs to hit some more files, in my tests with a similar > > patch at least these: > > Right. I forgot to also incorporate your stuff into this series. > Do you have anything that I can take as is? I'm going to incorporate the following: gpio: Make the legacy consumer-only ARM: s3c24xx: Use the right include ARM: orion/gpio: Use the right include hte: tegra-194: Use proper includes pcmcia: pxa2xx_viper: Include dependency -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0B83C05027 for ; Wed, 8 Feb 2023 14:53:03 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4PBjfP6ST9z3cgx for ; Thu, 9 Feb 2023 01:53:01 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Rb08+Sbt; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.intel.com (client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=andriy.shevchenko@linux.intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Rb08+Sbt; dkim-atps=neutral Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4PBjdK1SW3z2xYL for ; Thu, 9 Feb 2023 01:52:03 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675867925; x=1707403925; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=3P68b0TVOlpRiURRNLVvw64Yo8IjZVFB+vqzhU4qIC8=; b=Rb08+SbtjqAZ3OOW8cT9QVhCz6qpYXsu+QAHDej4f4PlWaJrX1wfBnDu Q/f5etxuIJJZb11a1j+qgpFCcNILZaFuHwsO9hgbAd84dNXR1tcgpzaLg p+9r0shvtRiVKtjGz6k9tYCgDt4lyQzdsKEanXvn9ds1hDfVIYhTJeygi AaX9CyRJv3wAVIpPAxRNIVMWHi85sw+xXSBqGiZ7uD5iK2bCeYGHY/sLO SYX3UBge+AkkkUIXqZ0j+CVN+OZDf2LDCXO3c2ZZQwiJ5VCV/GqEsLeeO jqjdXpwPrGna5ZnFtu6RNfP8l7mv/+RYPBogHC3lyc4GZbEzx5sWd08W0 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10615"; a="313454201" X-IronPort-AV: E=Sophos;i="5.97,281,1669104000"; d="scan'208";a="313454201" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2023 06:51:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10615"; a="841199018" X-IronPort-AV: E=Sophos;i="5.97,281,1669104000"; d="scan'208";a="841199018" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005.jf.intel.com with ESMTP; 08 Feb 2023 06:51:44 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pPlnR-004ANT-0z; Wed, 08 Feb 2023 16:51:41 +0200 Date: Wed, 8 Feb 2023 16:51:41 +0200 From: Andy Shevchenko To: Linus Walleij Subject: Re: [PATCH v3 06/12] gpiolib: split linux/gpio/driver.h out of linux/gpio.h Message-ID: References: <20230207142952.51844-1-andriy.shevchenko@linux.intel.com> <20230207142952.51844-7-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-sh@vger.kernel.org, Miquel Raynal , Stefan Schmidt , linux-arch@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Bartosz Golaszewski , Bartosz Golaszewski , linux-doc@vger.kernel.org, linux-acpi@vger.kernel.org, SHA-cyfmac-dev-list@infineon.com, Geert Uytterhoeven , linux-input@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, Arnd Bergmann , linux-gpio@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, brcm80211-dev-list.pdl@broadcom.com, linuxppc-dev@lists.ozlabs.org, linux-doc-tw-discuss@lists.sourceforge.net, Dmitry Torokhov , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-wpan@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Feb 08, 2023 at 12:55:06AM +0200, Andy Shevchenko wrote: > On Tue, Feb 07, 2023 at 03:55:23PM +0100, Linus Walleij wrote: > > On Tue, Feb 7, 2023 at 3:29 PM Andy Shevchenko > > wrote: > > > > > From: Arnd Bergmann > > > > > > Almost all gpio drivers include linux/gpio/driver.h, and other > > > files should not rely on includes from this header. > > > > > > Remove the indirect include from here and include the correct > > > headers directly from where they are used. > > ... > > > Make sure you push this to the kernel.org build servers (zeroday builds), > > Of course, that is the purpose of publishing this before the release (so we > will have some TODO list that eventually this can be applied for v6.4-rc1). > > > I think this patch needs to hit some more files, in my tests with a similar > > patch at least these: > > Right. I forgot to also incorporate your stuff into this series. > Do you have anything that I can take as is? I'm going to incorporate the following: gpio: Make the legacy consumer-only ARM: s3c24xx: Use the right include ARM: orion/gpio: Use the right include hte: tegra-194: Use proper includes pcmcia: pxa2xx_viper: Include dependency -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86A2AC636CC for ; Wed, 8 Feb 2023 14:53:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DQU7HRJEI4NPXKeoiEXjF9eO9RrsjmZx4SbWTBb6C5g=; b=aBnpHP+nq3ucaG /597dIsCasfBUsSqtcAUEqpNtadIXfGSiLx74p8XszK3/27H2zNaJgGZ6n9QIbvHmyirXnolUCtBN y9HvJxTG7oaVt7ty/o8JRFL9jPrmffr5Isy6Q3+5jmtKxjtmA8xVt8lgsPUVJzejFn9PR2vp84I3v mqCESQl7ifePvCztRTxsb/7b5nK6QUf41l2uLQFFNuzqaem584v9XXaliTxwHcLsz3DNkiDzUBkyC s5z6owMVRSwAnYrw10xrYEiZJ7OUskLoarXxiWCjbG8MsyOEwDQDwLOjJ/Ktcz29I0aItC2gb0+lE gdOjdovzf11Rt3Jvv54Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPlnh-00Fxvb-U4; Wed, 08 Feb 2023 14:51:58 +0000 Received: from mga18.intel.com ([134.134.136.126]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPlnf-00FxuU-3I for linux-arm-kernel@lists.infradead.org; Wed, 08 Feb 2023 14:51:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675867915; x=1707403915; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=3P68b0TVOlpRiURRNLVvw64Yo8IjZVFB+vqzhU4qIC8=; b=jBAMMRkpzCi1QDuwfRGVIPVJENGCstjBchioUP9LgUIf9wpMuyFik5f1 MiOjXcTeITiyRynh1w016uZ7TsmyPEwCXLPOc5wSza6ziGUjEIs5+XJhk CWbngTQF+TgGzy3VPV+LiikHAfibjuARvOYOqABpwmk+GVEeb0Epk3D1s mr8KAZ0vRWzaSGzZahylfuwSt1DP/FnS1kRx7S2nu0lDsAl+2haEmHQxW ZoncMw/tTCFGhEeLwQSpjmQHikk2iJ4UmKhlb/9zCRzYu7ZJ0r0jCBwzV F7plfd6CtzRI9HX1+NSgxsJH2Yy68MS0wCDtOj3so5d1oChSrsT70aOch A==; X-IronPort-AV: E=McAfee;i="6500,9779,10615"; a="313454195" X-IronPort-AV: E=Sophos;i="5.97,281,1669104000"; d="scan'208";a="313454195" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2023 06:51:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10615"; a="841199018" X-IronPort-AV: E=Sophos;i="5.97,281,1669104000"; d="scan'208";a="841199018" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005.jf.intel.com with ESMTP; 08 Feb 2023 06:51:44 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pPlnR-004ANT-0z; Wed, 08 Feb 2023 16:51:41 +0200 Date: Wed, 8 Feb 2023 16:51:41 +0200 From: Andy Shevchenko To: Linus Walleij Cc: Arnd Bergmann , Bartosz Golaszewski , Geert Uytterhoeven , Christophe Leroy , Michael Ellerman , Dmitry Torokhov , Stefan Schmidt , Miquel Raynal , linux-gpio@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc-tw-discuss@lists.sourceforge.net, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-acpi@vger.kernel.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-wpan@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com, linux-arch@vger.kernel.org, devicetree@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH v3 06/12] gpiolib: split linux/gpio/driver.h out of linux/gpio.h Message-ID: References: <20230207142952.51844-1-andriy.shevchenko@linux.intel.com> <20230207142952.51844-7-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230208_065155_197869_29303080 X-CRM114-Status: GOOD ( 23.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 08, 2023 at 12:55:06AM +0200, Andy Shevchenko wrote: > On Tue, Feb 07, 2023 at 03:55:23PM +0100, Linus Walleij wrote: > > On Tue, Feb 7, 2023 at 3:29 PM Andy Shevchenko > > wrote: > > > > > From: Arnd Bergmann > > > > > > Almost all gpio drivers include linux/gpio/driver.h, and other > > > files should not rely on includes from this header. > > > > > > Remove the indirect include from here and include the correct > > > headers directly from where they are used. > > ... > > > Make sure you push this to the kernel.org build servers (zeroday builds), > > Of course, that is the purpose of publishing this before the release (so we > will have some TODO list that eventually this can be applied for v6.4-rc1). > > > I think this patch needs to hit some more files, in my tests with a similar > > patch at least these: > > Right. I forgot to also incorporate your stuff into this series. > Do you have anything that I can take as is? I'm going to incorporate the following: gpio: Make the legacy consumer-only ARM: s3c24xx: Use the right include ARM: orion/gpio: Use the right include hte: tegra-194: Use proper includes pcmcia: pxa2xx_viper: Include dependency -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel