From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Jakub Kicinski <kuba@kernel.org>, Xin Long <lucien.xin@gmail.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
dev@openvswitch.org, tipc-discussion@lists.sourceforge.net,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Pravin B Shelar <pshelar@ovn.org>, Jon Maloy <jmaloy@redhat.com>,
Ying Xue <ying.xue@windriver.com>,
Simon Horman <simon.horman@corigine.com>
Subject: Re: [PATCH net-next v3 1/3] string_helpers: Move string_is_valid() to the header
Date: Wed, 8 Feb 2023 16:47:29 +0200 [thread overview]
Message-ID: <Y+O2AdEZMAeUjEU5@smile.fi.intel.com> (raw)
In-Reply-To: <Y+O0+ngPHklhtx6k@nanopsycho>
On Wed, Feb 08, 2023 at 03:43:06PM +0100, Jiri Pirko wrote:
> Wed, Feb 08, 2023 at 02:31:51PM CET, andriy.shevchenko@linux.intel.com wrote:
> >Move string_is_valid() to the header for wider use.
> >
> >While at it, rename to string_is_terminated() to be
> >precise about its semantics.
>
> While at it, you could drop the ternary operator and return memchr()
> directly.
Code generation will be the same, I won't modify too much the original,
the point of the change is just to have this helper to be available to
others.
> With or without it:
> Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Thank you!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-02-08 14:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 13:31 [PATCH net-next v3 1/3] string_helpers: Move string_is_valid() to the header Andy Shevchenko
2023-02-08 13:31 ` [PATCH net-next v3 2/3] genetlink: Use string_is_terminated() helper Andy Shevchenko
2023-02-08 14:44 ` Jiri Pirko
2023-02-08 13:31 ` [PATCH net-next v3 3/3] openvswitch: " Andy Shevchenko
2023-02-08 14:44 ` Jiri Pirko
2023-02-08 14:43 ` [PATCH net-next v3 1/3] string_helpers: Move string_is_valid() to the header Jiri Pirko
2023-02-08 14:47 ` Andy Shevchenko [this message]
2023-02-10 6:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+O2AdEZMAeUjEU5@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=jmaloy@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pshelar@ovn.org \
--cc=simon.horman@corigine.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.