From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6880C05027 for ; Wed, 8 Feb 2023 14:28:59 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 9E1663CC1A4 for ; Wed, 8 Feb 2023 15:28:57 +0100 (CET) Received: from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [217.194.8.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 2010A3C2A67 for ; Wed, 8 Feb 2023 15:28:47 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 315111400543 for ; Wed, 8 Feb 2023 15:28:46 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id F381F34254; Wed, 8 Feb 2023 14:28:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1675866526; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R70PXsMbXi8NbABjQdfmHCideBPYnj5eezlq+0ltyT4=; b=gqB0ZqSZ0pA2zfdCB1iszyaNwCsmFuFalGAHUQryRAR+gER503as8xkBH09m989Kkqw5R6 V90jmUm9jrN3kT1jX/hkr8UiAQCl9eTYnGu8hT9oEbzzcaSDPmeu6EyfMv3ffLYqDsxEPf ULmiRJzjDfU1tdUEogSEWap0cfZdnb4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1675866526; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R70PXsMbXi8NbABjQdfmHCideBPYnj5eezlq+0ltyT4=; b=GgaH+KOxewkKmo7EJ3kqVBKUbT3EJ8na02Rax8zJZ8MJJI83zPWymvZUfB8E6mKZwJm9z6 0uMiPbeypnj3ksDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E00711358A; Wed, 8 Feb 2023 14:28:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id piRANZ2x42OHJQAAMHmgww (envelope-from ); Wed, 08 Feb 2023 14:28:45 +0000 Date: Wed, 8 Feb 2023 15:30:16 +0100 From: Cyril Hrubis To: Petr Vorel Message-ID: References: <20230208092327.28914-1-pvorel@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Virus-Scanned: clamav-milter 0.102.4 at in-6.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 1/1] testscripts/network.sh: Don't load tst_net.sh X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > > This should not be needed any more for neither new API and legacy tests > > since 04021637f4 ("tst_test.sh: Cleanup getopts usage") > I suppose loading tst_net.sh was not needed even before. I wonder why this was > ever needed. > > It was added in 6538f7ab70 ("network: merge networktests.sh/networkstress.sh > into network.sh") when testcases/lib/test_net.sh (predecessor of > testcases/lib/tst_net.sh) was much simpler (e.g. without netns). Actually it sems that it was just moved from the top of the file further down in that commit. It was in the git since the beginning when the file was added by Alexey. Maybe there were scripts that didn't include any shell library at that time, who knows. Anyways as long as all the network tests we have does include the library themselves let's go ahead and get rid of it. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp