From: David Vernet <void@manifault.com>
To: Dave Thaler <dthaler@microsoft.com>
Cc: Dave Thaler <dthaler1968=40googlemail.com@dmarc.ietf.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"bpf@ietf.org" <bpf@ietf.org>
Subject: Re: [Bpf] [PATCH bpf-next v2] bpf, docs: Explain helper functions
Date: Wed, 8 Feb 2023 11:29:55 -0600 [thread overview]
Message-ID: <Y+PcE1O/uPdAWxYF@maniforge.lan> (raw)
In-Reply-To: <PH7PR21MB387847C84B7D6DA43607692DA3D89@PH7PR21MB3878.namprd21.prod.outlook.com>
On Wed, Feb 08, 2023 at 05:26:34PM +0000, Dave Thaler wrote:
> David Vernet wrote:
> > > +Reserved instructions
> > > +====================
> >
> > small nit: Missing a =
>
> Ack.
>
> > > +Clang will generate the reserved ``BPF_CALL | BPF_X | BPF_JMP`` (0x8d)
> > instruction if ``-O0`` is used.
> >
> > Are we calling this out here to say that BPF_CALL in clang -O0 builds is not
> > supported? That would seem to be the case given that we say that BPF_CALL
> > | BPF_X | BPF_JMP in reserved and not permitted in instruction-set.rst.
>
> Yes, exactly. I could update the language to add something like
> "... so BPF_CALL in clang -O0 builds is not supported".
Gotcha, that sounds good to me. Thanks for being so thorough in
documenting all of this tribal knowledge.
next prev parent reply other threads:[~2023-02-08 17:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 19:16 [PATCH bpf-next v2] bpf, docs: Explain helper functions Dave Thaler
2023-02-08 15:10 ` [Bpf] " David Vernet
2023-02-08 17:26 ` Dave Thaler
2023-02-08 17:29 ` David Vernet [this message]
2023-02-08 17:31 ` Alexei Starovoitov
2023-02-08 17:40 ` David Vernet
2023-02-08 17:45 ` Dave Thaler
2023-02-09 16:04 ` David Vernet
2023-02-12 23:20 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+PcE1O/uPdAWxYF@maniforge.lan \
--to=void@manifault.com \
--cc=bpf@ietf.org \
--cc=bpf@vger.kernel.org \
--cc=dthaler1968=40googlemail.com@dmarc.ietf.org \
--cc=dthaler@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.