From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06D096AAD for ; Wed, 8 Feb 2023 18:01:14 +0000 (UTC) Received: by mail-wr1-f43.google.com with SMTP id j23so2430006wra.0 for ; Wed, 08 Feb 2023 10:01:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QsaledRgqtR8MThisrbwNQQMiogQzEIa1ri2xN8U5x4=; b=cg0MVG6I6Y76rF/CZvC25sdPVewyNWnsbfa7pgSc2FzuvBEF1nJRYSbvtTtvCpyBYJ HVLVtYnuT2OXWBj247C60aUx18fMk60nfUTiPvyx4vWWIhhiFEXg1o5dZyYT2/CaBTHP Rk2W5EmObgDHnqXG6uH8g+U60GFuUN5xmPtLp+yaC9KRyVxJF0lsGEdkb3hXs1k4BBWs iXNRGDCeD6nJQ4LykFmzgC8UAm19GyMoUamSPNDWn8i1D9ZOfuf2RdGy1ji+r3lnwDIr AagVGYdSSv5vJlQaz0Ywkho2nGWBLCoeb1NwcamBM2qwdKm8oT1IJM430mbbdShhBRYB BaSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QsaledRgqtR8MThisrbwNQQMiogQzEIa1ri2xN8U5x4=; b=E3zYipQNa19vLEV5mL2KpQVZvwVtR+xff2aX4ZIcvP+sj+G2wFwkmEzqftWqQKHANw Kitd4bfVdAdApiAY0DweEOyT0cNHdeVhTmUn5Cl2i+HwXSutsnRnFhsy7lHZpnRBzvnQ 2hiBlxc2KP133DdpCK9XVXhwjfWkkVru/oAj3/sky1OoVovjBgKQzfGoB+3zd47qIXfn Ojp4QdHr4jPuzqKB3A/n7U07WNtpgAEKveqllBbgyuc/tltC53glc5S3bxauvnMA/wpU LoTtsbbq4zj7NOBRX5Tru3SRzCD8k62uledgmeJzezoAFBxl34vG3EV8wjxehSGNaQcS Fr+g== X-Gm-Message-State: AO0yUKVOOQEj1vmjpheA1Ghhgqi6TzggRsoLq0J/S4MVhyO+G3Eu1ApT Vh48IJfkLDdH46OVyDvbhMsA4g== X-Google-Smtp-Source: AK7set+3IM5sAOEuhaAPwVF0OVGRlrlPx7WqR8A8ToS+qIOpKQFwoXaZmbDkTQkIZJClDWGbpxR0/g== X-Received: by 2002:adf:e80e:0:b0:2bf:f44b:7a29 with SMTP id o14-20020adfe80e000000b002bff44b7a29mr7118746wrm.40.1675879273302; Wed, 08 Feb 2023 10:01:13 -0800 (PST) Received: from myrica (054592b0.skybroadband.com. [5.69.146.176]) by smtp.gmail.com with ESMTPSA id l13-20020adffe8d000000b002bfbda53b98sm11081478wrr.35.2023.02.08.10.01.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Feb 2023 10:01:12 -0800 (PST) Date: Wed, 8 Feb 2023 18:01:07 +0000 From: Jean-Philippe Brucker To: Mostafa Saleh Cc: maz@kernel.org, catalin.marinas@arm.com, will@kernel.org, joro@8bytes.org, robin.murphy@arm.com, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com, dbrazdil@google.com, ryan.roberts@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, iommu@lists.linux.dev, Abhinav Kumar , Alyssa Rosenzweig , Andy Gross , Bjorn Andersson , Daniel Vetter , David Airlie , Dmitry Baryshkov , Hector Martin , Konrad Dybcio , Matthias Brugger , Rob Clark , Rob Herring , Sean Paul , Steven Price , Suravee Suthikulpanit , Sven Peter , Tomeu Vizoso , Yong Wu Subject: Re: [RFC PATCH 05/45] iommu/io-pgtable: Split io_pgtable structure Message-ID: References: <20230201125328.2186498-1-jean-philippe@linaro.org> <20230201125328.2186498-6-jean-philippe@linaro.org> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Mostafa, On Tue, Feb 07, 2023 at 12:16:12PM +0000, Mostafa Saleh wrote: > > +static inline size_t > > +iopt_unmap_pages(struct io_pgtable *iop, unsigned long iova, size_t pgsize, > > + size_t pgcount, struct iommu_iotlb_gather *gather) > > +{ > > + if (!iop->ops || !iop->ops->map_pages) > Should this be !iop->ops->unmap_pages? Oh right, good catch! Sorry about the size of this patch by the way. If we decide to keep this change I'll reduce it by first introducing these helpers and then splitting the structure in another patch. Thanks, Jean From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B3C5C05027 for ; Wed, 8 Feb 2023 18:02:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ifr2aI8IuKA2GxLG+Ppdw+1RDmKbslO3IjTYRGYM9zA=; b=0RkPjystxJuMwc REF6LQvpI1YrjDhBLC20ufbzCWE+5co5xM9nZ/uXhvqWptg3Z6mSSBEWM2Uoh9/80fYcAv++GfbLQ vEbwUnzzEiCI10QDg6fF1k+iKEd3EO/n24vXxpP91Ssq9gmrBZtAjYay60Pd79+IWdG7hyYA95BPy wPPjXgwPrkUjJnFxbJWkx+RUU1/cno5PnpYn2b27mnO/sjl4PaSFABn9SBq4MrMTr77gkbuIXz8rg RMz0inA1fI1eIao0MuG0t5aU5LZZJL9VDoBtfYgn6aRatAxuaFJUZrbrv2uHrJ3PdRlQmbb/FQNyB TZF8FL5dTmX5cbxzLC7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPokz-00GXgg-2s; Wed, 08 Feb 2023 18:01:21 +0000 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPokv-00GXdj-KJ for linux-arm-kernel@lists.infradead.org; Wed, 08 Feb 2023 18:01:18 +0000 Received: by mail-wr1-x435.google.com with SMTP id h16so17594707wrz.12 for ; Wed, 08 Feb 2023 10:01:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QsaledRgqtR8MThisrbwNQQMiogQzEIa1ri2xN8U5x4=; b=cg0MVG6I6Y76rF/CZvC25sdPVewyNWnsbfa7pgSc2FzuvBEF1nJRYSbvtTtvCpyBYJ HVLVtYnuT2OXWBj247C60aUx18fMk60nfUTiPvyx4vWWIhhiFEXg1o5dZyYT2/CaBTHP Rk2W5EmObgDHnqXG6uH8g+U60GFuUN5xmPtLp+yaC9KRyVxJF0lsGEdkb3hXs1k4BBWs iXNRGDCeD6nJQ4LykFmzgC8UAm19GyMoUamSPNDWn8i1D9ZOfuf2RdGy1ji+r3lnwDIr AagVGYdSSv5vJlQaz0Ywkho2nGWBLCoeb1NwcamBM2qwdKm8oT1IJM430mbbdShhBRYB BaSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QsaledRgqtR8MThisrbwNQQMiogQzEIa1ri2xN8U5x4=; b=JDXW6RcCF1zB9YoqbN8OzV58KyB7AzVOHsrlffTKCmz0kJov0rpIlJdNxYB0reA/lU IEBljeslsJdTKGor2TQc619PaFPfr5atjgnOSWRpfbYrhonI8L8Zg2wiLfWVspDxF4nI V+niB5SVQ+lHUlvksmZhLRA+8IJxv4VrYoThFBLhF4mYxO4MtkLObV50aXL/8miBcm7T Sy6IysHw8tSBMv32pBAiPzirh+Y6PPoEG+b8RQp4zXX9DR4loEqJMdEyJSwYk2R6+8EH EmgUjRjsn2oW/Y+BmnAEW0HwKM4025ZU+tsQAMUkbucI1m2/euXGaolRoR2O78uGyBW4 Kc3A== X-Gm-Message-State: AO0yUKUUKV90agn5Q5RBhbX0RGYAu3NCYyWr4KQbVZkXFZ5skVdM5FIi f2tpEi/oWgKXgWw6xG2JngWrJQ== X-Google-Smtp-Source: AK7set+3IM5sAOEuhaAPwVF0OVGRlrlPx7WqR8A8ToS+qIOpKQFwoXaZmbDkTQkIZJClDWGbpxR0/g== X-Received: by 2002:adf:e80e:0:b0:2bf:f44b:7a29 with SMTP id o14-20020adfe80e000000b002bff44b7a29mr7118746wrm.40.1675879273302; Wed, 08 Feb 2023 10:01:13 -0800 (PST) Received: from myrica (054592b0.skybroadband.com. [5.69.146.176]) by smtp.gmail.com with ESMTPSA id l13-20020adffe8d000000b002bfbda53b98sm11081478wrr.35.2023.02.08.10.01.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Feb 2023 10:01:12 -0800 (PST) Date: Wed, 8 Feb 2023 18:01:07 +0000 From: Jean-Philippe Brucker To: Mostafa Saleh Cc: maz@kernel.org, catalin.marinas@arm.com, will@kernel.org, joro@8bytes.org, robin.murphy@arm.com, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com, dbrazdil@google.com, ryan.roberts@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, iommu@lists.linux.dev, Abhinav Kumar , Alyssa Rosenzweig , Andy Gross , Bjorn Andersson , Daniel Vetter , David Airlie , Dmitry Baryshkov , Hector Martin , Konrad Dybcio , Matthias Brugger , Rob Clark , Rob Herring , Sean Paul , Steven Price , Suravee Suthikulpanit , Sven Peter , Tomeu Vizoso , Yong Wu Subject: Re: [RFC PATCH 05/45] iommu/io-pgtable: Split io_pgtable structure Message-ID: References: <20230201125328.2186498-1-jean-philippe@linaro.org> <20230201125328.2186498-6-jean-philippe@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230208_100117_684911_56880B0E X-CRM114-Status: GOOD ( 11.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mostafa, On Tue, Feb 07, 2023 at 12:16:12PM +0000, Mostafa Saleh wrote: > > +static inline size_t > > +iopt_unmap_pages(struct io_pgtable *iop, unsigned long iova, size_t pgsize, > > + size_t pgcount, struct iommu_iotlb_gather *gather) > > +{ > > + if (!iop->ops || !iop->ops->map_pages) > Should this be !iop->ops->unmap_pages? Oh right, good catch! Sorry about the size of this patch by the way. If we decide to keep this change I'll reduce it by first introducing these helpers and then splitting the structure in another patch. Thanks, Jean _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel