From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE96AC05027 for ; Wed, 8 Feb 2023 21:17:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5262E10E03F; Wed, 8 Feb 2023 21:17:11 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 464FD10E03F; Wed, 8 Feb 2023 21:17:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675891030; x=1707427030; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=MTkIjRrAUVHxfFuE/udAY65LVVfcQKIlf793dCgtcJI=; b=lhmca2DT8IZkpc62FIoDRIeapx8WYSvFDGxzs90xgd8veAdt7nGfMQg8 DWP+6RQvOIgX6tsAKkLFZvvq6iLlHBdYyiZ7OuS+fMfUdoGyenIyUlcuh /4Il3ZaFIgZATNL0iB1OpzZw5hS5BO+LIGCeEoO+QQuarZYmjXe2SA2fS HX5NX0skdcL/8usDBwvLqwPkzAzQkJl7XKX3H93b8jMqf3paCwVzo4/qb gByIqHi9GtGSh2EcQGFSScbvGgoJwPypwDvU/Cn7Wq6mL7huz97sXoYUi 3A1iwnCwLifed905GiP01yLgYIjHxxZ5yMkh7xpfPdq7adctUtuyYz9Ya g==; X-IronPort-AV: E=McAfee;i="6500,9779,10615"; a="329955500" X-IronPort-AV: E=Sophos;i="5.97,281,1669104000"; d="scan'208";a="329955500" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2023 13:17:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10615"; a="660787049" X-IronPort-AV: E=Sophos;i="5.97,281,1669104000"; d="scan'208";a="660787049" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.55]) by orsmga007.jf.intel.com with SMTP; 08 Feb 2023 13:16:56 -0800 Received: by stinkbox (sSMTP sendmail emulation); Wed, 08 Feb 2023 23:16:56 +0200 Date: Wed, 8 Feb 2023 23:16:56 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Pekka Paalanen Message-ID: References: <20230208040911.12590-1-ville.syrjala@linux.intel.com> <20230208040911.12590-2-ville.syrjala@linux.intel.com> <20230208141312.76df0cb0.pekka.paalanen@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [PATCH 1/2] drm: Introduce plane SIZE_HINTS property X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, Simon Ser , intel-gfx@lists.freedesktop.org, Jonas =?iso-8859-1?Q?=C5dahl?= , Daniel Stone Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Feb 08, 2023 at 03:03:49PM +0200, Ville Syrjälä wrote: > On Wed, Feb 08, 2023 at 02:13:12PM +0200, Pekka Paalanen wrote: > > On Wed, 8 Feb 2023 06:09:10 +0200 > > Ville Syrjala wrote: > > > > > From: Ville Syrjälä > > > > > > Add a new immutable plane property by which a plane can advertise > > > a handful of recommended plane sizes. This would be mostly exposed > > > by cursor planes as a slightly more capable replacement for > > > the DRM_CAP_CURSOR_WIDTH/HEIGHT caps, which can only declare > > > a one size fits all limit for the whole device. > > > > > > Currently eg. amdgpu/i915/nouveau just advertize the max cursor > > > size via the cursor size caps. But always using the max sized > > > cursor can waste a surprising amount of power, so a better > > > stragey is desirable. > > > > > > Most other drivers don't specify any cursor size at all, in > > > which case the ioctl code just claims that 64x64 is a great > > > choice. Whether that is actually true is debatable. > > > > > > A poll of various compositor developers informs us that > > > blindly probing with setcursor/atomic ioctl to determine > > > suitable cursor sizes is not acceptable, thus the > > > introduction of the new property to supplant the cursor > > > size caps. The compositor will now be free to select a > > > more optimal cursor size from the short list of options. > > > > > > Note that the reported sizes (either via the property or the > > > caps) make no claims about things such as plane scaling. So > > > these things should only really be consulted for simple > > > "cursor like" use cases. > > > > > > Cc: Simon Ser > > > Cc: Jonas Ådahl > > > Cc: Daniel Stone > > > Cc: Pekka Paalanen > > > Signed-off-by: Ville Syrjälä > > > --- > > > drivers/gpu/drm/drm_mode_config.c | 7 +++++++ > > > drivers/gpu/drm/drm_plane.c | 33 +++++++++++++++++++++++++++++++ > > > include/drm/drm_mode_config.h | 5 +++++ > > > include/drm/drm_plane.h | 4 ++++ > > > include/uapi/drm/drm_mode.h | 5 +++++ > > > 5 files changed, 54 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c > > > index 87eb591fe9b5..21860f94a18c 100644 > > > --- a/drivers/gpu/drm/drm_mode_config.c > > > +++ b/drivers/gpu/drm/drm_mode_config.c > > > @@ -374,6 +374,13 @@ static int drm_mode_create_standard_properties(struct drm_device *dev) > > > return -ENOMEM; > > > dev->mode_config.modifiers_property = prop; > > > > > > + prop = drm_property_create(dev, > > > + DRM_MODE_PROP_IMMUTABLE | DRM_MODE_PROP_BLOB, > > > + "SIZE_HINTS", 0); > > > + if (!prop) > > > + return -ENOMEM; > > > + dev->mode_config.size_hints_property = prop; > > > + > > > return 0; > > > } > > > > > > diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c > > > index 24e7998d1731..d0a277f4be1f 100644 > > > --- a/drivers/gpu/drm/drm_plane.c > > > +++ b/drivers/gpu/drm/drm_plane.c > > > @@ -1582,3 +1582,36 @@ int drm_plane_create_scaling_filter_property(struct drm_plane *plane, > > > return 0; > > > } > > > EXPORT_SYMBOL(drm_plane_create_scaling_filter_property); > > > + > > > +/** > > > + * drm_plane_add_size_hint_property - create a size hint property > > > + * > > > + * @plane: drm plane > > > + * @hints: size hints > > > + * @num_hints: number of size hints > > > + * > > > + * Create a size hints property for the plane. > > > + * > > > + * RETURNS: > > > + * Zero for success or -errno > > > + */ > > > +int drm_plane_add_size_hints_property(struct drm_plane *plane, > > > + const struct drm_plane_size_hint *hints, > > > + int num_hints) > > > +{ > > > + struct drm_device *dev = plane->dev; > > > + struct drm_mode_config *config = &dev->mode_config; > > > + struct drm_property_blob *blob; > > > + > > > + blob = drm_property_create_blob(dev, > > > + array_size(sizeof(hints[0]), num_hints), > > > + hints); > > > + if (IS_ERR(blob)) > > > + return PTR_ERR(blob); > > > + > > > + drm_object_attach_property(&plane->base, config->size_hints_property, > > > + blob->base.id); > > > + > > > + return 0; > > > +} > > > +EXPORT_SYMBOL(drm_plane_add_size_hints_property); > > > diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h > > > index e5b053001d22..ed9f6938dca1 100644 > > > --- a/include/drm/drm_mode_config.h > > > +++ b/include/drm/drm_mode_config.h > > > @@ -949,6 +949,11 @@ struct drm_mode_config { > > > */ > > > struct drm_property *modifiers_property; > > > > > > + /** > > > + * @size_hints_property: Plane SIZE_HINTS property. > > > + */ > > > + struct drm_property *size_hints_property; > > > + > > > /* cursor size */ > > > uint32_t cursor_width, cursor_height; > > > > > > diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h > > > index 51291983ea44..1997d7d64b69 100644 > > > --- a/include/drm/drm_plane.h > > > +++ b/include/drm/drm_plane.h > > > @@ -32,6 +32,7 @@ > > > #include > > > > > > struct drm_crtc; > > > +struct drm_plane_size_hint; > > > struct drm_printer; > > > struct drm_modeset_acquire_ctx; > > > > > > @@ -945,5 +946,8 @@ drm_plane_get_damage_clips(const struct drm_plane_state *state); > > > > > > int drm_plane_create_scaling_filter_property(struct drm_plane *plane, > > > unsigned int supported_filters); > > > +int drm_plane_add_size_hints_property(struct drm_plane *plane, > > > + const struct drm_plane_size_hint *hints, > > > + int num_hints); > > > > > > #endif > > > diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h > > > index 46becedf5b2f..4f0551d7f481 100644 > > > --- a/include/uapi/drm/drm_mode.h > > > +++ b/include/uapi/drm/drm_mode.h > > > @@ -849,6 +849,11 @@ struct drm_color_lut { > > > __u16 reserved; > > > }; > > > > > > +struct drm_plane_size_hint { > > > + __u16 width; > > > + __u16 height; > > > +}; > > > > Hi Ville, > > > > uAPI documentation is missing. > > > > When there is just a single recommended size listed, userspace has it > > easy: allocate a pair of DRM dumb buffers for each active CRTC, do > > atomic test commits with those, and if the test succeeds, copy in the > > pixels and fill the padding. > > > > What if we have multiple or a huge number of possible sizes? Probably > > for each KMS reconfiguration cycle (which could be up to every refresh > > cycle) userspace would need to allocate a new dumb buffer to have the > > right size, and then test. Is that something we can actually afford to > > do? I don't know. > > Why would you allocate multiple buffers? Just allocate one > with the max size and then you can reuse it at any smaller > size as needed. Unfortunately the use of gbm here means the stride would be wrong for the smaller sizes. So I guess a different buffer for each size is what you need to do. Unless you can just ignore the original stride when filling the buffer. > > > > > Therefore maybe this proposal is a good compromise. The driver lists > > *few* sizes that are roughly equally likely to work, that is, if the > > cursor plane does not work, it's not because of the size. Userspace > > pre-allocates DRM dumb buffers for each size. When attempting to use a > > cursor plane, userspace picks the smallest size that suffices, and tests > > only with that. > > Yeah, don't see why you ever retry multiple times with increased > cursor size. If the small size doesn't work then surely the > larger size won't either (larger size requiring more hw resources > to operate). > > > > > Seems fine to me. The uAPI docs should explain what userspace is > > expected to do with it. > > > > > > Thanks, > > pq > > > > > + > > > /** > > > * struct hdr_metadata_infoframe - HDR Metadata Infoframe Data. > > > * > > -- > Ville Syrjälä > Intel -- Ville Syrjälä Intel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85DE5C636D3 for ; Wed, 8 Feb 2023 21:17:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D08FE10E189; Wed, 8 Feb 2023 21:17:11 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 464FD10E03F; Wed, 8 Feb 2023 21:17:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675891030; x=1707427030; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=MTkIjRrAUVHxfFuE/udAY65LVVfcQKIlf793dCgtcJI=; b=lhmca2DT8IZkpc62FIoDRIeapx8WYSvFDGxzs90xgd8veAdt7nGfMQg8 DWP+6RQvOIgX6tsAKkLFZvvq6iLlHBdYyiZ7OuS+fMfUdoGyenIyUlcuh /4Il3ZaFIgZATNL0iB1OpzZw5hS5BO+LIGCeEoO+QQuarZYmjXe2SA2fS HX5NX0skdcL/8usDBwvLqwPkzAzQkJl7XKX3H93b8jMqf3paCwVzo4/qb gByIqHi9GtGSh2EcQGFSScbvGgoJwPypwDvU/Cn7Wq6mL7huz97sXoYUi 3A1iwnCwLifed905GiP01yLgYIjHxxZ5yMkh7xpfPdq7adctUtuyYz9Ya g==; X-IronPort-AV: E=McAfee;i="6500,9779,10615"; a="329955500" X-IronPort-AV: E=Sophos;i="5.97,281,1669104000"; d="scan'208";a="329955500" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2023 13:17:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10615"; a="660787049" X-IronPort-AV: E=Sophos;i="5.97,281,1669104000"; d="scan'208";a="660787049" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.55]) by orsmga007.jf.intel.com with SMTP; 08 Feb 2023 13:16:56 -0800 Received: by stinkbox (sSMTP sendmail emulation); Wed, 08 Feb 2023 23:16:56 +0200 Date: Wed, 8 Feb 2023 23:16:56 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Pekka Paalanen Subject: Re: [Intel-gfx] [PATCH 1/2] drm: Introduce plane SIZE_HINTS property Message-ID: References: <20230208040911.12590-1-ville.syrjala@linux.intel.com> <20230208040911.12590-2-ville.syrjala@linux.intel.com> <20230208141312.76df0cb0.pekka.paalanen@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Patchwork-Hint: comment X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Jonas =?iso-8859-1?Q?=C5dahl?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Feb 08, 2023 at 03:03:49PM +0200, Ville Syrjälä wrote: > On Wed, Feb 08, 2023 at 02:13:12PM +0200, Pekka Paalanen wrote: > > On Wed, 8 Feb 2023 06:09:10 +0200 > > Ville Syrjala wrote: > > > > > From: Ville Syrjälä > > > > > > Add a new immutable plane property by which a plane can advertise > > > a handful of recommended plane sizes. This would be mostly exposed > > > by cursor planes as a slightly more capable replacement for > > > the DRM_CAP_CURSOR_WIDTH/HEIGHT caps, which can only declare > > > a one size fits all limit for the whole device. > > > > > > Currently eg. amdgpu/i915/nouveau just advertize the max cursor > > > size via the cursor size caps. But always using the max sized > > > cursor can waste a surprising amount of power, so a better > > > stragey is desirable. > > > > > > Most other drivers don't specify any cursor size at all, in > > > which case the ioctl code just claims that 64x64 is a great > > > choice. Whether that is actually true is debatable. > > > > > > A poll of various compositor developers informs us that > > > blindly probing with setcursor/atomic ioctl to determine > > > suitable cursor sizes is not acceptable, thus the > > > introduction of the new property to supplant the cursor > > > size caps. The compositor will now be free to select a > > > more optimal cursor size from the short list of options. > > > > > > Note that the reported sizes (either via the property or the > > > caps) make no claims about things such as plane scaling. So > > > these things should only really be consulted for simple > > > "cursor like" use cases. > > > > > > Cc: Simon Ser > > > Cc: Jonas Ådahl > > > Cc: Daniel Stone > > > Cc: Pekka Paalanen > > > Signed-off-by: Ville Syrjälä > > > --- > > > drivers/gpu/drm/drm_mode_config.c | 7 +++++++ > > > drivers/gpu/drm/drm_plane.c | 33 +++++++++++++++++++++++++++++++ > > > include/drm/drm_mode_config.h | 5 +++++ > > > include/drm/drm_plane.h | 4 ++++ > > > include/uapi/drm/drm_mode.h | 5 +++++ > > > 5 files changed, 54 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c > > > index 87eb591fe9b5..21860f94a18c 100644 > > > --- a/drivers/gpu/drm/drm_mode_config.c > > > +++ b/drivers/gpu/drm/drm_mode_config.c > > > @@ -374,6 +374,13 @@ static int drm_mode_create_standard_properties(struct drm_device *dev) > > > return -ENOMEM; > > > dev->mode_config.modifiers_property = prop; > > > > > > + prop = drm_property_create(dev, > > > + DRM_MODE_PROP_IMMUTABLE | DRM_MODE_PROP_BLOB, > > > + "SIZE_HINTS", 0); > > > + if (!prop) > > > + return -ENOMEM; > > > + dev->mode_config.size_hints_property = prop; > > > + > > > return 0; > > > } > > > > > > diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c > > > index 24e7998d1731..d0a277f4be1f 100644 > > > --- a/drivers/gpu/drm/drm_plane.c > > > +++ b/drivers/gpu/drm/drm_plane.c > > > @@ -1582,3 +1582,36 @@ int drm_plane_create_scaling_filter_property(struct drm_plane *plane, > > > return 0; > > > } > > > EXPORT_SYMBOL(drm_plane_create_scaling_filter_property); > > > + > > > +/** > > > + * drm_plane_add_size_hint_property - create a size hint property > > > + * > > > + * @plane: drm plane > > > + * @hints: size hints > > > + * @num_hints: number of size hints > > > + * > > > + * Create a size hints property for the plane. > > > + * > > > + * RETURNS: > > > + * Zero for success or -errno > > > + */ > > > +int drm_plane_add_size_hints_property(struct drm_plane *plane, > > > + const struct drm_plane_size_hint *hints, > > > + int num_hints) > > > +{ > > > + struct drm_device *dev = plane->dev; > > > + struct drm_mode_config *config = &dev->mode_config; > > > + struct drm_property_blob *blob; > > > + > > > + blob = drm_property_create_blob(dev, > > > + array_size(sizeof(hints[0]), num_hints), > > > + hints); > > > + if (IS_ERR(blob)) > > > + return PTR_ERR(blob); > > > + > > > + drm_object_attach_property(&plane->base, config->size_hints_property, > > > + blob->base.id); > > > + > > > + return 0; > > > +} > > > +EXPORT_SYMBOL(drm_plane_add_size_hints_property); > > > diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h > > > index e5b053001d22..ed9f6938dca1 100644 > > > --- a/include/drm/drm_mode_config.h > > > +++ b/include/drm/drm_mode_config.h > > > @@ -949,6 +949,11 @@ struct drm_mode_config { > > > */ > > > struct drm_property *modifiers_property; > > > > > > + /** > > > + * @size_hints_property: Plane SIZE_HINTS property. > > > + */ > > > + struct drm_property *size_hints_property; > > > + > > > /* cursor size */ > > > uint32_t cursor_width, cursor_height; > > > > > > diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h > > > index 51291983ea44..1997d7d64b69 100644 > > > --- a/include/drm/drm_plane.h > > > +++ b/include/drm/drm_plane.h > > > @@ -32,6 +32,7 @@ > > > #include > > > > > > struct drm_crtc; > > > +struct drm_plane_size_hint; > > > struct drm_printer; > > > struct drm_modeset_acquire_ctx; > > > > > > @@ -945,5 +946,8 @@ drm_plane_get_damage_clips(const struct drm_plane_state *state); > > > > > > int drm_plane_create_scaling_filter_property(struct drm_plane *plane, > > > unsigned int supported_filters); > > > +int drm_plane_add_size_hints_property(struct drm_plane *plane, > > > + const struct drm_plane_size_hint *hints, > > > + int num_hints); > > > > > > #endif > > > diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h > > > index 46becedf5b2f..4f0551d7f481 100644 > > > --- a/include/uapi/drm/drm_mode.h > > > +++ b/include/uapi/drm/drm_mode.h > > > @@ -849,6 +849,11 @@ struct drm_color_lut { > > > __u16 reserved; > > > }; > > > > > > +struct drm_plane_size_hint { > > > + __u16 width; > > > + __u16 height; > > > +}; > > > > Hi Ville, > > > > uAPI documentation is missing. > > > > When there is just a single recommended size listed, userspace has it > > easy: allocate a pair of DRM dumb buffers for each active CRTC, do > > atomic test commits with those, and if the test succeeds, copy in the > > pixels and fill the padding. > > > > What if we have multiple or a huge number of possible sizes? Probably > > for each KMS reconfiguration cycle (which could be up to every refresh > > cycle) userspace would need to allocate a new dumb buffer to have the > > right size, and then test. Is that something we can actually afford to > > do? I don't know. > > Why would you allocate multiple buffers? Just allocate one > with the max size and then you can reuse it at any smaller > size as needed. Unfortunately the use of gbm here means the stride would be wrong for the smaller sizes. So I guess a different buffer for each size is what you need to do. Unless you can just ignore the original stride when filling the buffer. > > > > > Therefore maybe this proposal is a good compromise. The driver lists > > *few* sizes that are roughly equally likely to work, that is, if the > > cursor plane does not work, it's not because of the size. Userspace > > pre-allocates DRM dumb buffers for each size. When attempting to use a > > cursor plane, userspace picks the smallest size that suffices, and tests > > only with that. > > Yeah, don't see why you ever retry multiple times with increased > cursor size. If the small size doesn't work then surely the > larger size won't either (larger size requiring more hw resources > to operate). > > > > > Seems fine to me. The uAPI docs should explain what userspace is > > expected to do with it. > > > > > > Thanks, > > pq > > > > > + > > > /** > > > * struct hdr_metadata_infoframe - HDR Metadata Infoframe Data. > > > * > > -- > Ville Syrjälä > Intel -- Ville Syrjälä Intel