Re: [PATCH v12 0/3] riscv, mm: detect svnapot cpu support at runtime

From: Conor Dooley <conor.dooley@microchip.com>
To: Qinglin Pan <panqinglin2020@iscas.ac.cn>
Cc: <linux-riscv@lists.infradead.org>, <bjorn@kernel.org>
Subject: Re: [PATCH v12 0/3] riscv, mm: detect svnapot cpu support at runtime
Date: Thu, 9 Feb 2023 08:58:19 +0000	[thread overview]
Message-ID: <Y+S1q8JME5E6sd2s@wendy> (raw)
In-Reply-To: <f5004cea-283b-6c9f-f0f7-f13eae213b08@iscas.ac.cn>

[-- Attachment #1.1: Type: text/plain, Size: 2877 bytes --]

+CC Bjorn

On Thu, Feb 09, 2023 at 04:40:47PM +0800, Qinglin Pan wrote:
> Hey!
> 
> On 2023/2/9 16:18, Conor Dooley wrote:
> > On Thu, Feb 09, 2023 at 04:03:01PM +0800, Qinglin Pan wrote:
> > > Hey!
> > > 
> > > On 2023/2/9 15:30, Conor Dooley wrote:
> > > > Hey!
> > > > 
> > > > On Thu, Feb 09, 2023 at 12:00:32PM +0800, Qinglin Pan wrote:
> > > > > Hi all,
> > > > > 
> > > > > Sorry for bothering :(
> > > > > 
> > > > > This patchset has a bit of a formatting problem.
> > > > > Please use another one:
> > > > > https://lore.kernel.org/linux-riscv/20230209035343.15282-1-panqinglin00@gmail.com/T/#t
> > > > 
> > > > If you're resending, please either mark as RESEND or increment the
> > > > version number so that tools don't get confused.
> > > > In this case though, tools found some issues with both version
> > > > unfortunately:
> > > > https://patchwork.kernel.org/project/linux-riscv/patch/20230209035343.15282-2-panqinglin00@gmail.com/
> > > > https://patchwork.kernel.org/project/linux-riscv/patch/20230209035343.15282-3-panqinglin00@gmail.com/
> > > > (if you click on the descriptions you should get more information on
> > > > what is wrong)
> > > > 
> > > > You can fix those up and send a v13 and it'll all be clear then ;)
> > > 
> > > Your information is very helpful, thanks so much!
> > > 
> > > I will send a v13 later. But I am very curious about why
> > > conchuod/alphanumeric_selects is failed and what content is in
> > > this test? Could you please give me some hints about it? ;)
> > 
> > Oh yeah, that output is not very helpful is it. It runs a perl script
> > that RMK created that tries to put things in the "correct" order before
> > and after the patch is applied. The script is here:
> > https://github.com/ConchuOD/nipa/blob/main/tests_rv/patch/alphanumeric_selects/alphanumeric_selects.pl
> 
> It is what I really need :) :) :)

That perl script will completely re-order the file, so it is run from
another script that just diffs the result with the existing Kconfig
file.

> > It also re-orders default/depends on strings, and I assume it's being
> > tripped up by the config option that you are adding not doing what it
> > wants you to do with the order of those.
> > I think you can ignore that one for now.
> > 
> > It's the build errors and SoB issues that I am more interested in
> > getting fixed ;)
> > 
> > I'll go convert the error level of that to a warning & try to fix up the
> > reporting that it does.

I think I have fixed this to do something that actually says what it is
complaining about:
https://github.com/ConchuOD/nipa/pull/18

In the future, it'll do something like:
| --- /dev/fd/63	2023-02-09 08:45:10.809992544 +0000
| +++ /dev/fd/62	2023-02-09 08:45:10.809992544 +0000
| @@ -354,0 +355 @@
| +	select ARCH_HAS_NOTHING

Cheers,
Conor.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv