From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Shuah Khan <shuah@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] tracing/selftests: Ignore __pfx_ symbols in kprobe test
Date: Thu, 9 Feb 2023 11:45:43 +0100 [thread overview]
Message-ID: <Y+TO1+k58kj2Z29t@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20230208170304.388c1786@gandalf.local.home>
On Wed, Feb 08, 2023 at 05:03:04PM -0500, Steven Rostedt wrote:
> On Wed, 8 Feb 2023 19:05:08 +0100
> Peter Zijlstra <peterz@infradead.org> wrote:
>
> > > This is assuming that kprobes can not be added on top of these. But another
> > > solution could be to have kprobes just pick the function the __pfx_ is for.
> > > Would that be a better solution?
> >
> > Simply refusing them is simplest. I don't see a compelling reason to
> > make this complicated.
>
> OK, so you are good with the patch as is then?
Yeah, but given I've no idea about the whole test thing or .tc files I
didn't ack.
next prev parent reply other threads:[~2023-02-09 10:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 18:51 [PATCH] tracing/selftests: Ignore __pfx_ symbols in kprobe test Steven Rostedt
2023-02-07 18:54 ` Steven Rostedt
2023-02-08 18:05 ` Peter Zijlstra
2023-02-08 22:03 ` Steven Rostedt
2023-02-09 10:45 ` Peter Zijlstra [this message]
2023-02-09 14:23 ` Masami Hiramatsu
2023-02-10 9:51 ` Peter Zijlstra
2023-02-09 14:06 ` Masami Hiramatsu
2023-02-14 1:46 ` Steven Rostedt
2023-03-18 18:42 ` Steven Rostedt
2023-03-20 12:56 ` Shuah Khan
2023-03-20 16:30 ` Shuah Khan
2023-03-20 16:32 ` Steven Rostedt
2023-03-20 16:40 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+TO1+k58kj2Z29t@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.