From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0170BC61DA4 for ; Thu, 9 Feb 2023 17:50:10 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3122885F4D; Thu, 9 Feb 2023 18:50:08 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="AOLZepy0"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3BF1185F4D; Thu, 9 Feb 2023 18:50:06 +0100 (CET) Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1C87485DEB for ; Thu, 9 Feb 2023 18:50:02 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x829.google.com with SMTP id v17so2879634qto.3 for ; Thu, 09 Feb 2023 09:50:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WZzVn+pzKSlPunYrwIgOgV1+YYw5iiG2bieKJxPVX5Y=; b=AOLZepy0rU2DLtzhZ6fmg4cppyT/25UJHweVj8rgw2UZg+gs7Md3uguSrXHEb6RgFy CMjEAvTfSvIlUn6bxzVHjCEZvPpIVPjvvPpYdI/VKWVuPZb9R9uFoA+siSIKkFZfQeZv ruFQ303GaRTxDDCjD5O8SRLmKoeBlPvZb3O0I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WZzVn+pzKSlPunYrwIgOgV1+YYw5iiG2bieKJxPVX5Y=; b=FDKqsglbgJeVGQIlJN5qjAapE54EnXaULdCIyn6Q0iNzWbnb0jCj8nVhFoSjpziujO zJkyYGubHKK0BoKhwnY+btKfVUjg2JEH9h/f68zo2UrhfhLjOzlUllOnWNYk6Vkf5YG8 FRgci7phk3wuwFJFk2i8X0Hii2Wf0XJvbi50c0IyBMYuQNpOCXbJxAtlJjeZZuorQ/UD 40pMCFKbuoYn9sGEp60xRyYZUmOMvgsQAZkDk+4Y195VMu4Mm8fY1sxL7DzU/OujD7SM vYGNpMu27LDvn9rMNFBclIcwg5J1JVLcCIq+LG5ZlEoRG4ER3lnjjEflwTLGz96apQdW 4F0g== X-Gm-Message-State: AO0yUKVGlwtnIwCZ7Q+vsnEp9L0ZpDAMTJp33aUDAnNDY5Q5lKQ3Z/t8 gtf3hpWH5Hj9J57pLaMp+vVjpAebQKhplqZbSVg= X-Google-Smtp-Source: AK7set+bECutiLE15/i8RQF/ELThj7cRQVwbGjcIiuKh5wkvrjzkBTDxTRtJMp7RQrHTJ2NWsC+QSg== X-Received: by 2002:a05:622a:506:b0:3b7:ebb2:a4bf with SMTP id l6-20020a05622a050600b003b7ebb2a4bfmr20512480qtx.24.1675965000918; Thu, 09 Feb 2023 09:50:00 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-538d-baa1-e57f-2a07.res6.spectrum.com. [2603:6081:7b00:6400:538d:baa1:e57f:2a07]) by smtp.gmail.com with ESMTPSA id k13-20020ac8074d000000b003b630ea0ea1sm1647131qth.19.2023.02.09.09.50.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 09:50:00 -0800 (PST) Date: Thu, 9 Feb 2023 12:49:58 -0500 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Patrick Delaunay , Patrice Chotard , uboot-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH v2 064/169] Correct SPL uses of DFU_VIRT Message-ID: References: <20230205224118.233425-63-sjg@chromium.org> <20230205224118.233425-65-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dm6fyh7l758rHHFW" Content-Disposition: inline In-Reply-To: <20230205224118.233425-65-sjg@chromium.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --dm6fyh7l758rHHFW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 05, 2023 at 03:39:33PM -0700, Simon Glass wrote: > This converts 3 usages of this option to the non-SPL form, since there is > no SPL_DFU_VIRT defined in Kconfig >=20 > Signed-off-by: Simon Glass > --- >=20 > (no changes since v1) >=20 > board/st/common/stm32mp_dfu.c | 2 +- > drivers/dfu/Makefile | 2 +- > include/dfu.h | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/board/st/common/stm32mp_dfu.c b/board/st/common/stm32mp_dfu.c > index 0096f71dfc1..19e9c3b2402 100644 > --- a/board/st/common/stm32mp_dfu.c > +++ b/board/st/common/stm32mp_dfu.c > @@ -159,7 +159,7 @@ void set_dfu_alt_info(char *interface, char *devstr) > puts("DFU alt info setting: done\n"); > } > =20 > -#if CONFIG_IS_ENABLED(DFU_VIRT) > +#if IS_ENABLED(CONFIG_DFU_VIRT) > #include > #include > =20 > diff --git a/drivers/dfu/Makefile b/drivers/dfu/Makefile > index dfbf64da667..df88f4be59a 100644 > --- a/drivers/dfu/Makefile > +++ b/drivers/dfu/Makefile > @@ -10,4 +10,4 @@ obj-$(CONFIG_$(SPL_)DFU_NAND) +=3D dfu_nand.o > obj-$(CONFIG_$(SPL_)DFU_RAM) +=3D dfu_ram.o > obj-$(CONFIG_$(SPL_)DFU_SF) +=3D dfu_sf.o > obj-$(CONFIG_$(SPL_)DFU_WRITE_ALT) +=3D dfu_alt.o > -obj-$(CONFIG_$(SPL_)DFU_VIRT) +=3D dfu_virt.o > +obj-$(CONFIG_DFU_VIRT) +=3D dfu_virt.o > diff --git a/include/dfu.h b/include/dfu.h > index 07922224ef1..06efbf4b208 100644 > --- a/include/dfu.h > +++ b/include/dfu.h > @@ -495,7 +495,7 @@ static inline int dfu_fill_entity_mtd(struct dfu_enti= ty *dfu, char *devstr, > } > #endif > =20 > -#if CONFIG_IS_ENABLED(DFU_VIRT) > +#if IS_ENABLED(CONFIG_DFU_VIRT) > int dfu_fill_entity_virt(struct dfu_entity *dfu, char *devstr, > char **argv, int argc); > int dfu_write_medium_virt(struct dfu_entity *dfu, u64 offset, This is I believe an intentional usage. --=20 Tom --dm6fyh7l758rHHFW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPlMjwACgkQFHw5/5Y0 tywyZAwAo5v+ou036grMRDqao4C/ZytqgADynq2iaVXKM76DFfXVVA83IqjaRk0d sxbHcR5ZoCuDAu/LexKhK+rFxVT2yddhxnbsnpWFDH+KdtrM9/MxADMeMM/eufl3 zJp9AKIKZl5WEqpyVAzdrWlK36Xie3Hlqz9axV1rQ+zzvsUgxpFKclxSXBaCAPXr Za8PImg91KLQaI942e1TAeD/S2YiE0SqYURegPzTjEaT7ZO/O9v4PpdSuLZEM9YI SmyXDQU9vSX7xlMubyrpQUBmXrKSs5rMjAHC2xMjwhrQVq20ZGd1hUWwYvih8sgN Y6+LBcO4ntT4EAdPXYucZ2sErCXW5cavWRxqVAZ+G9v6j24XDPBADbxxKWz6C6N+ K8QYeGZ2jgzOL8tE6TXvhyipYf1fp4vTioGQj7TkU+UmlZPzyXL1juSm1Nl3nSpy t3ScBD1zVlBswyjLmaKP/8fyKw4oggesRmMPevj2qy5vbkJEpsDwPA58TmLlQOJC p5/+RcQG =dxP3 -----END PGP SIGNATURE----- --dm6fyh7l758rHHFW--