From: Peter Xu <peterx@redhat.com>
To: Gavin Shan <gshan@redhat.com>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, pbonzini@redhat.com,
peter.maydell@linaro.org, david@redhat.com, philmd@linaro.org,
mst@redhat.com, cohuck@redhat.com, quintela@redhat.com,
dgilbert@redhat.com, maz@kernel.org, zhenyzha@redhat.com,
shan.gavin@gmail.com
Subject: Re: [PATCH RFCv1 2/8] memory: Add last stage indicator to global dirty log synchronization
Date: Thu, 9 Feb 2023 14:48:14 -0500 [thread overview]
Message-ID: <Y+VN/vWvdO2IxL3C@x1n> (raw)
In-Reply-To: <20230206112010.99871-3-gshan@redhat.com>
On Mon, Feb 06, 2023 at 07:20:04PM +0800, Gavin Shan wrote:
> The global dirty log synchronization is used when KVM and dirty ring
> are enabled. There is a particularity for ARM64 where the backup
> bitmap is used to track dirty pages in non-running-vcpu situations.
> It means the dirty ring works with the combination of ring buffer
> and backup bitmap. The dirty bits in the backup bitmap needs to
> collected in the last stage of live migration.
>
> In order to identify the last stage of live migration and pass it
> down, an extra parameter is added to the relevant functions and
> callback. This last stage information isn't used yet.
>
> No functional change intended.
>
> Signed-off-by: Gavin Shan <gshan@redhat.com>
> ---
> accel/kvm/kvm-all.c | 2 +-
> include/exec/memory.h | 5 +++--
> migration/dirtyrate.c | 4 ++--
> migration/ram.c | 6 +++---
Better move the migration/ changes into the next patch.
Thanks,
--
Peter Xu
next prev parent reply other threads:[~2023-02-09 19:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 11:20 [PATCH RFCv1 0/8] hw/arm/virt: Support dirty ring Gavin Shan
2023-02-06 11:20 ` [PATCH RFCv1 1/8] linux-headers: Update for " Gavin Shan
2023-02-06 11:20 ` [PATCH RFCv1 2/8] memory: Add last stage indicator to global dirty log synchronization Gavin Shan
2023-02-09 19:48 ` Peter Xu [this message]
2023-02-10 4:57 ` Gavin Shan
2023-02-06 11:20 ` [PATCH RFCv1 3/8] migration: " Gavin Shan
2023-02-06 11:20 ` [PATCH RFCv1 4/8] kvm: Introduce secondary dirty bitmap Gavin Shan
2023-02-08 22:07 ` Juan Quintela
2023-02-09 9:42 ` Gavin Shan
2023-02-06 11:20 ` [PATCH RFCv1 5/8] kvm: Synchronize secondary bitmap in last stage Gavin Shan
2023-02-06 11:20 ` [PATCH RFCv1 6/8] kvm: Add helper kvm_dirty_ring_init() Gavin Shan
2023-02-08 22:11 ` Juan Quintela
2023-02-09 9:43 ` Gavin Shan
2023-02-06 11:20 ` [PATCH RFCv1 7/8] hw/arm/virt: Enable backup bitmap for dirty ring Gavin Shan
2023-02-08 22:14 ` Juan Quintela
2023-02-06 11:20 ` [PATCH RFCv1 8/8] kvm: Enable dirty ring for arm64 Gavin Shan
2023-02-08 22:15 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+VN/vWvdO2IxL3C@x1n \
--to=peterx@redhat.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=gshan@redhat.com \
--cc=maz@kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=shan.gavin@gmail.com \
--cc=zhenyzha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.