From: Matthias Kaehlcke <mka@chromium.org>
To: Owen Yang <ecs.taipeikernel@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Gavin Lee <gavin.lee@ecs.com.tw>,
Doug Anderson <dianders@chromium.org>, Harvey <hunge@google.com>,
Abner Yen <abner.yen@ecs.com.tw>,
Stephen Boyd <swboyd@chromium.org>,
Bob Moragues <moragues@google.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sc7280: Adjust zombie PWM frequency
Date: Thu, 9 Feb 2023 19:45:31 +0000 [thread overview]
Message-ID: <Y+VNW3ikQVgXK4VV@google.com> (raw)
In-Reply-To: <20230209102807.1.I3e1463cd0fb66311a269f2698d0767a2acfaac3f@changeid>
On Thu, Feb 09, 2023 at 10:28:16AM +0800, Owen Yang wrote:
> Tune the PWM to solve screen flashing issue and high frequency noise.
>
> Signed-off-by: Owen Yang <ecs.taipeikernel@gmail.com>
> ---
>
> arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dtsi
> index 64deaaabac0f..000f64d27ab9 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dtsi
> @@ -61,8 +61,8 @@ ap_tp_i2c: &i2c0 {
> };
>
> &pm8350c_pwm_backlight {
> - /* Set the PWM period to 200 microseconds (5kHz duty cycle) */
> - pwms = <&pm8350c_pwm 3 200000>;
> + /* Set the PWM period to 320 microseconds (8kHz duty cycle) */
> + pwms = <&pm8350c_pwm 3 320000>;
Is 'duty cycle' really correct here? The unit of the duty cycle is
percent, not kHz and it shouldn't be impacted by this change. I guess
you mean frequency.
And how does this change result in a frequency of 8kHz? Wouldn't it be
3.125 kHz with a peridod of 320us?
prev parent reply other threads:[~2023-02-09 19:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 2:28 [PATCH] arm64: dts: qcom: sc7280: Adjust zombie PWM frequency Owen Yang
2023-02-09 19:45 ` Matthias Kaehlcke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+VNW3ikQVgXK4VV@google.com \
--to=mka@chromium.org \
--cc=abner.yen@ecs.com.tw \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=ecs.taipeikernel@gmail.com \
--cc=gavin.lee@ecs.com.tw \
--cc=hunge@google.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=moragues@google.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.