From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A0D4C05027 for ; Fri, 10 Feb 2023 07:09:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676012947; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=GhmUeZc/psT9hrGUHR6VYfWURVD4ozqtYm9BElVLPoA=; b=QnWQs20pzpQnWvh1dwXnd2ZZRnjuws5uA0xp4iEPO+io0LpGQHif+RpMpl8OvOWMl9nzb1 gU+CJPGen1Xd2brwIZVZPRGX/Wofyjk1w86HD7ulaCVnb3g4OCR4wgHZ8dIuXsxkUfRPEV C+w4acHcAs//PCJU2+m6TcDIiThmB0k= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-271-McfDRuY8MnCLgW51iTUvGg-1; Fri, 10 Feb 2023 02:09:06 -0500 X-MC-Unique: McfDRuY8MnCLgW51iTUvGg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5528F80D0E2; Fri, 10 Feb 2023 07:09:04 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0C5A8C16026; Fri, 10 Feb 2023 07:09:02 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 54B6719465B2; Fri, 10 Feb 2023 07:09:01 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id CE6181946589 for ; Fri, 10 Feb 2023 00:56:44 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id BE576492B00; Fri, 10 Feb 2023 00:56:44 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B6FD2492C3E for ; Fri, 10 Feb 2023 00:56:44 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 95454802314 for ; Fri, 10 Feb 2023 00:56:44 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-168-gC2gYVLgM9aiFAqDrfqXNw-1; Thu, 09 Feb 2023 19:56:40 -0500 X-MC-Unique: gC2gYVLgM9aiFAqDrfqXNw-1 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D0499B822D1; Fri, 10 Feb 2023 00:56:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12C5DC433D2; Fri, 10 Feb 2023 00:56:36 +0000 (UTC) Date: Fri, 10 Feb 2023 02:56:34 +0200 From: Jarkko Sakkinen To: Herbert Xu Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mailman-Approved-At: Fri, 10 Feb 2023 07:09:00 +0000 Subject: Re: [dm-devel] [PATCH 17/17] crypto: api - Remove completion function scaffolding X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Howells , dm-devel@redhat.com, keyrings@vger.kernel.org, Alasdair Kergon , Steffen Klassert , Boris Pismenny , John Fastabend , Tyler Hicks , Jakub Kicinski , Paolo Abeni , Johan Hedberg , Marcel Holtmann , ecryptfs@vger.kernel.org, Mike Snitzer , Luiz Augusto von Dentz , netdev@vger.kernel.org, Eric Dumazet , Jon Maloy , linux-bluetooth@vger.kernel.org, Linux Crypto Mailing List , Ying Xue , "David S. Miller" Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Feb 06, 2023 at 06:22:46PM +0800, Herbert Xu wrote: > This patch removes the temporary scaffolding now that the comletion > function signature has been converted. > > Signed-off-by: Herbert Xu For the 1-17: Acked-by: Jarkko Sakkinen (nit applies tho to all of them but use your own judgement i guess) > --- > > include/linux/crypto.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/include/linux/crypto.h b/include/linux/crypto.h > index 80f6350fb588..bb1d9b0e1647 100644 > --- a/include/linux/crypto.h > +++ b/include/linux/crypto.h > @@ -176,7 +176,6 @@ struct crypto_async_request; > struct crypto_tfm; > struct crypto_type; > > -typedef void crypto_completion_data_t; > typedef void (*crypto_completion_t)(void *req, int err); > > /** > @@ -596,11 +595,6 @@ struct crypto_wait { > /* > * Async ops completion helper functioons > */ > -static inline void *crypto_get_completion_data(void *data) > -{ > - return data; > -} > - > void crypto_req_done(void *req, int err); > > static inline int crypto_wait_req(int err, struct crypto_wait *wait) BR, Jarkko -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH 17/17] crypto: api - Remove completion function scaffolding Date: Fri, 10 Feb 2023 02:56:34 +0200 Message-ID: References: Mime-Version: 1.0 Return-path: Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230507AbjBJA6a (ORCPT ); Thu, 9 Feb 2023 19:58:30 -0500 Content-Disposition: inline In-Reply-To: List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Herbert Xu Cc: Linux Crypto Mailing List , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, Tyler Hicks , ecryptfs@vger.kernel.org, Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , linux-bluetooth@vger.kernel.org, Steffen Klassert , Jon Maloy , Ying Xue , Boris Pismenny , John Fastabend , David Howells On Mon, Feb 06, 2023 at 06:22:46PM +0800, Herbert Xu wrote: > This patch removes the temporary scaffolding now that the comletion > function signature has been converted. > > Signed-off-by: Herbert Xu For the 1-17: Acked-by: Jarkko Sakkinen (nit applies tho to all of them but use your own judgement i guess) > --- > > include/linux/crypto.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/include/linux/crypto.h b/include/linux/crypto.h > index 80f6350fb588..bb1d9b0e1647 100644 > --- a/include/linux/crypto.h > +++ b/include/linux/crypto.h > @@ -176,7 +176,6 @@ struct crypto_async_request; > struct crypto_tfm; > struct crypto_type; > > -typedef void crypto_completion_data_t; > typedef void (*crypto_completion_t)(void *req, int err); > > /** > @@ -596,11 +595,6 @@ struct crypto_wait { > /* > * Async ops completion helper functioons > */ > -static inline void *crypto_get_completion_data(void *data) > -{ > - return data; > -} > - > void crypto_req_done(void *req, int err); > > static inline int crypto_wait_req(int err, struct crypto_wait *wait) BR, Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8BC6C05027 for ; Fri, 10 Feb 2023 00:58:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231280AbjBJA6m (ORCPT ); Thu, 9 Feb 2023 19:58:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230507AbjBJA6a (ORCPT ); Thu, 9 Feb 2023 19:58:30 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 366D26F21E; Thu, 9 Feb 2023 16:56:39 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E0409B82396; Fri, 10 Feb 2023 00:56:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12C5DC433D2; Fri, 10 Feb 2023 00:56:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675990596; bh=UTrvq3REz/kAUwMAFaCstHYw0tMPg3KnvPd0o9YJkLA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HV8CEHr46UOCKci7nGYdKPM/QYm9v/XyrqpLW8/mHRwM9AEk7A3DKLCityqv3U3oF T7F2DL12j2lN4buNSTjzMieLxmMx1wT3S+/4hV5m3pO2gw+peyj9mkpYnfEoJudvkm nZIAs0ycm1EmVMdd/I7WZIhIX8TdjfycB3Iq8yeQIFbZAK97h3Z93DSHedZ6fYeATD 5w8CojJysiR0LaUjw8zPH4dj5Elyj9bRvYnxsOjBRa0FHN8Ow0mg1Mev144pGARBDl z3g09QORCTaxPT82xqTNBPw5pYe3qq6352wXnK+JInqbg4D4R25CnHecGKr+dInt1V QMJyeuh6dN5EA== Date: Fri, 10 Feb 2023 02:56:34 +0200 From: Jarkko Sakkinen To: Herbert Xu Cc: Linux Crypto Mailing List , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, Tyler Hicks , ecryptfs@vger.kernel.org, Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , linux-bluetooth@vger.kernel.org, Steffen Klassert , Jon Maloy , Ying Xue , Boris Pismenny , John Fastabend , David Howells , keyrings@vger.kernel.org Subject: Re: [PATCH 17/17] crypto: api - Remove completion function scaffolding Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: keyrings@vger.kernel.org On Mon, Feb 06, 2023 at 06:22:46PM +0800, Herbert Xu wrote: > This patch removes the temporary scaffolding now that the comletion > function signature has been converted. > > Signed-off-by: Herbert Xu For the 1-17: Acked-by: Jarkko Sakkinen (nit applies tho to all of them but use your own judgement i guess) > --- > > include/linux/crypto.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/include/linux/crypto.h b/include/linux/crypto.h > index 80f6350fb588..bb1d9b0e1647 100644 > --- a/include/linux/crypto.h > +++ b/include/linux/crypto.h > @@ -176,7 +176,6 @@ struct crypto_async_request; > struct crypto_tfm; > struct crypto_type; > > -typedef void crypto_completion_data_t; > typedef void (*crypto_completion_t)(void *req, int err); > > /** > @@ -596,11 +595,6 @@ struct crypto_wait { > /* > * Async ops completion helper functioons > */ > -static inline void *crypto_get_completion_data(void *data) > -{ > - return data; > -} > - > void crypto_req_done(void *req, int err); > > static inline int crypto_wait_req(int err, struct crypto_wait *wait) BR, Jarkko