From: Jiri Pirko <jiri@resnulli.us>
To: Kim Phillips <kim.phillips@amd.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, davem@davemloft.net, pabeni@redhat.com,
edumazet@google.com, tariqt@nvidia.com, saeedm@nvidia.com,
jacob.e.keller@intel.com, gal@nvidia.com, moshe@nvidia.com
Subject: Re: [patch net-next 0/7] devlink: params cleanups and devl_param_driverinit_value_get() fix
Date: Fri, 10 Feb 2023 08:55:47 +0100 [thread overview]
Message-ID: <Y+X4gx1eARMJECVT@nanopsycho> (raw)
In-Reply-To: <34be65a9-a741-7e4e-c7f3-a80d3e660528@amd.com>
Thu, Feb 09, 2023 at 11:37:13PM CET, kim.phillips@amd.com wrote:
>On 2/9/23 3:31 PM, Jakub Kicinski wrote:
>> On Thu, 9 Feb 2023 15:05:46 -0600 Kim Phillips wrote:
>> > Is there a different tree the series can be rebased on, until net-next
>> > gets fixed?
>>
>> merge in net-next, the fix should be there but was merged a couple of
>> hours ago so probably not yet in linux-next
>
>I=Ok, I took next-20230209, git merged net-next/master, fixed a merge
>conflict to use the latter net-next/master version:
>
><<<<<<< HEAD
> if (err == NOTIFY_BAD) {
> dl_trap->trap.action = action_orig;
> err = trap_event_ctx.err;
> }
>out:
> return err;
>=======
> if (err == NOTIFY_BAD)
> dl_trap->trap.action = action_orig;
>
> return trap_event_ctx.err;
>>>>>>>> net-next/master
>
>...and unfortunately still get a splat on that same Rome system:
>
>[ 22.647832] mlx5_core 0000:21:00.0: firmware version: 14.22.1002
>[ 22.653879] mlx5_core 0000:21:00.0: 63.008 Gb/s available PCIe bandwidth (8.0 GT/s PCIe x8 link)
>[ 23.228950] mlx5_core 0000:21:00.0: E-Switch: Total vports 10, per vport: max uc(1024) max mc(16384)
>[ 23.245100] mlx5_core 0000:21:00.0: Port module event: module 0, Cable plugged
>[ 23.570053] mlx5_core 0000:21:00.0: Supported tc offload range - chains: 1, prios: 1
>[ 23.577812] mlx5_core 0000:21:00.0: mlx5e_tc_post_act_init:40:(pid 9): firmware level support is missing
>[ 23.594377] mlx5_core 0000:21:00.0: MLX5E: StrdRq(0) RqSz(1024) StrdSz(256) RxCqeCmprss(0 basic)
>[ 23.605492] mlx5_core 0000:21:00.1: firmware version: 14.22.1002
>[ 23.611536] mlx5_core 0000:21:00.1: 63.008 Gb/s available PCIe bandwidth (8.0 GT/s PCIe x8 link)
>[ 24.199756] mlx5_core 0000:21:00.1: E-Switch: Total vports 10, per vport: max uc(1024) max mc(16384)
>[ 24.216876] mlx5_core 0000:21:00.1: Port module event: module 1, Cable unplugged
>[ 24.555670] mlx5_core 0000:21:00.1: Supported tc offload range - chains: 1, prios: 1
>[ 24.563428] mlx5_core 0000:21:00.1: mlx5e_tc_post_act_init:40:(pid 9): firmware level support is missing
>[ 24.580084] mlx5_core 0000:21:00.1: MLX5E: StrdRq(0) RqSz(1024) StrdSz(256) RxCqeCmprss(0 basic)
>[ 24.593808] systemd-udevd[1974]: Using default interface naming scheme 'v245'.
>[ 24.602595] systemd-udevd[1974]: ethtool: autonegotiation is unset or enabled, the speed and duplex are not writable.
>[ 24.613314] mlx5_core 0000:21:00.0 enp33s0f0np0: renamed from eth0
>[ 24.701259] ------------[ cut here ]------------
>[ 24.705888] WARNING: CPU: 228 PID: 2318 at net/devlink/leftover.c:9643 devl_param_driverinit_value_get+0xe5/0x1f0
Odd as this patchset removes this warning. I think you forgot to apply.
>[ 24.716153] Modules linked in: mlx5_ib(+) ib_uverbs ib_core mlx5_core ast i2c_algo_bit drm_shmem_helper hid_generic drm_kms_helper syscopyarea sysfillrect sysimgblt usbhid pci_hyperv_intf crct10dif_pclmul crc32_pclmul ghash_clmulni_intel sha512_ssse3 aesni_intel crypto_simd cryptd mlxfw hid psample drm ahci tls libahci i2c_piix4 wmi
>[ 24.745589] CPU: 228 PID: 2318 Comm: systemd-udevd Not tainted 6.2.0-rc7-next-20230209+ #4
>[ 24.753856] Hardware name: AMD Corporation DAYTONA_X/DAYTONA_X, BIOS RDY1009A 09/16/2020
>[ 24.761943] RIP: 0010:devl_param_driverinit_value_get+0xe5/0x1f0
>[ 24.767955] Code: 00 5b b8 ea ff ff ff 41 5c 41 5d 5d e9 58 cd 08 00 48 8d bf 28 02 00 00 be ff ff ff ff e8 03 2a 07 00 85 c0 0f 85 43 ff ff ff <0f> 0b 49 8b 84 24 18 01 00 00 48 83 78 18 00 0f 85 41 ff ff ff 0f
>[ 24.786702] RSP: 0018:ffffc217dfff7a28 EFLAGS: 00010246
>[ 24.791925] RAX: 0000000000000000 RBX: 0000000000000009 RCX: 0000000000000000
>[ 24.799058] RDX: 0000000000000000 RSI: ffff9d7458b00228 RDI: ffff9d835f588d50
>[ 24.806194] RBP: ffffc217dfff7a40 R08: 0000000000000000 R09: ffff9d8316157c00
>[ 24.813325] R10: 0000000000000001 R11: 0000000000000000 R12: ffff9d7458b00000
>[ 24.820455] R13: ffffc217dfff7a50 R14: 0000000000000001 R15: 0000000000000002
>[ 24.827589] FS: 00007f03c4b0a880(0000) GS:ffff9d92c8c00000(0000) knlGS:0000000000000000
>[ 24.835677] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>[ 24.841422] CR2: 00007ffd0c160f48 CR3: 000080109f420000 CR4: 0000000000350ee0
>[ 24.848557] Call Trace:
>[ 24.851003] <TASK>
>[ 24.853117] mlx5_is_roce_on+0x3a/0xb0 [mlx5_core]
>[ 24.858010] ? __kmalloc+0x53/0x1b0
>[ 24.861512] mlx5r_probe+0x149/0x170 [mlx5_ib]
>[ 24.865974] ? __pfx_mlx5r_probe+0x10/0x10 [mlx5_ib]
>[ 24.870957] auxiliary_bus_probe+0x45/0xa0
>[ 24.875059] really_probe+0x17b/0x3e0
>[ 24.878731] __driver_probe_device+0x7e/0x180
>[ 24.883090] driver_probe_device+0x23/0x80
>[ 24.887191] __driver_attach+0xcb/0x1a0
>[ 24.891027] ? __pfx___driver_attach+0x10/0x10
>[ 24.895475] bus_for_each_dev+0x89/0xd0
>[ 24.899311] driver_attach+0x22/0x30
>[ 24.902894] bus_add_driver+0x1b9/0x240
>[ 24.906735] driver_register+0x66/0x130
>[ 24.910584] __auxiliary_driver_register+0x73/0xe0
>[ 24.915385] mlx5_ib_init+0xda/0x110 [mlx5_ib]
>[ 24.919846] ? __pfx_init_module+0x10/0x10 [mlx5_ib]
>[ 24.924831] do_one_initcall+0x7a/0x2b0
>[ 24.928677] ? kmalloc_trace+0x2e/0xe0
>[ 24.932433] do_init_module+0x6a/0x260
>[ 24.936191] load_module+0x1e90/0x2050
>[ 24.939942] ? ima_post_read_file+0xd6/0xf0
>[ 24.944138] __do_sys_finit_module+0xc8/0x140
>[ 24.948497] ? __do_sys_finit_module+0xc8/0x140
>[ 24.953036] __x64_sys_finit_module+0x1e/0x30
>[ 24.957399] do_syscall_64+0x3f/0x90
>[ 24.960987] entry_SYSCALL_64_after_hwframe+0x72/0xdc
>[ 24.966047] RIP: 0033:0x7f03c513673d
>[ 24.969628] Code: 00 c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 23 37 0d 00 f7 d8 64 89 01 48
>[ 24.988380] RSP: 002b:00007ffd0c1665f8 EFLAGS: 00000246 ORIG_RAX: 0000000000000139
>[ 24.995943] RAX: ffffffffffffffda RBX: 0000556e1aec4d30 RCX: 00007f03c513673d
>[ 25.003078] RDX: 0000000000000000 RSI: 00007f03c5016ded RDI: 000000000000000e
>[ 25.010210] RBP: 0000000000020000 R08: 0000000000000000 R09: 0000556e1ae664e8
>[ 25.017343] R10: 000000000000000e R11: 0000000000000246 R12: 00007f03c5016ded
>[ 25.024477] R13: 0000000000000000 R14: 0000556e1aeee320 R15: 0000556e1aec4d30
>[ 25.031621] </TASK>
>[ 25.033815] ---[ end trace 0000000000000000 ]---
>[ 25.072333] ------------[ cut here ]------------
>[ 25.076971] WARNING: CPU: 100 PID: 2318 at net/devlink/leftover.c:9643 devl_param_driverinit_value_get+0xe5/0x1f0
>[ 25.087406] Modules linked in: mlx5_ib(+) ib_uverbs ib_core mlx5_core ast i2c_algo_bit drm_shmem_helper hid_generic drm_kms_helper syscopyarea sysfillrect sysimgblt usbhid pci_hyperv_intf crct10dif_pclmul crc32_pclmul ghash_clmulni_intel sha512_ssse3 aesni_intel crypto_simd cryptd mlxfw hid psample drm ahci tls libahci i2c_piix4 wmi
>[ 25.116844] CPU: 100 PID: 2318 Comm: systemd-udevd Tainted: G W 6.2.0-rc7-next-20230209+ #4
>[ 25.126576] Hardware name: AMD Corporation DAYTONA_X/DAYTONA_X, BIOS RDY1009A 09/16/2020
>[ 25.134665] RIP: 0010:devl_param_driverinit_value_get+0xe5/0x1f0
>[ 25.140676] Code: 00 5b b8 ea ff ff ff 41 5c 41 5d 5d e9 58 cd 08 00 48 8d bf 28 02 00 00 be ff ff ff ff e8 03 2a 07 00 85 c0 0f 85 43 ff ff ff <0f> 0b 49 8b 84 24 18 01 00 00 48 83 78 18 00 0f 85 41 ff ff ff 0f
>[ 25.159421] RSP: 0018:ffffc217dfff7a28 EFLAGS: 00010246
>[ 25.164646] RAX: 0000000000000000 RBX: 0000000000000009 RCX: 0000000000000000
>[ 25.171779] RDX: 0000000000000000 RSI: ffff9d745c680228 RDI: ffff9d835f588d50
>[ 25.178910] RBP: ffffc217dfff7a40 R08: 0000000000000000 R09: ffff9d835e860400
>[ 25.186045] R10: 0000000000000001 R11: 0000000000000000 R12: ffff9d745c680000
>[ 25.193178] R13: ffffc217dfff7a50 R14: 0000000000000001 R15: 0000000000000002
>[ 25.200310] FS: 00007f03c4b0a880(0000) GS:ffff9d92b8c00000(0000) knlGS:0000000000000000
>[ 25.208395] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>[ 25.214141] CR2: 00007f03c520d52c CR3: 000080109f420000 CR4: 0000000000350ee0
>[ 25.221275] Call Trace:
>[ 25.223726] <TASK>
>[ 25.225831] mlx5_is_roce_on+0x3a/0xb0 [mlx5_core]
>[ 25.230678] ? __kmalloc+0x53/0x1b0
>[ 25.234172] mlx5r_probe+0x149/0x170 [mlx5_ib]
>[ 25.238641] ? __pfx_mlx5r_probe+0x10/0x10 [mlx5_ib]
>[ 25.243624] auxiliary_bus_probe+0x45/0xa0
>[ 25.247724] really_probe+0x17b/0x3e0
>[ 25.251393] __driver_probe_device+0x7e/0x180
>[ 25.255761] driver_probe_device+0x23/0x80
>[ 25.259868] __driver_attach+0xcb/0x1a0
>[ 25.263707] ? __pfx___driver_attach+0x10/0x10
>[ 25.268159] bus_for_each_dev+0x89/0xd0
>[ 25.272001] driver_attach+0x22/0x30
>[ 25.275577] bus_add_driver+0x1b9/0x240
>[ 25.279421] driver_register+0x66/0x130
>[ 25.283264] __auxiliary_driver_register+0x73/0xe0
>[ 25.288062] mlx5_ib_init+0xda/0x110 [mlx5_ib]
>[ 25.292519] ? __pfx_init_module+0x10/0x10 [mlx5_ib]
>[ 25.297496] do_one_initcall+0x7a/0x2b0
>[ 25.301337] ? kmalloc_trace+0x2e/0xe0
>[ 25.305088] do_init_module+0x6a/0x260
>[ 25.308841] load_module+0x1e90/0x2050
>[ 25.312595] ? ima_post_read_file+0xd6/0xf0
>[ 25.316797] __do_sys_finit_module+0xc8/0x140
>[ 25.321155] ? __do_sys_finit_module+0xc8/0x140
>[ 25.325696] __x64_sys_finit_module+0x1e/0x30
>[ 25.330057] do_syscall_64+0x3f/0x90
>[ 25.333635] entry_SYSCALL_64_after_hwframe+0x72/0xdc
>[ 25.338687] RIP: 0033:0x7f03c513673d
>[ 25.342266] Code: 00 c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 23 37 0d 00 f7 d8 64 89 01 48
>[ 25.361015] RSP: 002b:00007ffd0c1665f8 EFLAGS: 00000246 ORIG_RAX: 0000000000000139
>[ 25.368579] RAX: ffffffffffffffda RBX: 0000556e1aec4d30 RCX: 00007f03c513673d
>[ 25.375713] RDX: 0000000000000000 RSI: 00007f03c5016ded RDI: 000000000000000e
>[ 25.382843] RBP: 0000000000020000 R08: 0000000000000000 R09: 0000556e1ae664e8
>[ 25.389976] R10: 000000000000000e R11: 0000000000000246 R12: 00007f03c5016ded
>[ 25.397109] R13: 0000000000000000 R14: 0000556e1aeee320 R15: 0000556e1aec4d30
>[ 25.404249] </TASK>
>[ 25.406437] ---[ end trace 0000000000000000 ]---
>
>Did I do the merge wrong, or is the problem still there?
>
>Thanks,
>
>Kim
next prev parent reply other threads:[~2023-02-10 7:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 15:43 [patch net-next 0/7] devlink: params cleanups and devl_param_driverinit_value_get() fix Jiri Pirko
2023-02-09 15:43 ` [patch net-next 1/7] devlink: don't use strcpy() to copy param value Jiri Pirko
2023-02-09 16:39 ` Simon Horman
2023-02-09 15:43 ` [patch net-next 2/7] devlink: make sure driver does not read updated driverinit param before reload Jiri Pirko
2023-02-09 16:42 ` Simon Horman
2023-02-09 15:43 ` [patch net-next 3/7] devlink: fix the name of value arg of devl_param_driverinit_value_get() Jiri Pirko
2023-02-09 16:43 ` Simon Horman
2023-02-09 15:43 ` [patch net-next 4/7] devlink: use xa_for_each_start() helper in devlink_nl_cmd_port_get_dump_one() Jiri Pirko
2023-02-09 16:43 ` Simon Horman
2023-02-09 15:43 ` [patch net-next 5/7] devlink: convert param list to xarray Jiri Pirko
2023-02-09 16:45 ` Simon Horman
2023-02-10 7:53 ` Jiri Pirko
2023-02-10 8:51 ` Simon Horman
2023-02-09 15:43 ` [patch net-next 6/7] devlink: allow to call devl_param_driverinit_value_get() without holding instance lock Jiri Pirko
2023-02-09 16:46 ` Simon Horman
2023-02-09 15:43 ` [patch net-next 7/7] devlink: add forgotten devlink instance lock assertion to devl_param_driverinit_value_set() Jiri Pirko
2023-02-09 16:47 ` Simon Horman
2023-02-09 21:05 ` [patch net-next 0/7] devlink: params cleanups and devl_param_driverinit_value_get() fix Kim Phillips
2023-02-09 21:31 ` Jakub Kicinski
2023-02-09 22:37 ` Kim Phillips
2023-02-10 0:16 ` Jakub Kicinski
2023-02-10 7:55 ` Jiri Pirko [this message]
2023-02-10 4:53 ` Jakub Kicinski
2023-02-10 7:56 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+X4gx1eARMJECVT@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=jacob.e.keller@intel.com \
--cc=kim.phillips@amd.com \
--cc=kuba@kernel.org \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.