All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Yosry Ahmed <yosryahmed@google.com>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
	Minchan Kim <minchan@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 2/2] zsmalloc: fine-grained inuse ratio based fullness grouping
Date: Fri, 10 Feb 2023 13:29:59 +0900	[thread overview]
Message-ID: <Y+XIR64RyVv0EfTx@google.com> (raw)
In-Reply-To: <CAJD7tka3s84v9-ZA-OZkBkina6MByCSFnKXwv+hq8o8nZSZoyg@mail.gmail.com>

On (23/02/09 20:25), Yosry Ahmed wrote:
> > On (23/02/07 10:47), Sergey Senozhatsky wrote:
[..]
> > Forgot to mention, I was also thinking about extending zsmalloc stats
> > file and providing values for each fullness group per class, as opposed
> > to current ALMOST_EMPTY and ALMOST_FULL stats, which don't tell much.
> 
> Makes sense.
> 
> >
> > I can get rid of static const arrays and pass "begin / end" group IDs to
> > functions that iterate fullness lists and pick the first head page, but
> > I think that enum values will stay.
> 
> Do they have to stay for a technical reason or just to make reviews simpler?

We need to be able to do zs_stat_get(class, CLASS_USAGE_70) or
zs_stat_get(class, CLASS_USAGE_10) in zs_stats_size_show() to
show class's fullness stats.


  reply	other threads:[~2023-02-10  4:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-06  9:25 [PATCH 0/2] zsmalloc: fine-grained fullness grouping Sergey Senozhatsky
2023-02-06  9:25 ` [PATCH 1/2] zsmalloc: remove insert_zspage() ->inuse optimization Sergey Senozhatsky
2023-02-06  9:25 ` [PATCH 2/2] zsmalloc: fine-grained inuse ratio based fullness grouping Sergey Senozhatsky
2023-02-07  1:02   ` Yosry Ahmed
2023-02-07  1:47     ` Sergey Senozhatsky
2023-02-10  4:24       ` Sergey Senozhatsky
2023-02-10  4:25         ` Yosry Ahmed
2023-02-10  4:29           ` Sergey Senozhatsky [this message]
2023-02-10  5:15             ` Yosry Ahmed
2023-02-10  5:47               ` Sergey Senozhatsky
2023-02-10  5:52               ` Sergey Senozhatsky
2023-02-10  6:04                 ` Yosry Ahmed
2023-02-10  6:07                   ` Yosry Ahmed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y+XIR64RyVv0EfTx@google.com \
    --to=senozhatsky@chromium.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=yosryahmed@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.