From: Martin Habets <habetsm.xilinx@gmail.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, ast@kernel.org,
daniel@iogearbox.net, andrii@kernel.org, davem@davemloft.net,
kuba@kernel.org, pabeni@redhat.com, edumazet@google.com,
lorenzo.bianconi@redhat.com, ecree.xilinx@gmail.com
Subject: Re: [PATCH bpf-next] sfc: move xdp_features configuration in efx_pci_probe_post_io()
Date: Fri, 10 Feb 2023 08:55:00 +0000 [thread overview]
Message-ID: <Y+YGZLdd6/WmY6s7@gmail.com> (raw)
In-Reply-To: <9bd31c9a29bcf406ab90a249a28fc328e5578fd1.1675875404.git.lorenzo@kernel.org>
Many thanks Lorenzo. It got applied in record time!
Martin
On Wed, Feb 08, 2023 at 05:58:40PM +0100, Lorenzo Bianconi wrote:
> Move xdp_features configuration from efx_pci_probe() to
> efx_pci_probe_post_io() since it is where all the other basic netdev
> features are initialised.
>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
> drivers/net/ethernet/sfc/efx.c | 8 ++++----
> drivers/net/ethernet/sfc/siena/efx.c | 8 ++++----
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
> index 18ff8d8cff42..9569c3356b4a 100644
> --- a/drivers/net/ethernet/sfc/efx.c
> +++ b/drivers/net/ethernet/sfc/efx.c
> @@ -1025,6 +1025,10 @@ static int efx_pci_probe_post_io(struct efx_nic *efx)
> net_dev->features &= ~NETIF_F_HW_VLAN_CTAG_FILTER;
> net_dev->features |= efx->fixed_features;
>
> + net_dev->xdp_features = NETDEV_XDP_ACT_BASIC |
> + NETDEV_XDP_ACT_REDIRECT |
> + NETDEV_XDP_ACT_NDO_XMIT;
> +
> rc = efx_register_netdev(efx);
> if (!rc)
> return 0;
> @@ -1078,10 +1082,6 @@ static int efx_pci_probe(struct pci_dev *pci_dev,
>
> pci_info(pci_dev, "Solarflare NIC detected\n");
>
> - efx->net_dev->xdp_features = NETDEV_XDP_ACT_BASIC |
> - NETDEV_XDP_ACT_REDIRECT |
> - NETDEV_XDP_ACT_NDO_XMIT;
> -
> if (!efx->type->is_vf)
> efx_probe_vpd_strings(efx);
>
> diff --git a/drivers/net/ethernet/sfc/siena/efx.c b/drivers/net/ethernet/sfc/siena/efx.c
> index a6ef21845224..ef52ec71d197 100644
> --- a/drivers/net/ethernet/sfc/siena/efx.c
> +++ b/drivers/net/ethernet/sfc/siena/efx.c
> @@ -1007,6 +1007,10 @@ static int efx_pci_probe_post_io(struct efx_nic *efx)
> net_dev->features &= ~NETIF_F_HW_VLAN_CTAG_FILTER;
> net_dev->features |= efx->fixed_features;
>
> + net_dev->xdp_features = NETDEV_XDP_ACT_BASIC |
> + NETDEV_XDP_ACT_REDIRECT |
> + NETDEV_XDP_ACT_NDO_XMIT;
> +
> rc = efx_register_netdev(efx);
> if (!rc)
> return 0;
> @@ -1048,10 +1052,6 @@ static int efx_pci_probe(struct pci_dev *pci_dev,
>
> pci_info(pci_dev, "Solarflare NIC detected\n");
>
> - efx->net_dev->xdp_features = NETDEV_XDP_ACT_BASIC |
> - NETDEV_XDP_ACT_REDIRECT |
> - NETDEV_XDP_ACT_NDO_XMIT;
> -
> if (!efx->type->is_vf)
> efx_probe_vpd_strings(efx);
>
> --
> 2.39.1
prev parent reply other threads:[~2023-02-10 8:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 16:58 [PATCH bpf-next] sfc: move xdp_features configuration in efx_pci_probe_post_io() Lorenzo Bianconi
2023-02-08 18:40 ` patchwork-bot+netdevbpf
2023-02-10 8:55 ` Martin Habets [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+YGZLdd6/WmY6s7@gmail.com \
--to=habetsm.xilinx@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.