All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Keeping <john@metanate.com>
To: Peter Korsgaard <peter@korsgaard.com>
Cc: Adrian Perez de Castro <aperez@igalia.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/webkitgtk: Build with ninja
Date: Fri, 10 Feb 2023 11:17:33 +0000	[thread overview]
Message-ID: <Y+YnzeeSbedxW3eK@donbot> (raw)
In-Reply-To: <20230209170707.4066903-1-peter@korsgaard.com>

Hi Peter,

On Thu, Feb 09, 2023 at 06:07:05PM +0100, Peter Korsgaard wrote:
> +define WEBKITGTK_BUILD_CMDS
> +	$(TARGET_MAKE_ENV) $(BR2_CMAKE) --build $(WEBKITGTK_BUILDDIR)
> +endef
> +
> +define WEBKITGTK_INSTALL_STAGING_CMDS
> +	$(TARGET_MAKE_ENV) DESTDIR=$(STAGING_DIR) $(BR2_CMAKE) --install $(WEBKITGTK_BUILDDIR)
> +endef
> +
> +define WEBKITGTK_INSTALL_TARGET_CMDS
> +	$(TARGET_MAKE_ENV) DESTDIR=$(TARGET_DIR) $(BR2_CMAKE) --install $(WEBKITGTK_BUILDDIR)
> +endef
> +

Would it make sense to apply these changes in pkg-cmake.mk?

Using `cmake --build` and `cmake --install` works with all generators
and it would avoid needing to repeat this block for both of the packages
in this series.


Regards,
John
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2023-02-10 11:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-09 17:07 [Buildroot] [PATCH 1/2] package/webkitgtk: Build with ninja Peter Korsgaard
2023-02-09 17:07 ` [Buildroot] [PATCH 2/2] package/wpewebkit: " Peter Korsgaard
2023-02-10 15:27   ` Peter Korsgaard
2023-02-28 20:10   ` Peter Korsgaard
2023-02-10 11:17 ` John Keeping [this message]
2023-02-10 11:45   ` [Buildroot] [PATCH 1/2] package/webkitgtk: " Peter Korsgaard
2023-02-10 18:46     ` John Keeping
2023-02-10 15:27 ` Peter Korsgaard
2023-02-28 20:10 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y+YnzeeSbedxW3eK@donbot \
    --to=john@metanate.com \
    --cc=aperez@igalia.com \
    --cc=buildroot@buildroot.org \
    --cc=peter@korsgaard.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.