From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v4] Refactor pidns30 test using new LTP API
Date: Fri, 10 Feb 2023 14:16:06 +0100 [thread overview]
Message-ID: <Y+ZDlj7gSCgdWFC1@yuki> (raw)
In-Reply-To: <20230208091120.9994-1-andrea.cervesato@suse.com>
Hi!
> +static void run(void)
> {
> - int status;
> - char buf[5];
> - pid_t cpid;
> + const struct tst_clone_args args = { CLONE_NEWPID, SIGCHLD };
>
> - setup();
> + remove_mqueue(mqd);
> + received = 0;
I wonder if we really need to clear the flag here, as far as I can see
we only modify that variable in the child process and that shouldn't
propagate to parent, unless we pass CLONE_VM of course.
Other than this it looks really good:
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-02-10 13:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 9:11 [LTP] [PATCH v4] Refactor pidns30 test using new LTP API Andrea Cervesato via ltp
2023-02-10 13:16 ` Cyril Hrubis [this message]
2023-02-10 14:18 ` Andrea Cervesato via ltp
2023-02-14 9:47 ` Richard Palethorpe
2023-02-14 12:17 ` Andrea Cervesato via ltp
2023-02-14 12:07 ` Cyril Hrubis
2023-02-14 12:27 ` Richard Palethorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+ZDlj7gSCgdWFC1@yuki \
--to=chrubis@suse.cz \
--cc=andrea.cervesato@suse.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.