From: Vinod Koul <vkoul@kernel.org>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Arnd Bergmann <arnd@kernel.org>,
Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
Serge Semin <Sergey.Semin@baikalelectronics.ru>,
Arnd Bergmann <arnd@arndb.de>,
Manivannan Sadhasivam <mani@kernel.org>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Frank Li <Frank.Li@nxp.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2] dmaengine: dw-edma: reduce stack usage after debugfs rework
Date: Fri, 10 Feb 2023 20:55:16 +0530 [thread overview]
Message-ID: <Y+Zh3KOE3m1TdpG5@matsya> (raw)
In-Reply-To: <20230210123525.cphmtcf7pmfj67os@mobilestation.baikal.int>
On 10-02-23, 15:35, Serge Semin wrote:
> Hello Vinod
>
> On Fri, Feb 10, 2023 at 02:22:28PM +0530, Vinod Koul wrote:
> > On 30-01-23, 19:50, Arnd Bergmann wrote:
> > > From: Arnd Bergmann <arnd@arndb.de>
> > >
> > > After the dw_edma_debugfs_entry arrays are no longer compile-time
> > > constant, they take up space on the stack, which exceeds the warning
> > > limit after inlining:
> > >
> > > drivers/dma/dw-edma/dw-edma-v0-debugfs.c:280:6: error: stack frame size (1784) exceeds limit (1400) in 'dw_edma_v0_debugfs_on' [-Werror,-Wframe-larger-than]
> > > void dw_edma_v0_debugfs_on(struct dw_edma *dw)
> > >
> > > Work around this by preventing dw_edma_debugfs_regs_{wr,rd} from both
> > > being inlined together, which cuts the stack frame size in half and
> > > makes it fit below the warning limit.
> > >
> > > Fixes: 5c0373eafd83 ("dmaengine: dw-edma: Move eDMA data pointer to debugfs node descriptor")
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > > ---
> > > v2: rebase on top of dmaengine tree
> >
> > I dont have 5c0373eafd83 in my tree, I guess that went thru PCI tree, so
> > I am going to defer this after merge window
>
> It's in the @Bjorn tree now
> https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/commit/?h=pci/ctrl/dwc&id=5c0373eafd8334343da22338d8588ed61e8daba0
>
> If you are ok with the fix then @Bjorn could take the patch in to his
> repo. Right, @Bjorn?
Sure:
Acked-by: Vinod Koul <vkoul@kernel.org>
--
~Vinod
next prev parent reply other threads:[~2023-02-10 15:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 18:50 [PATCH] [v2] dmaengine: dw-edma: reduce stack usage after debugfs rework Arnd Bergmann
2023-01-31 6:42 ` Manivannan Sadhasivam
2023-01-31 7:54 ` Serge Semin
2023-02-10 8:52 ` Vinod Koul
2023-02-10 12:35 ` Serge Semin
2023-02-10 15:25 ` Vinod Koul [this message]
2023-02-10 23:29 ` Bjorn Helgaas
2023-02-12 19:23 ` Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+Zh3KOE3m1TdpG5@matsya \
--to=vkoul@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bhelgaas@google.com \
--cc=dmaengine@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.