From: Peter Xu <peterx@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: BALATON Zoltan <balaton@eik.bme.hu>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
David Hildenbrand <david@redhat.com>,
philmd@linaro.org,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PATCH 1/2] log: Add separate debug option for logging invalid memory accesses
Date: Mon, 13 Feb 2023 09:45:12 -0500 [thread overview]
Message-ID: <Y+pM+H1PvTUUHrhx@x1n> (raw)
In-Reply-To: <fcd09b07-c0ac-d617-8503-a5ecef947cfe@redhat.com>
On Mon, Feb 13, 2023 at 12:41:29PM +0100, Thomas Huth wrote:
> On 07/02/2023 17.33, BALATON Zoltan wrote:
> > On Tue, 31 Jan 2023, BALATON Zoltan wrote:
> > > On Thu, 19 Jan 2023, BALATON Zoltan wrote:
> > > > Currently -d guest_errors enables logging of different invalid actions
> > > > by the guest such as misusing hardware, accessing missing features or
> > > > invalid memory areas. The memory access logging can be quite verbose
> > > > which obscures the other messages enabled by this debug switch so
> > > > separate it by adding a new -d memaccess option to make it possible to
> > > > control it independently of other guest error logs.
> > > >
> > > > Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> > >
> > > Ping? Could somebody review and pick it up please?
> >
> > Ping?
>
> Patch makes sense to me and looks fine, so:
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
> ... I think this should go via one of the "Memory API" maintainers branches?
> Paolo? Peter? David?
Paolo normally does the pull, I assume that'll still be the case. The
patch looks good to me if Phil's comment will be addressed on merging with
the old mask, which makes sense to me:
Acked-by: Peter Xu <peterx@redhat.com>
Thanks,
--
Peter Xu
next prev parent reply other threads:[~2023-02-13 14:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 21:40 [PATCH 1/2] log: Add separate debug option for logging invalid memory accesses BALATON Zoltan
2023-01-31 14:28 ` BALATON Zoltan
2023-02-07 16:33 ` BALATON Zoltan
2023-02-13 11:41 ` Thomas Huth
2023-02-13 14:45 ` Peter Xu [this message]
2023-02-13 14:47 ` BALATON Zoltan
2023-02-13 14:58 ` Philippe Mathieu-Daudé
2023-02-13 15:09 ` Philippe Mathieu-Daudé
2023-02-13 16:36 ` BALATON Zoltan
2023-02-13 16:20 ` BALATON Zoltan
2023-02-13 16:15 ` Peter Xu
2023-02-13 16:34 ` BALATON Zoltan
2023-02-13 17:17 ` Peter Xu
2023-02-13 17:26 ` Philippe Mathieu-Daudé
2023-02-13 18:34 ` BALATON Zoltan
2023-02-13 21:25 ` Peter Xu
2023-02-13 22:43 ` BALATON Zoltan
2023-02-28 22:19 ` BALATON Zoltan
2023-02-13 13:45 ` Philippe Mathieu-Daudé
2023-02-13 14:32 ` BALATON Zoltan
-- strict thread matches above, loose matches on Subject: below --
2024-10-06 16:49 [PATCH 0/2] Separate memory access logs from guest_errors BALATON Zoltan
2024-10-06 16:49 ` [PATCH 1/2] log: Add separate debug option for logging invalid memory accesses BALATON Zoltan
2024-10-14 14:13 ` Peter Maydell
2024-10-14 16:48 ` BALATON Zoltan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+pM+H1PvTUUHrhx@x1n \
--to=peterx@redhat.com \
--cc=balaton@eik.bme.hu \
--cc=david@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.