From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE919C636D4 for ; Mon, 13 Feb 2023 16:18:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7F4ED10E611; Mon, 13 Feb 2023 16:18:38 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1627710E611 for ; Mon, 13 Feb 2023 16:18:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676305116; x=1707841116; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=ceUxmfLcCHtbv1Kx7eETjGOgd7/wJLkJxVkXluiSQfw=; b=iu10KCVqedOuZ3XkL8hQYRktDlj//LxtkcIcqeUHzAn0FCe0kJy1zJIb HnaLQZ6L8jZGoabVAbNzqC7eeCv3WoZQbT14lX15B7fD1ymnxdW4FHXaj IOgJBaIswxaC12zleOShmC+hHNVlCcCZbXRZJ37/To6k/57221kxDQxCQ eXLNMVy7PVShhTneRWKP6bJGkZqAE5UlYdXyXsPGN/8yKlqYqxqro8Ep9 bIJXilACdQH8TRLPjB0cijRlA8bSnaxXnj51LwP9mgk4NWO/nB1WWR0K7 sTMe8y3YDG33rCs2WdtTG+49PIE0aLQzQGURm4ZQDdCQAzDaVTfLiksUu A==; X-IronPort-AV: E=McAfee;i="6500,9779,10620"; a="358333113" X-IronPort-AV: E=Sophos;i="5.97,294,1669104000"; d="scan'208";a="358333113" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2023 08:17:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10620"; a="997740822" X-IronPort-AV: E=Sophos;i="5.97,294,1669104000"; d="scan'208";a="997740822" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.55]) by fmsmga005.fm.intel.com with SMTP; 13 Feb 2023 08:17:39 -0800 Received: by stinkbox (sSMTP sendmail emulation); Mon, 13 Feb 2023 18:17:39 +0200 Date: Mon, 13 Feb 2023 18:17:39 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Jani Nikula Message-ID: References: <20230208015508.24824-1-ville.syrjala@linux.intel.com> <20230208015508.24824-10-ville.syrjala@linux.intel.com> <87mt5hv97x.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87mt5hv97x.fsf@intel.com> X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [PATCH 09/10] drm/i915: Iterate all child devs in intel_bios_is_port_present() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Feb 13, 2023 at 06:08:50PM +0200, Jani Nikula wrote: > On Wed, 08 Feb 2023, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Instead of consulting vbt.ports[] lets just go through the > > whole child device list to check whether a specific port > > was declared by the VBT or not. > > Might want to mention that this does not impact the dupe checking even > if we look at display_devices instead of vbt.ports[]. Hmm, except for the !is_port_valid() check. Should we maybe do that here too, or should we just think about fully exorcising invalid ports from the child device list? > > > > > Signed-off-by: Ville Syrjälä > > --- > > drivers/gpu/drm/i915/display/intel_bios.c | 11 ++++++++++- > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c > > index efe33af2259b..1af175b48ae6 100644 > > --- a/drivers/gpu/drm/i915/display/intel_bios.c > > +++ b/drivers/gpu/drm/i915/display/intel_bios.c > > @@ -3398,10 +3398,19 @@ bool intel_bios_is_lvds_present(struct drm_i915_private *i915, u8 *i2c_pin) > > */ > > bool intel_bios_is_port_present(struct drm_i915_private *i915, enum port port) > > { > > + const struct intel_bios_encoder_data *devdata; > > + > > if (WARN_ON(!has_ddi_port_info(i915))) > > return true; > > > > - return i915->display.vbt.ports[port]; > > + list_for_each_entry(devdata, &i915->display.vbt.display_devices, node) { > > + const struct child_device_config *child = &devdata->child; > > + > > + if (dvo_port_to_port(i915, child->dvo_port) == port) > > + return true; > > + } > > + > > + return false; > > } > > > > /** > > -- > Jani Nikula, Intel Open Source Graphics Center -- Ville Syrjälä Intel