From: Keith Busch <kbusch@kernel.org>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Christoph Hellwig <hch@infradead.org>,
Ming Lei <ming.lei@redhat.com>,
John Meneghini <jmeneghi@redhat.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: nvme/pcie hot plug results in /dev name change
Date: Mon, 13 Feb 2023 09:32:35 -0700 [thread overview]
Message-ID: <Y+pmI52Ahfn/hF6m@kbusch-mbp> (raw)
In-Reply-To: <2205fb9d-f887-dedc-04c1-06190dc51413@grimberg.me>
On Mon, Feb 13, 2023 at 04:01:03PM +0200, Sagi Grimberg wrote:
> > Also not sure if this is going to work out, but it looks like a good start to
> > me.
> >
> > Instead of user pinning the virtual device so that it never goes away though, I
> > considered a user tunable "device missing delay" parameter to debounce link
> > events. New IOs would be deferred to the requeue_list while the timer is
> > active, and then EIO'ed if the timer expires without a successful LIVE
> > controller attachment. The use cases I'm considering are short bounces from
> > transient link resets, so I'd expect timers to be from a few seconds to maybe a
> > minute.
>
> Isn't this equivalent to dm-mpath queue_if_no_path or no_path_timeout ?
Similiar, but generic to non-multipath devices.
> We can keep the mpath device around, but if not, what is the desired
> behavior from the upper layers?
I don't think we're looking for any behavioral changes in the upper layers.
next prev parent reply other threads:[~2023-02-13 16:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 19:50 nvme/pcie hot plug results in /dev name change John Meneghini
2023-01-20 21:42 ` Keith Busch
2023-01-21 7:01 ` Christoph Hellwig
2023-01-29 10:28 ` Ming Lei
2023-01-31 16:38 ` Keith Busch
2023-02-01 2:33 ` Ming Lei
2023-02-01 6:27 ` Christoph Hellwig
2023-02-01 16:31 ` Keith Busch
2023-02-13 14:01 ` Sagi Grimberg
2023-02-13 16:32 ` Keith Busch [this message]
2023-02-14 0:04 ` Ming Lei
2023-02-14 9:18 ` Sagi Grimberg
2023-02-15 1:04 ` Ming Lei
2023-02-14 16:17 ` Keith Busch
2023-02-15 1:11 ` Ming Lei
2023-02-14 9:04 ` Sagi Grimberg
2023-02-15 6:18 ` Christoph Hellwig
2023-02-15 8:56 ` Sagi Grimberg
2023-02-15 22:18 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+pmI52Ahfn/hF6m@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=hch@infradead.org \
--cc=jmeneghi@redhat.com \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.