From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Eric Curtin <ecurtin@redhat.com>
Cc: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin Rodriguez Reboredo <yakoyoku@gmail.com>,
linux-kernel@vger.kernel.org, Neal Gompa <neal@gompa.dev>,
bpf@vger.kernel.org, rust-for-linux@vger.kernel.org,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Yonghong Song <yhs@fb.com>
Subject: Re: pahole issues with Rust DWARF was: Re: [PATCH 1/1] pahole/Rust: Check that we're adding DW_TAG_member sorted by byte offset
Date: Mon, 13 Feb 2023 18:53:46 -0300 [thread overview]
Message-ID: <Y+qxas4DsaO8nUze@kernel.org> (raw)
In-Reply-To: <CAOgh=FzBjR7V+sQOy2OEV+YXxB0_YzapNTO+-Xf3uGnLfA0Vxw@mail.gmail.com>
Em Mon, Feb 13, 2023 at 12:53:38PM +0000, Eric Curtin escreveu:
> On Mon, 13 Feb 2023 at 12:45, Miguel Ojeda
> <miguel.ojeda.sandonis@gmail.com> wrote:
> >
> > Hi Arnaldo,
> >
> > On Mon, Feb 13, 2023 at 1:09 PM Arnaldo Carvalho de Melo
> > <arnaldo.melo@gmail.com> wrote:
> > >
> > > The namespace.o seems to be ok:
> >
> > I saw the other message too -- this looks great, thanks a ton.
> >
> > > The core one needs work:
> >
> > If `core.o` works, then I think it is likely other things will work :)
>
> Hi Guys,
>
> I'll leave this to the experts, but if we get this to the point where
> we are happy to enable again for Rust CUs, could we request another
> version bump? It just makes it easier to integrate with the kernel
Sure, as we improve the support for encoding BTF from DWARF generated
for Rust code, and the subset that is used in the kernel is handled, we
will just adjust scripts/pahole-flags.sh to skip Rust DWARF if the
version is >= the version where excluding DWARF generated from some
languages (Rust in this case) but < the version where we're confortable
with generating BTF for Rust DWARF.
- Arnaldo
> scripts when we want to enable again.
>
> >
> > I can try to extract the cases for those into simpler `.o` files, if
> > you would find simpler test cases useful (perhaps for the test suite
> > etc.).
> >
> > Cheers,
> > Miguel
> >
>
--
- Arnaldo
next prev parent reply other threads:[~2023-02-13 21:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 15:20 [PATCH v3] scripts: Exclude Rust CUs with pahole Martin Rodriguez Reboredo
2023-01-11 15:22 ` Eric Curtin
2023-01-11 15:34 ` Neal Gompa
2023-01-11 16:16 ` Eric Curtin
2023-01-11 16:21 ` Neal Gompa
2023-01-16 16:37 ` Daniel Borkmann
2023-01-16 16:52 ` Miguel Ojeda
2023-01-16 17:06 ` Daniel Borkmann
2023-01-16 17:19 ` Miguel Ojeda
2023-02-10 20:48 ` [PATCH 1/1] pahole/Rust: Check that we're adding DW_TAG_member sorted by byte offset Arnaldo Carvalho de Melo
2023-02-13 12:09 ` pahole issues with Rust DWARF was: " Arnaldo Carvalho de Melo
2023-02-13 12:45 ` Miguel Ojeda
2023-02-13 12:53 ` Eric Curtin
2023-02-13 21:53 ` Arnaldo Carvalho de Melo [this message]
2023-02-13 21:05 ` Arnaldo Carvalho de Melo
2023-02-14 21:22 ` Arnaldo Carvalho de Melo
2023-01-16 19:22 ` [PATCH v3] scripts: Exclude Rust CUs with pahole Arnaldo Carvalho de Melo
2023-01-17 16:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+qxas4DsaO8nUze@kernel.org \
--to=acme@kernel.org \
--cc=andrii@kernel.org \
--cc=arnaldo.melo@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=ecurtin@redhat.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=neal@gompa.dev \
--cc=rust-for-linux@vger.kernel.org \
--cc=yakoyoku@gmail.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.