From: Mike Kravetz <mike.kravetz@oracle.com>
To: Michal Hocko <mhocko@suse.com>, Matthew Wilcox <willy@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Naoya Horiguchi <naoya.horiguchi@linux.dev>,
James Houghton <jthoughton@google.com>,
Peter Xu <peterx@redhat.com>, Yang Shi <shy828301@gmail.com>,
Vishal Moola <vishal.moola@gmail.com>,
Muchun Song <songmuchun@bytedance.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/2] mm: hugetlb: proc: check for hugetlb shared PMD in /proc/PID/smaps
Date: Mon, 13 Feb 2023 17:40:05 -0800 [thread overview]
Message-ID: <Y+rmdQ7wd3wgvxEt@monkey> (raw)
In-Reply-To: <Y+p6+AKN7jY2jzJN@dhcp22.suse.cz>
On 02/13/23 19:01, Michal Hocko wrote:
> On Fri 03-02-23 12:16:04, Mike Kravetz wrote:
> [...]
> > Unless someone thinks we should move forward, I will not push the code
> > for this approach now. It will also be interesting to see if this is
> > impacted at all by the outcome of discussions to perhaps redesign
> > mapcount.
>
> Yes, I do agree. We might want to extend page_mapcount documentation a
> bit though. The comment is explicit about the order-0 pages but a note
> about hugetlb and pmd sharing wouldn't hurt. WDYT?
Looks like that comment about 'Mapcount of 0-order page' has been removed in
the latest version of page_mapcount(). It would not surprise me if the calls
to page_mapcount after which we check for shared PMDs will soon be replaced
with calls to folio_mapcount().
Perhaps Matthew has an opinion as to where map counts for hugetlb shared
PMDs might be mentioned.
--
Mike Kravetz
next prev parent reply other threads:[~2023-02-14 1:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 22:27 [PATCH 0/2] Fixes for hugetlb mapcount at most 1 for shared PMDs Mike Kravetz
2023-01-26 22:27 ` [PATCH 1/2] mm: hugetlb: proc: check for hugetlb shared PMD in /proc/PID/smaps Mike Kravetz
2023-01-27 16:23 ` David Hildenbrand
2023-01-27 23:04 ` Andrew Morton
2023-01-28 1:12 ` Mike Kravetz
2023-01-30 12:36 ` Michal Hocko
2023-01-30 22:08 ` Mike Kravetz
2023-02-01 7:47 ` Michal Hocko
2023-02-01 21:05 ` Mike Kravetz
2023-02-03 13:40 ` Michal Hocko
2023-02-03 20:16 ` Mike Kravetz
2023-02-13 18:01 ` Michal Hocko
2023-02-14 1:40 ` Mike Kravetz [this message]
2023-01-26 22:27 ` [PATCH 2/2] migrate: hugetlb: Check for hugetlb shared PMD in node migration Mike Kravetz
2023-01-27 16:23 ` David Hildenbrand
2023-01-26 22:47 ` [PATCH 0/2] Fixes for hugetlb mapcount at most 1 for shared PMDs Andrew Morton
2023-01-26 22:48 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+rmdQ7wd3wgvxEt@monkey \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=jthoughton@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=naoya.horiguchi@linux.dev \
--cc=peterx@redhat.com \
--cc=shy828301@gmail.com \
--cc=songmuchun@bytedance.com \
--cc=stable@vger.kernel.org \
--cc=vishal.moola@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.