From: Dan Carpenter <error27@gmail.com>
To: Jacob Bai <jacob.bai.au@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: pi433: change (struct pi433_tx_cfg)->bit_rate to be a u32
Date: Tue, 14 Feb 2023 11:25:35 +0300 [thread overview]
Message-ID: <Y+tFf3dFR812iVbj@kadam> (raw)
In-Reply-To: <Y+srSuTdGmzmXG1I@jacob-Ubuntu>
On Tue, Feb 14, 2023 at 05:33:46PM +1100, Jacob Bai wrote:
> Based on the TODO file and datasheet of pi433, the maximum bit rate for
> transmitter is 300kbps when modulation been set to FSK. Hence, the size
> should be u32 rather than u16.
>
> Signed-off-by: Jacob Bai <jacob.bai.au@gmail.com>
> ---
This breaks the user space API.
The TODO was updated recently to explain how to do this properly.
regards,
dan carpenter
prev parent reply other threads:[~2023-02-14 8:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 6:33 [PATCH] staging: pi433: change (struct pi433_tx_cfg)->bit_rate to be a u32 Jacob Bai
2023-02-14 7:58 ` Deepak R Varma
2023-02-14 9:24 ` Jacob Bai
2023-02-14 8:25 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+tFf3dFR812iVbj@kadam \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jacob.bai.au@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.