From: Greg KH <gregkh@linuxfoundation.org>
To: Gwendal Grignou <gwendal@chromium.org>
Cc: andriy.shevchenko@linux.intel.com, stable@vger.kernel.org,
Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 5.4] nvme-pci: Move enumeration by class to be last in the table
Date: Tue, 14 Feb 2023 09:41:06 +0100 [thread overview]
Message-ID: <Y+tJIkadn0IMFvT+@kroah.com> (raw)
In-Reply-To: <20230208030824.235941-1-gwendal@chromium.org>
On Tue, Feb 07, 2023 at 07:08:24PM -0800, Gwendal Grignou wrote:
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> It's unusual that we have enumeration by class in the middle of the table.
> It might potentially be problematic in the future if we add another entry
> after it.
>
> So, move class matching entry to be the last in the ID table.
>
> [ Upstream commit 0b85f59d30b91bd2b93ea7ef0816a4b7e7039e8c ]
>
> Without this change, quirks set in driver_data added after the catch-all
> are ignored.
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Keith Busch <kbusch@kernel.org>
> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
> Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
> ---
> drivers/nvme/host/pci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2023-02-14 8:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 3:08 [PATCH 5.4] nvme-pci: Move enumeration by class to be last in the table Gwendal Grignou
2023-02-14 8:41 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+tJIkadn0IMFvT+@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=chaitanya.kulkarni@wdc.com \
--cc=gwendal@chromium.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.