From: Eric Biggers <ebiggers@kernel.org>
To: Munehisa Kamata <kamatam@amazon.com>
Cc: surenb@google.com, hannes@cmpxchg.org, hdanton@sina.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
mengcc@amazon.com, stable@vger.kernel.org
Subject: Re: [PATCH v3] sched/psi: fix use-after-free in ep_remove_wait_queue()
Date: Tue, 14 Feb 2023 18:55:41 +0000 [thread overview]
Message-ID: <Y+vZLQXlkf/7XvVB@gmail.com> (raw)
In-Reply-To: <20230214181335.3946674-1-kamatam@amazon.com>
On Tue, Feb 14, 2023 at 10:13:35AM -0800, Munehisa Kamata wrote:
> Using wake_up_pollfree() here might be less than ideal, but it also is not
> fully contradicting the comment at commit 42288cb44c4b ("wait: add
> wake_up_pollfree()") since the waitqueue's lifetime is not tied to file's
> one and can be considered as another special case.
If that comment is outdated now, then please update the comment too. We can do
better than "not fully contradicting".
- Eric
next prev parent reply other threads:[~2023-02-14 18:55 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 22:48 another use-after-free in ep_remove_wait_queue() Munehisa Kamata
2023-01-06 23:34 ` Suren Baghdasaryan
2023-01-07 8:07 ` Hillf Danton
2023-01-08 22:25 ` Munehisa Kamata
2023-01-08 23:49 ` Hillf Danton
2023-01-10 1:33 ` Suren Baghdasaryan
2023-01-10 3:06 ` Suren Baghdasaryan
2023-01-12 22:01 ` Suren Baghdasaryan
2023-01-13 2:25 ` Munehisa Kamata
2023-01-13 17:52 ` Suren Baghdasaryan
2023-01-19 3:06 ` Suren Baghdasaryan
2023-01-19 21:01 ` Suren Baghdasaryan
2023-01-19 22:25 ` Johannes Weiner
2023-01-20 1:30 ` Hillf Danton
2023-01-20 1:37 ` Suren Baghdasaryan
2023-01-20 2:46 ` Munehisa Kamata
2023-01-20 2:52 ` Munehisa Kamata
2023-01-20 9:00 ` Hillf Danton
2023-01-20 16:28 ` Suren Baghdasaryan
2023-01-21 5:17 ` Hillf Danton
2023-01-22 3:01 ` Suren Baghdasaryan
2023-01-20 1:45 ` Munehisa Kamata
2023-02-02 3:00 ` [PATCH] sched/psi: fix " Munehisa Kamata
2023-02-02 4:56 ` Eric Biggers
2023-02-02 21:11 ` Suren Baghdasaryan
2023-02-09 17:09 ` Suren Baghdasaryan
2023-02-09 18:46 ` Eric Biggers
2023-02-09 19:13 ` Suren Baghdasaryan
2023-02-13 23:50 ` Suren Baghdasaryan
2023-02-14 7:04 ` [PATCH v2] " Munehisa Kamata
2023-02-14 17:10 ` Suren Baghdasaryan
2023-02-14 18:13 ` [PATCH v3] " Munehisa Kamata
2023-02-14 18:28 ` Suren Baghdasaryan
2023-02-14 18:29 ` Suren Baghdasaryan
2023-02-14 18:55 ` Eric Biggers [this message]
2023-02-14 19:13 ` Suren Baghdasaryan
2023-02-14 18:37 ` [PATCH v2] " Munehisa Kamata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+vZLQXlkf/7XvVB@gmail.com \
--to=ebiggers@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=hdanton@sina.com \
--cc=kamatam@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mengcc@amazon.com \
--cc=stable@vger.kernel.org \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.