From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alexander Atanasov <alexander.atanasov@virtuozzo.com>
Cc: Nadav Amit <namit@vmware.com>,
VMware PV-Drivers Reviewers <pv-drivers@vmware.com>,
Arnd Bergmann <arnd@arndb.de>,
kernel@openvz.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v5 6/8] drivers: vmware: balloon - report inflated memory
Date: Wed, 19 Oct 2022 12:49:53 +0200 [thread overview]
Message-ID: <Y0/WUdUIJ6O7EzQg@kroah.com> (raw)
In-Reply-To: <2ae8251a-456d-abdd-ed1a-1bfc04356741@virtuozzo.com>
On Wed, Oct 19, 2022 at 01:38:13PM +0300, Alexander Atanasov wrote:
> On 19.10.22 13:26, Greg Kroah-Hartman wrote:
> > On Wed, Oct 19, 2022 at 12:56:18PM +0300, Alexander Atanasov wrote:
> > > Update the inflated memory in the mm core on change.
> >
> > That says what this does, but not why it is needed.
> >
> > Please expand on this.
> >
> > Also, is this actually fixing a bug? Is it a new feature? Something
> > else?
>
> The whole series is about adding a new feature - providing access to the
> balloon inflated memory amount - it's in the cover letter. Should I repeat
> it for every driver that implements it?
Each commit needs to justify why it is needed on its own. You do not
provide the needed information here at all to be able to review and
understand if this commit is even correct or needed.
thanks,
greg k-h
next prev parent reply other threads:[~2022-10-19 13:37 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 9:56 [RFC PATCH v5 0/8] Make balloon drivers' memory changes known to the rest of the kernel Alexander Atanasov
2022-10-19 9:56 ` Alexander Atanasov
2022-10-19 9:56 ` [RFC PATCH v5 1/8] mm: Make a place for a common balloon code Alexander Atanasov
2022-10-19 9:56 ` Alexander Atanasov
2022-10-19 9:56 ` [RFC PATCH v5 2/8] mm: Enable balloon drivers to report inflated memory Alexander Atanasov
2022-10-19 9:56 ` [RFC PATCH v5 3/8] mm: Display inflated memory to users Alexander Atanasov
2022-10-19 9:56 ` [RFC PATCH v5 4/8] mm: Display inflated memory in logs Alexander Atanasov
2022-10-19 9:56 ` [RFC PATCH v5 5/8] drivers: virtio: balloon - report inflated memory Alexander Atanasov
2022-10-19 9:56 ` [RFC PATCH v5 6/8] drivers: vmware: " Alexander Atanasov
2022-10-19 10:26 ` Greg Kroah-Hartman
2022-10-19 10:38 ` Alexander Atanasov
2022-10-19 10:49 ` Greg Kroah-Hartman [this message]
2022-10-19 11:06 ` Alexander Atanasov
2022-10-21 6:50 ` Nadav Amit
2022-10-21 7:25 ` Alexander Atanasov
2022-10-21 7:31 ` Nadav Amit
2022-10-21 8:02 ` Alexander Atanasov
2022-10-19 9:56 ` [RFC PATCH v5 7/8] drivers: hyperv: " Alexander Atanasov
2022-10-19 9:56 ` [RFC PATCH v5 8/8] documentation: create a document about how balloon drivers operate Alexander Atanasov
2022-10-19 13:53 ` Jonathan Corbet
2022-10-19 10:53 ` [RFC PATCH v5 0/8] Make balloon drivers' memory changes known to the rest of the kernel Konstantin Khlebnikov
2022-10-19 10:53 ` Konstantin Khlebnikov
2022-10-19 11:06 ` Denis V. Lunev
2022-10-19 11:06 ` Denis V. Lunev via Virtualization
2022-10-19 15:39 ` Konstantin Khlebnikov
2022-10-19 15:39 ` Konstantin Khlebnikov
2022-10-19 18:03 ` Alexander Atanasov
2022-10-19 11:44 ` Alexander Atanasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0/WUdUIJ6O7EzQg@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alexander.atanasov@virtuozzo.com \
--cc=arnd@arndb.de \
--cc=kernel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namit@vmware.com \
--cc=pv-drivers@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.